Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401247 > unrolled thread
| Started by | Amit Ghadge <amitg.b14@gmail.com> |
|---|---|
| First post | 2016-05-16 04:10 +0200 |
| Last post | 2016-05-16 17:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'. Amit Ghadge <amitg.b14@gmail.com> - 2016-05-16 04:10 +0200
Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'. Ian Abbott <abbotti@mev.co.uk> - 2016-05-16 12:40 +0200
Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'. Greg KH <gregkh@linuxfoundation.org> - 2016-05-16 17:20 +0200
| From | Amit Ghadge <amitg.b14@gmail.com> |
|---|---|
| Date | 2016-05-16 04:10 +0200 |
| Subject | [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'. |
| Message-ID | <rzg8Y-u7-277@gated-at.bofh.it> |
Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
outb(0, dev->iobase + DAQP_AUX_REG);
for (i = 0; i > insn->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
--
2.5.0
[toc] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2016-05-16 12:40 +0200 |
| Subject | Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'. |
| Message-ID | <rzo6m-5Lf-19@gated-at.bofh.it> |
| In reply to | #1401247 |
On 15/05/16 20:45, Amit Ghadge wrote:
> Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index e9e4313..802f51e 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
> outb(0, dev->iobase + DAQP_AUX_REG);
>
> for (i = 0; i > insn->n; i++) {
> - unsigned val = data[i];
> + unsigned int val = data[i];
> int ret;
>
> /* D/A transfer rate is about 8ms */
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-16 17:20 +0200 |
| Subject | Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'. |
| Message-ID | <rzstj-df-3@gated-at.bofh.it> |
| In reply to | #1401247 |
On Mon, May 16, 2016 at 01:15:24AM +0530, Amit Ghadge wrote: > Signed-off-by: Amit Ghadge <amitg.b14@gmail.com> > --- > drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I can't take a patch without a changelog text in it. Please fix and resend.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web