Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1402160 > unrolled thread
| Started by | David Kershner <david.kershner@unisys.com> |
|---|---|
| First post | 2016-05-17 09:40 +0200 |
| Last post | 2016-05-17 16:00 +0200 |
| Articles | 9 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 David Kershner <david.kershner@unisys.com> - 2016-05-17 09:40 +0200
Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Greg KH <gregkh@linuxfoundation.org> - 2016-05-17 16:00 +0200
Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-05-17 16:10 +0200
Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Greg KH <gregkh@linuxfoundation.org> - 2016-05-17 16:30 +0200
Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-05-18 02:00 +0200
Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Greg KH <gregkh@linuxfoundation.org> - 2016-05-18 02:10 +0200
Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-05-18 18:10 +0200
Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 Greg KH <gregkh@linuxfoundation.org> - 2016-05-18 19:30 +0200
Re: [PATCH 3/5] Documentation: Move visorbus documentation from staging to Documentation/ Greg KH <gregkh@linuxfoundation.org> - 2016-05-17 16:00 +0200
| From | David Kershner <david.kershner@unisys.com> |
|---|---|
| Date | 2016-05-17 09:40 +0200 |
| Subject | [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 |
| Message-ID | <rzHLH-1Co-7@gated-at.bofh.it> |
This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus)
and its dependent headers files (from drivers/staging/unisys/include)
out of staging into the main kernel tree.
The visorbus driver is a bus driver for various paravirtualized devices
presented within a Unisys s-Par guest environment. Drivers for these
devices are also currently present under drivers/staging/unisys/, which we
intend to also move out of staging immediately after visorbus. All of
these other drivers are dependent upon visorbus and the include directory,
which is why we would like to move these first.
Our initial consultations with various members of the community have led us
to the conclusion that the most appropriate locations for these is:
arch/x86/visorbus/ (driver)
include/linux/visorbus/ (header files)
The rationale is that visorbus is dependent on x86-64 architecture.
David Kershner (5):
staging: unisys: Move vbushelper.h to visorbus directory
include: linux: visorbus: Add visorbus to include/linux directory
Documentation: Move visorbus documentation from staging to
Documentation/
staging: unisys: visorbus: Have visorbus use include/linux/visorbus
arch: x86: add visorbus directory to arch/x86
Documentation/ABI/stable/sysfs-bus-visorbus | 89 +
Documentation/visorbus.txt | 337 +++
arch/x86/Kbuild | 3 +
arch/x86/Kconfig | 2 +
arch/x86/visorbus/Kconfig | 14 +
arch/x86/visorbus/Makefile | 8 +
arch/x86/visorbus/controlvmchannel.h | 485 ++++
arch/x86/visorbus/controlvmcompletionstatus.h | 101 +
arch/x86/visorbus/iovmcall_gnuc.h | 48 +
arch/x86/visorbus/periodic_work.c | 203 ++
arch/x86/visorbus/vbuschannel.h | 95 +
arch/x86/visorbus/vbusdeviceinfo.h | 213 ++
arch/x86/visorbus/vbushelper.h | 46 +
arch/x86/visorbus/visorbus_main.c | 1344 +++++++++++
arch/x86/visorbus/visorbus_private.h | 68 +
arch/x86/visorbus/visorchannel.c | 635 ++++++
arch/x86/visorbus/visorchipset.c | 2355 ++++++++++++++++++++
arch/x86/visorbus/vmcallinterface.h | 91 +
.../Documentation/ABI/sysfs-platform-visorchipset | 89 -
drivers/staging/unisys/Documentation/overview.txt | 337 ---
drivers/staging/unisys/Kconfig | 1 -
drivers/staging/unisys/Makefile | 1 -
drivers/staging/unisys/include/vbushelper.h | 46 -
drivers/staging/unisys/visorbus/Kconfig | 14 -
drivers/staging/unisys/visorbus/Makefile | 12 -
drivers/staging/unisys/visorbus/controlvmchannel.h | 485 ----
.../unisys/visorbus/controlvmcompletionstatus.h | 101 -
drivers/staging/unisys/visorbus/iovmcall_gnuc.h | 48 -
drivers/staging/unisys/visorbus/periodic_work.c | 204 --
drivers/staging/unisys/visorbus/vbuschannel.h | 94 -
drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 213 --
drivers/staging/unisys/visorbus/visorbus_main.c | 1344 -----------
drivers/staging/unisys/visorbus/visorbus_private.h | 68 -
drivers/staging/unisys/visorbus/visorchannel.c | 635 ------
drivers/staging/unisys/visorbus/visorchipset.c | 2355 --------------------
drivers/staging/unisys/visorbus/vmcallinterface.h | 92 -
include/linux/visorbus/channel.h | 572 +++++
include/linux/visorbus/channel_guid.h | 55 +
include/linux/visorbus/diagchannel.h | 38 +
include/linux/visorbus/guestlinuxdebug.h | 180 ++
include/linux/visorbus/iochannel.h | 571 +++++
include/linux/visorbus/periodic_work.h | 40 +
include/linux/visorbus/vbushelper.h | 46 +
include/linux/visorbus/version.h | 45 +
include/linux/visorbus/visorbus.h | 234 ++
45 files changed, 7918 insertions(+), 6139 deletions(-)
create mode 100644 Documentation/ABI/stable/sysfs-bus-visorbus
create mode 100644 Documentation/visorbus.txt
create mode 100644 arch/x86/visorbus/Kconfig
create mode 100644 arch/x86/visorbus/Makefile
create mode 100644 arch/x86/visorbus/controlvmchannel.h
create mode 100644 arch/x86/visorbus/controlvmcompletionstatus.h
create mode 100644 arch/x86/visorbus/iovmcall_gnuc.h
create mode 100644 arch/x86/visorbus/periodic_work.c
create mode 100644 arch/x86/visorbus/vbuschannel.h
create mode 100644 arch/x86/visorbus/vbusdeviceinfo.h
create mode 100644 arch/x86/visorbus/vbushelper.h
create mode 100644 arch/x86/visorbus/visorbus_main.c
create mode 100644 arch/x86/visorbus/visorbus_private.h
create mode 100644 arch/x86/visorbus/visorchannel.c
create mode 100644 arch/x86/visorbus/visorchipset.c
create mode 100644 arch/x86/visorbus/vmcallinterface.h
delete mode 100644 drivers/staging/unisys/Documentation/ABI/sysfs-platform-visorchipset
delete mode 100644 drivers/staging/unisys/Documentation/overview.txt
delete mode 100644 drivers/staging/unisys/include/vbushelper.h
delete mode 100644 drivers/staging/unisys/visorbus/Kconfig
delete mode 100644 drivers/staging/unisys/visorbus/Makefile
delete mode 100644 drivers/staging/unisys/visorbus/controlvmchannel.h
delete mode 100644 drivers/staging/unisys/visorbus/controlvmcompletionstatus.h
delete mode 100644 drivers/staging/unisys/visorbus/iovmcall_gnuc.h
delete mode 100644 drivers/staging/unisys/visorbus/periodic_work.c
delete mode 100644 drivers/staging/unisys/visorbus/vbuschannel.h
delete mode 100644 drivers/staging/unisys/visorbus/vbusdeviceinfo.h
delete mode 100644 drivers/staging/unisys/visorbus/visorbus_main.c
delete mode 100644 drivers/staging/unisys/visorbus/visorbus_private.h
delete mode 100644 drivers/staging/unisys/visorbus/visorchannel.c
delete mode 100644 drivers/staging/unisys/visorbus/visorchipset.c
delete mode 100644 drivers/staging/unisys/visorbus/vmcallinterface.h
create mode 100644 include/linux/visorbus/channel.h
create mode 100644 include/linux/visorbus/channel_guid.h
create mode 100644 include/linux/visorbus/diagchannel.h
create mode 100644 include/linux/visorbus/guestlinuxdebug.h
create mode 100644 include/linux/visorbus/iochannel.h
create mode 100644 include/linux/visorbus/periodic_work.h
create mode 100644 include/linux/visorbus/vbushelper.h
create mode 100644 include/linux/visorbus/version.h
create mode 100644 include/linux/visorbus/visorbus.h
--
1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-17 16:00 +0200 |
| Subject | Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 |
| Message-ID | <rzNHw-5fA-5@gated-at.bofh.it> |
| In reply to | #1402160 |
On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: > This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) > and its dependent headers files (from drivers/staging/unisys/include) > out of staging into the main kernel tree. > > The visorbus driver is a bus driver for various paravirtualized devices > presented within a Unisys s-Par guest environment. Drivers for these > devices are also currently present under drivers/staging/unisys/, which we > intend to also move out of staging immediately after visorbus. All of > these other drivers are dependent upon visorbus and the include directory, > which is why we would like to move these first. > > Our initial consultations with various members of the community have led us > to the conclusion that the most appropriate locations for these is: > arch/x86/visorbus/ (driver) > include/linux/visorbus/ (header files) > > The rationale is that visorbus is dependent on x86-64 architecture. What makes it dependent on x86? What prevents it from running on some other architecture (not the fact that no one has made such hardware, just the code reasons please.) And given that this is the middle of the merge window, no maintainer is going to have any time to do anything with these, can you please resend them after 4.7-rc1 is out? thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Date | 2016-05-17 16:10 +0200 |
| Message-ID | <rzNR9-5y2-37@gated-at.bofh.it> |
| In reply to | #1402354 |
Greg KH <gregkh@linuxfoundation.org> writes: > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) >> and its dependent headers files (from drivers/staging/unisys/include) >> out of staging into the main kernel tree. >> >> The visorbus driver is a bus driver for various paravirtualized devices >> presented within a Unisys s-Par guest environment. Drivers for these >> devices are also currently present under drivers/staging/unisys/, which we >> intend to also move out of staging immediately after visorbus. All of >> these other drivers are dependent upon visorbus and the include directory, >> which is why we would like to move these first. >> >> Our initial consultations with various members of the community have led us >> to the conclusion that the most appropriate locations for these is: >> arch/x86/visorbus/ (driver) >> include/linux/visorbus/ (header files) >> >> The rationale is that visorbus is dependent on x86-64 architecture. > > What makes it dependent on x86? What prevents it from running on some > other architecture (not the fact that no one has made such hardware, > just the code reasons please.) It's dependent on system firmware which is only available on the S-Par platform which is x86_64 only. The closest similarity is probably what you find on the PPC and Sparc platforms. Jes
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-17 16:30 +0200 |
| Subject | Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 |
| Message-ID | <rzOau-5Hf-29@gated-at.bofh.it> |
| In reply to | #1402361 |
On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: > Greg KH <gregkh@linuxfoundation.org> writes: > > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: > >> This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) > >> and its dependent headers files (from drivers/staging/unisys/include) > >> out of staging into the main kernel tree. > >> > >> The visorbus driver is a bus driver for various paravirtualized devices > >> presented within a Unisys s-Par guest environment. Drivers for these > >> devices are also currently present under drivers/staging/unisys/, which we > >> intend to also move out of staging immediately after visorbus. All of > >> these other drivers are dependent upon visorbus and the include directory, > >> which is why we would like to move these first. > >> > >> Our initial consultations with various members of the community have led us > >> to the conclusion that the most appropriate locations for these is: > >> arch/x86/visorbus/ (driver) > >> include/linux/visorbus/ (header files) > >> > >> The rationale is that visorbus is dependent on x86-64 architecture. > > > > What makes it dependent on x86? What prevents it from running on some > > other architecture (not the fact that no one has made such hardware, > > just the code reasons please.) > > It's dependent on system firmware which is only available on the S-Par > platform which is x86_64 only. The closest similarity is probably what > you find on the PPC and Sparc platforms. Ok, but still no need to put it under arch/ anything, it should go in drivers/ like all other drivers and busses are, no matter what the arch it happens to run on is. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Date | 2016-05-18 02:00 +0200 |
| Message-ID | <rzX45-2JS-5@gated-at.bofh.it> |
| In reply to | #1402371 |
Greg KH <gregkh@linuxfoundation.org> writes: > On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: >> Greg KH <gregkh@linuxfoundation.org> writes: >> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> >> This patchset moves the visorbus driver >> >> (fromdrivers/staging/unisys/visorbus) >> >> and its dependent headers files (from drivers/staging/unisys/include) >> >> out of staging into the main kernel tree. >> >> >> >> The visorbus driver is a bus driver for various paravirtualized devices >> >> presented within a Unisys s-Par guest environment. Drivers for these >> >> devices are also currently present under drivers/staging/unisys/, which we >> >> intend to also move out of staging immediately after visorbus. All of >> >> these other drivers are dependent upon visorbus and the include directory, >> >> which is why we would like to move these first. >> >> >> >> Our initial consultations with various members of the community have led us >> >> to the conclusion that the most appropriate locations for these is: >> >> arch/x86/visorbus/ (driver) >> >> include/linux/visorbus/ (header files) >> >> >> >> The rationale is that visorbus is dependent on x86-64 architecture. >> > >> > What makes it dependent on x86? What prevents it from running on some >> > other architecture (not the fact that no one has made such hardware, >> > just the code reasons please.) >> >> It's dependent on system firmware which is only available on the S-Par >> platform which is x86_64 only. The closest similarity is probably what >> you find on the PPC and Sparc platforms. > > Ok, but still no need to put it under arch/ anything, it should go in > drivers/ like all other drivers and busses are, no matter what the arch > it happens to run on is. I don't think thats obvious. arch/x86/kvm is an example of this, Sparc and PPC also have their stuff under arch/. I am open, if people prefer to have drivers/visorbus I can support that. I find right now it's really messy with things being put all over the place, and it's not obvious what the real placement is for all of this. Jes
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-18 02:10 +0200 |
| Subject | Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 |
| Message-ID | <rzXdL-325-3@gated-at.bofh.it> |
| In reply to | #1402656 |
On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote: > Greg KH <gregkh@linuxfoundation.org> writes: > > On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: > >> Greg KH <gregkh@linuxfoundation.org> writes: > >> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: > >> >> This patchset moves the visorbus driver > >> >> (fromdrivers/staging/unisys/visorbus) > >> >> and its dependent headers files (from drivers/staging/unisys/include) > >> >> out of staging into the main kernel tree. > >> >> > >> >> The visorbus driver is a bus driver for various paravirtualized devices > >> >> presented within a Unisys s-Par guest environment. Drivers for these > >> >> devices are also currently present under drivers/staging/unisys/, which we > >> >> intend to also move out of staging immediately after visorbus. All of > >> >> these other drivers are dependent upon visorbus and the include directory, > >> >> which is why we would like to move these first. > >> >> > >> >> Our initial consultations with various members of the community have led us > >> >> to the conclusion that the most appropriate locations for these is: > >> >> arch/x86/visorbus/ (driver) > >> >> include/linux/visorbus/ (header files) > >> >> > >> >> The rationale is that visorbus is dependent on x86-64 architecture. > >> > > >> > What makes it dependent on x86? What prevents it from running on some > >> > other architecture (not the fact that no one has made such hardware, > >> > just the code reasons please.) > >> > >> It's dependent on system firmware which is only available on the S-Par > >> platform which is x86_64 only. The closest similarity is probably what > >> you find on the PPC and Sparc platforms. > > > > Ok, but still no need to put it under arch/ anything, it should go in > > drivers/ like all other drivers and busses are, no matter what the arch > > it happens to run on is. > > I don't think thats obvious. arch/x86/kvm is an example of this, Sparc > and PPC also have their stuff under arch/. For some things, yes, but let's not make the same mistakes as others :) Look at drivers/hv/ for an example of a very x86-only bus and driver subsystem living in drivers/ Please don't burry driver stuff in arch/ the ARM developers are trying to fix their mistakes of the past and move all of their cruft out of arch/ for that reason. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Date | 2016-05-18 18:10 +0200 |
| Message-ID | <rAccO-4lF-35@gated-at.bofh.it> |
| In reply to | #1402661 |
Greg KH <gregkh@linuxfoundation.org> writes: > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote: >> > Ok, but still no need to put it under arch/ anything, it should go in >> > drivers/ like all other drivers and busses are, no matter what the arch >> > it happens to run on is. >> >> I don't think thats obvious. arch/x86/kvm is an example of this, Sparc >> and PPC also have their stuff under arch/. > > For some things, yes, but let's not make the same mistakes as others :) > > Look at drivers/hv/ for an example of a very x86-only bus and driver > subsystem living in drivers/ Please don't burry driver stuff in arch/ > the ARM developers are trying to fix their mistakes of the past and move > all of their cruft out of arch/ for that reason. Works for me. So should they put it in drivers/visorbus or drivers/bus/visorbus? What about drivers/virt? Would you suggest hv and xen gets moved in there? Cheers, Jes
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-18 19:30 +0200 |
| Subject | Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 |
| Message-ID | <rAdsj-54h-27@gated-at.bofh.it> |
| In reply to | #1403122 |
On Wed, May 18, 2016 at 12:03:58PM -0400, Jes Sorensen wrote: > Greg KH <gregkh@linuxfoundation.org> writes: > > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote: > >> > Ok, but still no need to put it under arch/ anything, it should go in > >> > drivers/ like all other drivers and busses are, no matter what the arch > >> > it happens to run on is. > >> > >> I don't think thats obvious. arch/x86/kvm is an example of this, Sparc > >> and PPC also have their stuff under arch/. > > > > For some things, yes, but let's not make the same mistakes as others :) > > > > Look at drivers/hv/ for an example of a very x86-only bus and driver > > subsystem living in drivers/ Please don't burry driver stuff in arch/ > > the ARM developers are trying to fix their mistakes of the past and move > > all of their cruft out of arch/ for that reason. > > Works for me. > > So should they put it in drivers/visorbus or drivers/bus/visorbus? drivers/visorbus please. drivers/bus/ is an "odd" thing :( > What about drivers/virt? Would you suggest hv and xen gets moved in > there? Ah, yeah, that would be great, never noticed it before, despite being there since 2011... thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-17 16:00 +0200 |
| Subject | Re: [PATCH 3/5] Documentation: Move visorbus documentation from staging to Documentation/ |
| Message-ID | <rzNHw-5fA-15@gated-at.bofh.it> |
| In reply to | #1402160 |
On Tue, May 17, 2016 at 03:27:59AM -0400, David Kershner wrote: > This patch simple does a git mv of the > drivers/staging/unisys/Documentation directory to Documentation. Renames > overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to > the correct name sysfs-bus-visorbus. > > Signed-off-by: David Kershner <david.kershner@unisys.com> > --- > Documentation/ABI/stable/sysfs-bus-visorbus | 89 ++++++ > Documentation/visorbus.txt | 337 +++++++++++++++++++++ > .../Documentation/ABI/sysfs-platform-visorchipset | 89 ------ > drivers/staging/unisys/Documentation/overview.txt | 337 --------------------- > 4 files changed, 426 insertions(+), 426 deletions(-) > create mode 100644 Documentation/ABI/stable/sysfs-bus-visorbus > create mode 100644 Documentation/visorbus.txt > delete mode 100644 drivers/staging/unisys/Documentation/ABI/sysfs-platform-visorchipset > delete mode 100644 drivers/staging/unisys/Documentation/overview.txt Always create patches with -M so that they are tiny and we can see you are moving files around, not deleting and adding them. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web