Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1402234 > unrolled thread
| Started by | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| First post | 2016-05-17 11:50 +0200 |
| Last post | 2016-05-17 22:40 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/5] drm/amd/amdgpu : Remove unused variable Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-05-17 11:50 +0200
[PATCH 5/5] drm/amd/amdgpu : Remove unused variable Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-05-17 11:50 +0200
RE: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable "Zhang, Jerry" <Jerry.Zhang@amd.com> - 2016-05-18 02:40 +0200
Re: [PATCH 1/5] drm/amd/amdgpu : Remove unused variable Alex Deucher <alexdeucher@gmail.com> - 2016-05-17 22:40 +0200
| From | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| Date | 2016-05-17 11:50 +0200 |
| Subject | [PATCH 1/5] drm/amd/amdgpu : Remove unused variable |
| Message-ID | <rzJNv-2Rf-5@gated-at.bofh.it> |
Remove unused variable 'ret', and directly return 0.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/cik_ih.c b/drivers/gpu/drm/amd/amdgpu/cik_ih.c
index f2f14fe..e78c9bd 100644
--- a/drivers/gpu/drm/amd/amdgpu/cik_ih.c
+++ b/drivers/gpu/drm/amd/amdgpu/cik_ih.c
@@ -103,7 +103,6 @@ static void cik_ih_disable_interrupts(struct amdgpu_device *adev)
*/
static int cik_ih_irq_init(struct amdgpu_device *adev)
{
- int ret = 0;
int rb_bufsz;
u32 interrupt_cntl, ih_cntl, ih_rb_cntl;
u64 wptr_off;
@@ -156,7 +155,7 @@ static int cik_ih_irq_init(struct amdgpu_device *adev)
/* enable irqs */
cik_ih_enable_interrupts(adev);
- return ret;
+ return 0;
}
/**
--
1.9.1
[toc] | [next] | [standalone]
| From | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| Date | 2016-05-17 11:50 +0200 |
| Subject | [PATCH 5/5] drm/amd/amdgpu : Remove unused variable |
| Message-ID | <rzJNw-2Rf-31@gated-at.bofh.it> |
| In reply to | #1402234 |
Remove unused variable 'ret', and directly return 0.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
index 55cdab8..cba951a 100644
--- a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
+++ b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
@@ -99,7 +99,6 @@ static void tonga_ih_disable_interrupts(struct amdgpu_device *adev)
*/
static int tonga_ih_irq_init(struct amdgpu_device *adev)
{
- int ret = 0;
int rb_bufsz;
u32 interrupt_cntl, ih_rb_cntl, ih_doorbell_rtpr;
u64 wptr_off;
@@ -165,7 +164,7 @@ static int tonga_ih_irq_init(struct amdgpu_device *adev)
/* enable interrupts */
tonga_ih_enable_interrupts(adev);
- return ret;
+ return 0;
}
/**
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | "Zhang, Jerry" <Jerry.Zhang@amd.com> |
|---|---|
| Date | 2016-05-18 02:40 +0200 |
| Subject | RE: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable |
| Message-ID | <rzXGO-3dg-13@gated-at.bofh.it> |
| In reply to | #1402235 |
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
Regards,
Jerry (Junwei Zhang)
SRDC SW Development
AMD Shanghai
_____________________________________
> -----Original Message-----
> From: Muhammad Falak R Wani [mailto:falakreyaz@gmail.com]
> Sent: Tuesday, May 17, 2016 5:43 PM
> To: David Airlie
> Cc: Deucher, Alexander; Koenig, Christian; Zhou, Jammy; Dave Airlie; StDenis,
> Tom; Yang, Young; Zhang, Jerry; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 5/5] drm/amd/amdgpu : Remove unused variable
>
> Remove unused variable 'ret', and directly return 0.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> index 55cdab8..cba951a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/tonga_ih.c
> @@ -99,7 +99,6 @@ static void tonga_ih_disable_interrupts(struct
> amdgpu_device *adev)
> */
> static int tonga_ih_irq_init(struct amdgpu_device *adev) {
> - int ret = 0;
> int rb_bufsz;
> u32 interrupt_cntl, ih_rb_cntl, ih_doorbell_rtpr;
> u64 wptr_off;
> @@ -165,7 +164,7 @@ static int tonga_ih_irq_init(struct amdgpu_device *adev)
> /* enable interrupts */
> tonga_ih_enable_interrupts(adev);
>
> - return ret;
> + return 0;
> }
>
> /**
> --
> 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Alex Deucher <alexdeucher@gmail.com> |
|---|---|
| Date | 2016-05-17 22:40 +0200 |
| Message-ID | <rzTWx-T4-3@gated-at.bofh.it> |
| In reply to | #1402234 |
On Tue, May 17, 2016 at 5:42 AM, Muhammad Falak R Wani
<falakreyaz@gmail.com> wrote:
> Remove unused variable 'ret', and directly return 0.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Applied the series. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/cik_ih.c b/drivers/gpu/drm/amd/amdgpu/cik_ih.c
> index f2f14fe..e78c9bd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/cik_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/cik_ih.c
> @@ -103,7 +103,6 @@ static void cik_ih_disable_interrupts(struct amdgpu_device *adev)
> */
> static int cik_ih_irq_init(struct amdgpu_device *adev)
> {
> - int ret = 0;
> int rb_bufsz;
> u32 interrupt_cntl, ih_cntl, ih_rb_cntl;
> u64 wptr_off;
> @@ -156,7 +155,7 @@ static int cik_ih_irq_init(struct amdgpu_device *adev)
> /* enable irqs */
> cik_ih_enable_interrupts(adev);
>
> - return ret;
> + return 0;
> }
>
> /**
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web