Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1400247 > unrolled thread

[PATCH] qxl: catch qxlfb_create_pinned_object failures

Started byGerd Hoffmann <kraxel@redhat.com>
First post2016-05-12 19:10 +0200
Last post2016-05-17 09:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] qxl: catch qxlfb_create_pinned_object failures Gerd Hoffmann <kraxel@redhat.com> - 2016-05-12 19:10 +0200
    Re: [PATCH] qxl: catch qxlfb_create_pinned_object failures Daniel Vetter <daniel@ffwll.ch> - 2016-05-17 09:20 +0200

#1400247 — [PATCH] qxl: catch qxlfb_create_pinned_object failures

FromGerd Hoffmann <kraxel@redhat.com>
Date2016-05-12 19:10 +0200
Subject[PATCH] qxl: catch qxlfb_create_pinned_object failures
Message-ID<ry2hA-1IC-19@gated-at.bofh.it>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/gpu/drm/qxl/qxl_fb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
index 7136e52..17c1ef0 100644
--- a/drivers/gpu/drm/qxl/qxl_fb.c
+++ b/drivers/gpu/drm/qxl/qxl_fb.c
@@ -360,6 +360,9 @@ static int qxlfb_create(struct qxl_fbdev *qfbdev,
 	mode_cmd.pixel_format = drm_mode_legacy_fb_format(bpp, depth);
 
 	ret = qxlfb_create_pinned_object(qfbdev, &mode_cmd, &gobj);
+	if (ret < 0)
+		return ret;
+
 	qbo = gem_to_qxl_bo(gobj);
 	QXL_INFO(qdev, "%s: %dx%d %d\n", __func__, mode_cmd.width,
 		 mode_cmd.height, mode_cmd.pitches[0]);
-- 
1.8.3.1

[toc] | [next] | [standalone]


#1402151

FromDaniel Vetter <daniel@ffwll.ch>
Date2016-05-17 09:20 +0200
Message-ID<rzHsl-1uo-13@gated-at.bofh.it>
In reply to#1400247
On Thu, May 12, 2016 at 07:06:56PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/qxl/qxl_fb.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
> index 7136e52..17c1ef0 100644
> --- a/drivers/gpu/drm/qxl/qxl_fb.c
> +++ b/drivers/gpu/drm/qxl/qxl_fb.c
> @@ -360,6 +360,9 @@ static int qxlfb_create(struct qxl_fbdev *qfbdev,
>  	mode_cmd.pixel_format = drm_mode_legacy_fb_format(bpp, depth);
>  
>  	ret = qxlfb_create_pinned_object(qfbdev, &mode_cmd, &gobj);
> +	if (ret < 0)
> +		return ret;
> +
>  	qbo = gem_to_qxl_bo(gobj);
>  	QXL_INFO(qdev, "%s: %dx%d %d\n", __func__, mode_cmd.width,
>  		 mode_cmd.height, mode_cmd.pitches[0]);
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web