Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401454 > unrolled thread
| Started by | Vignesh R <vigneshr@ti.com> |
|---|---|
| First post | 2016-05-16 13:40 +0200 |
| Last post | 2016-05-17 08:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] AM335x: tsc: Fix suspended while touchscreen in use Vignesh R <vigneshr@ti.com> - 2016-05-16 13:40 +0200
[PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend Vignesh R <vigneshr@ti.com> - 2016-05-16 13:40 +0200
Re: [PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-16 21:50 +0200
Re: [PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend Lee Jones <lee.jones@linaro.org> - 2016-05-17 08:00 +0200
| From | Vignesh R <vigneshr@ti.com> |
|---|---|
| Date | 2016-05-16 13:40 +0200 |
| Subject | [PATCH 0/3] AM335x: tsc: Fix suspended while touchscreen in use |
| Message-ID | <rzoSJ-6j7-11@gated-at.bofh.it> |
On am335x-evm, its observed that touchscreen fails to wake system from suspend if user had finger on touch screen while entering system. This series addresses the above issue. Grygorii Strashko (2): Input: ti_am335x_tsc - Prevent system suspend when TSC is in use Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend Vignesh R (1): Input: ti_am335x_tsc - Mark IRQ as wakeup capable drivers/input/touchscreen/ti_am335x_tsc.c | 14 ++++++++++++++ include/linux/mfd/ti_am335x_tscadc.h | 1 + 2 files changed, 15 insertions(+) -- 2.8.2
[toc] | [next] | [standalone]
| From | Vignesh R <vigneshr@ti.com> |
|---|---|
| Date | 2016-05-16 13:40 +0200 |
| Subject | [PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend |
| Message-ID | <rzp2q-6ui-23@gated-at.bofh.it> |
| In reply to | #1401454 |
From: Grygorii Strashko <grygorii.strashko@ti.com>
It is seen that just enabling the TSC module triggers a HW_PEN IRQ
without any interaction with touchscreen by user. This results in first
suspend/resume sequence to fail as system immediately wakes up from
suspend as soon as HW_PEN IRQ is enabled in suspend handler. due to the
pending IRQ. Therefore clear all IRQs at probe and also in suspend
callback for sanity.
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
drivers/input/touchscreen/ti_am335x_tsc.c | 2 ++
include/linux/mfd/ti_am335x_tscadc.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 4683ed18b9f8..d2c55b5730e6 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -441,6 +441,7 @@ static int titsc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "irq wake enable failed.\n");
}
+ titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_FIFO0THRES);
titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_EOS);
err = titsc_config_wires(ts_dev);
@@ -506,6 +507,7 @@ static int __maybe_unused titsc_suspend(struct device *dev)
tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
if (device_may_wakeup(tscadc_dev->dev)) {
+ titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
idle = titsc_readl(ts_dev, REG_IRQENABLE);
titsc_writel(ts_dev, REG_IRQENABLE,
(idle | IRQENB_HW_PEN));
diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
index 1fd50dcfe47c..a7ca0f908ba8 100644
--- a/include/linux/mfd/ti_am335x_tscadc.h
+++ b/include/linux/mfd/ti_am335x_tscadc.h
@@ -60,6 +60,7 @@
#define IRQENB_FIFO1OVRRUN BIT(6)
#define IRQENB_FIFO1UNDRFLW BIT(7)
#define IRQENB_PENUP BIT(9)
+#define IRQENB_MASK (0x7FF)
/* Step Configuration */
#define STEPCONFIG_MODE_MASK (3 << 0)
--
2.8.2
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-05-16 21:50 +0200 |
| Subject | Re: [PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend |
| Message-ID | <rzwGB-2T8-13@gated-at.bofh.it> |
| In reply to | #1401459 |
On Mon, May 16, 2016 at 04:56:24PM +0530, Vignesh R wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
>
> It is seen that just enabling the TSC module triggers a HW_PEN IRQ
> without any interaction with touchscreen by user. This results in first
> suspend/resume sequence to fail as system immediately wakes up from
> suspend as soon as HW_PEN IRQ is enabled in suspend handler. due to the
> pending IRQ. Therefore clear all IRQs at probe and also in suspend
> callback for sanity.
What if user touches the screen while device's suspend routine is
executing?
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> drivers/input/touchscreen/ti_am335x_tsc.c | 2 ++
> include/linux/mfd/ti_am335x_tscadc.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> index 4683ed18b9f8..d2c55b5730e6 100644
> --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> @@ -441,6 +441,7 @@ static int titsc_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "irq wake enable failed.\n");
> }
>
> + titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
> titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_FIFO0THRES);
> titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_EOS);
> err = titsc_config_wires(ts_dev);
> @@ -506,6 +507,7 @@ static int __maybe_unused titsc_suspend(struct device *dev)
>
> tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
> if (device_may_wakeup(tscadc_dev->dev)) {
> + titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
> idle = titsc_readl(ts_dev, REG_IRQENABLE);
> titsc_writel(ts_dev, REG_IRQENABLE,
> (idle | IRQENB_HW_PEN));
> diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
> index 1fd50dcfe47c..a7ca0f908ba8 100644
> --- a/include/linux/mfd/ti_am335x_tscadc.h
> +++ b/include/linux/mfd/ti_am335x_tscadc.h
> @@ -60,6 +60,7 @@
> #define IRQENB_FIFO1OVRRUN BIT(6)
> #define IRQENB_FIFO1UNDRFLW BIT(7)
> #define IRQENB_PENUP BIT(9)
> +#define IRQENB_MASK (0x7FF)
>
> /* Step Configuration */
> #define STEPCONFIG_MODE_MASK (3 << 0)
> --
> 2.8.2
>
--
Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-05-17 08:00 +0200 |
| Subject | Re: [PATCH 3/3] Input: ti_am335x_tsc - Ack pending IRQs at probe and before suspend |
| Message-ID | <rzGcW-wU-3@gated-at.bofh.it> |
| In reply to | #1401459 |
On Mon, 16 May 2016, Vignesh R wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
>
> It is seen that just enabling the TSC module triggers a HW_PEN IRQ
> without any interaction with touchscreen by user. This results in first
> suspend/resume sequence to fail as system immediately wakes up from
> suspend as soon as HW_PEN IRQ is enabled in suspend handler. due to the
> pending IRQ. Therefore clear all IRQs at probe and also in suspend
> callback for sanity.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> drivers/input/touchscreen/ti_am335x_tsc.c | 2 ++
> include/linux/mfd/ti_am335x_tscadc.h | 1 +
For the MFD change:
Acked-by: Lee Jones <lee.jones@linaro.org>
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> index 4683ed18b9f8..d2c55b5730e6 100644
> --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> @@ -441,6 +441,7 @@ static int titsc_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "irq wake enable failed.\n");
> }
>
> + titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
> titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_FIFO0THRES);
> titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_EOS);
> err = titsc_config_wires(ts_dev);
> @@ -506,6 +507,7 @@ static int __maybe_unused titsc_suspend(struct device *dev)
>
> tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
> if (device_may_wakeup(tscadc_dev->dev)) {
> + titsc_writel(ts_dev, REG_IRQSTATUS, IRQENB_MASK);
> idle = titsc_readl(ts_dev, REG_IRQENABLE);
> titsc_writel(ts_dev, REG_IRQENABLE,
> (idle | IRQENB_HW_PEN));
> diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
> index 1fd50dcfe47c..a7ca0f908ba8 100644
> --- a/include/linux/mfd/ti_am335x_tscadc.h
> +++ b/include/linux/mfd/ti_am335x_tscadc.h
> @@ -60,6 +60,7 @@
> #define IRQENB_FIFO1OVRRUN BIT(6)
> #define IRQENB_FIFO1UNDRFLW BIT(7)
> #define IRQENB_PENUP BIT(9)
> +#define IRQENB_MASK (0x7FF)
>
> /* Step Configuration */
> #define STEPCONFIG_MODE_MASK (3 << 0)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web