Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1402097 > unrolled thread
| Started by | Purna Chandra Mandal <purna.mandal@microchip.com> |
|---|---|
| First post | 2016-05-17 07:10 +0200 |
| Last post | 2016-05-17 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:10 +0200
Re: [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts. Marc Zyngier <marc.zyngier@arm.com> - 2016-05-17 10:10 +0200
| From | Purna Chandra Mandal <purna.mandal@microchip.com> |
|---|---|
| Date | 2016-05-17 07:10 +0200 |
| Subject | [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts. |
| Message-ID | <rzFqx-fn-7@gated-at.bofh.it> |
From: Joshua Henderson <digitalpeer@digitalpeer.com>
The wrong external interrupt bits are being set, offset by 1.
Signed-off-by: Joshua Henderson <digitalpeer@digitalpeer.com>
Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---
drivers/irqchip/irq-pic32-evic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-pic32-evic.c b/drivers/irqchip/irq-pic32-evic.c
index e7155db..73addb4 100644
--- a/drivers/irqchip/irq-pic32-evic.c
+++ b/drivers/irqchip/irq-pic32-evic.c
@@ -91,7 +91,7 @@ static int pic32_set_type_edge(struct irq_data *data,
/* set polarity for external interrupts only */
for (i = 0; i < ARRAY_SIZE(priv->ext_irqs); i++) {
if (priv->ext_irqs[i] == data->hwirq) {
- ret = pic32_set_ext_polarity(i + 1, flow_type);
+ ret = pic32_set_ext_polarity(i, flow_type);
if (ret)
return ret;
}
--
1.8.3.1
[toc] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2016-05-17 10:10 +0200 |
| Subject | Re: [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts. |
| Message-ID | <rzIeK-21W-27@gated-at.bofh.it> |
| In reply to | #1402097 |
On 17/05/16 06:05, Purna Chandra Mandal wrote: > From: Joshua Henderson <digitalpeer@digitalpeer.com> > > The wrong external interrupt bits are being set, offset by 1. > > Signed-off-by: Joshua Henderson <digitalpeer@digitalpeer.com> > Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com> Acked-by: Marc Zyngier <marc.zyngier@arm.com> I'll queue that for post -rc1. Thanks, M. -- Jazz is not dead. It just smells funny...
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web