Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1400898 > unrolled thread

Re: [PATCH] i40e: constify i40e_client_ops structure

Started byDoug Ledford <dledford@redhat.com>
First post2016-05-13 19:00 +0200
Last post2016-05-13 22:50 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] i40e: constify i40e_client_ops structure Doug Ledford <dledford@redhat.com> - 2016-05-13 19:00 +0200
    Re: [PATCH] i40e: constify i40e_client_ops structure Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-05-13 21:50 +0200
      Re: [PATCH] i40e: constify i40e_client_ops structure Julia Lawall <julia.lawall@lip6.fr> - 2016-05-13 21:50 +0200
      Re: [PATCH] i40e: constify i40e_client_ops structure Doug Ledford <dledford@redhat.com> - 2016-05-13 22:50 +0200

#1400898 — Re: [PATCH] i40e: constify i40e_client_ops structure

FromDoug Ledford <dledford@redhat.com>
Date2016-05-13 19:00 +0200
SubjectRe: [PATCH] i40e: constify i40e_client_ops structure
Message-ID<ryoBr-7qC-3@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On 05/01/2016 08:07 AM, Julia Lawall wrote:
> The i40e_client_ops structure is never modified, so declare it as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied.


-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD


[toc] | [next] | [standalone]


#1400953

FromJeff Kirsher <jeffrey.t.kirsher@intel.com>
Date2016-05-13 21:50 +0200
Message-ID<ryrfX-1yb-1@gated-at.bofh.it>
In reply to#1400898

[Multipart message — attachments visible in raw view] — view raw

On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote:
> On 05/01/2016 08:07 AM, Julia Lawall wrote:
> > The i40e_client_ops structure is never modified, so declare it as
> const.
> > 
> > Done with the help of Coccinelle.
> > 
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Thanks, applied.

I already have this patch queued up to push through David Miller's net-next 
tree.

Julia- please do not shotgun blast several maintainers and several lists,
it causes confusion on who is *REALLY* going to accept and apply the patch.
Please use scripts/get_maintainer.pl to get the correct mailing lists and
maintainers to add to the To: and CC: lines.

[toc] | [prev] | [next] | [standalone]


#1400957

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-05-13 21:50 +0200
Message-ID<ryrfY-1yb-35@gated-at.bofh.it>
In reply to#1400953

[Multipart message — attachments visible in raw view] — view raw

On Fri, 13 May 2016, Jeff Kirsher wrote:

> On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote:
> > On 05/01/2016 08:07 AM, Julia Lawall wrote:
> > > The i40e_client_ops structure is never modified, so declare it as
> > const.
> > > 
> > > Done with the help of Coccinelle.
> > > 
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> > 
> > Thanks, applied.
> 
> I already have this patch queued up to push through David Miller's net-next 
> tree.
> 
> Julia- please do not shotgun blast several maintainers and several lists,
> it causes confusion on who is *REALLY* going to accept and apply the patch.
> Please use scripts/get_maintainer.pl to get the correct mailing lists and
> maintainers to add to the To: and CC: lines.

I do.  Probably the patch affects files maintained by different people.  
My assumption would be that everyone responsible for the code that is 
affected by the patch would want to see it.  Perhaps there would have been 
a way to separate it, but the const annotations typically have to be 
consistent everywhere.

julia

[toc] | [prev] | [next] | [standalone]


#1400969

FromDoug Ledford <dledford@redhat.com>
Date2016-05-13 22:50 +0200
Message-ID<rysc3-2oB-9@gated-at.bofh.it>
In reply to#1400953

[Multipart message — attachments visible in raw view] — view raw

On 05/13/2016 03:40 PM, Jeff Kirsher wrote:
> On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote:
>> On 05/01/2016 08:07 AM, Julia Lawall wrote:
>>> The i40e_client_ops structure is never modified, so declare it as
>> const.
>>>  
>>> Done with the help of Coccinelle.
>>>  
>>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>>
>> Thanks, applied.
> 
> I already have this patch queued up to push through David Miller's net-next 
> tree.
> 
> Julia- please do not shotgun blast several maintainers and several lists,
> it causes confusion on who is *REALLY* going to accept and apply the patch.
> Please use scripts/get_maintainer.pl to get the correct mailing lists and
> maintainers to add to the To: and CC: lines.
> 

I've dropped it from my tree.  There won't be a conflict.

-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD


[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web