Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400884 > unrolled thread

[PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-05-13 18:10 +0200
    Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the  Surface 3 Bastien Nocera <hadess@hadess.net> - 2016-05-17 20:00 +0200
      Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the  Surface 3 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-05-20 10:00 +0200
        Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the  Surface 3 Bastien Nocera <hadess@hadess.net> - 2016-05-20 12:00 +0200

#1400884 — [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3

Hi,

This is the v2 of the series with 3 extra patches to add support of the buttons
found on the Surface 3.

Cheers,
Benjamin


Benjamin Tissoires (6):
  Input - soc_button_array: use gpio_is_valid()
  Input - soc_button_array: bail out earlier if gpiod_count is null
  Input - soc_button_array: make sure one GPIO is not assigned twice
  Input - soc_button_array: allow to specify active_low
  Input - soc_button_array: export part of the internals
  Input - surface3_button_array: Introduce button support for the
    Surface 3

 drivers/input/misc/Kconfig                 |   9 ++
 drivers/input/misc/Makefile                |   1 +
 drivers/input/misc/soc_button_array.c      | 128 ++++++++++++++++++-----------
 drivers/input/misc/surface3_button_array.c | 115 ++++++++++++++++++++++++++
 include/linux/input/soc_button_array.h     |  37 +++++++++
 5 files changed, 240 insertions(+), 50 deletions(-)
 create mode 100644 drivers/input/misc/surface3_button_array.c
 create mode 100644 include/linux/input/soc_button_array.h

-- 
2.5.0

[toc] | [next] | [standalone]

#1402505 — Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3

On Fri, 2016-05-13 at 18:05 +0200, Benjamin Tissoires wrote:
> Hi,
> 
> This is the v2 of the series with 3 extra patches to add support of
> the buttons
> found on the Surface 3.
> 
> Cheers,
> Benjamin
> 
> 
> Benjamin Tissoires (6):
>   Input - soc_button_array: use gpio_is_valid()
>   Input - soc_button_array: bail out earlier if gpiod_count is null
>   Input - soc_button_array: make sure one GPIO is not assigned twice
>   Input - soc_button_array: allow to specify active_low
>   Input - soc_button_array: export part of the internals
>   Input - surface3_button_array: Introduce button support for the
>     Surface 3

Works on my Surface 3, the volume buttons, and the Windows button work
as expected. Note that the power button does not send out any events on
my machine, but that might be due to firmware differences.

My BIOS is listed as version 1.51116.78 released 03/09/2015.

As there's no errors generated, it would be fine to look at it as a bug
fix later on (or for me to updated my system).

Tested-by: Bastien Nocera <hadess@hadess.net>

[toc] | [prev] | [next] | [standalone]

#1404211 — Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3

On May 17 2016 or thereabouts, Bastien Nocera wrote:
> On Fri, 2016-05-13 at 18:05 +0200, Benjamin Tissoires wrote:
> > Hi,
> > 
> > This is the v2 of the series with 3 extra patches to add support of
> > the buttons
> > found on the Surface 3.
> > 
> > Cheers,
> > Benjamin
> > 
> > 
> > Benjamin Tissoires (6):
> >   Input - soc_button_array: use gpio_is_valid()
> >   Input - soc_button_array: bail out earlier if gpiod_count is null
> >   Input - soc_button_array: make sure one GPIO is not assigned twice
> >   Input - soc_button_array: allow to specify active_low
> >   Input - soc_button_array: export part of the internals
> >   Input - surface3_button_array: Introduce button support for the
> >     Surface 3
> 
> Works on my Surface 3, the volume buttons, and the Windows button work
> as expected. Note that the power button does not send out any events on
> my machine, but that might be due to firmware differences.
> 
> My BIOS is listed as version 1.51116.78 released 03/09/2015.
> 
> As there's no errors generated, it would be fine to look at it as a bug
> fix later on (or for me to updated my system).
> 
> Tested-by: Bastien Nocera <hadess@hadess.net>

Bastien told me in a different thread that the power button is not
working only after a reboot from Windows. After a cold start, it works
fine. There might be something that needs to be set at the I2C level,
but I think while we don't know much about the I2C protocol there, it
should be safe to still get this upstream.

Cheers,
Benjamin

[toc] | [prev] | [next] | [standalone]

#1404292 — Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3

On Fri, 2016-05-20 at 09:53 +0200, Benjamin Tissoires wrote:
> 
<snip>
> Bastien told me in a different thread that the power button is not
> working only after a reboot from Windows. After a cold start, it
> works
> fine.

Not quite. It worked after a hot reboot from Windows another time.

>  There might be something that needs to be set at the I2C level,
> but I think while we don't know much about the I2C protocol there, it
> should be safe to still get this upstream.

I don't know what the problem could be, but it seems safe enough for
now.

Cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web