Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400856 > unrolled thread

Re: [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory names

Back to article view | Back to linux.kernel

Contents

  Re: [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory names Xose Vazquez Perez <xose.vazquez@gmail.com> - 2016-05-13 17:20 +0200
    Re: [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory  names Joe Perches <joe@perches.com> - 2016-05-13 17:30 +0200
      Re: [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory names Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-13 17:40 +0200
      Re: [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory names Xose Vazquez Perez <xose.vazquez@gmail.com> - 2016-05-13 18:20 +0200

#1400856 — Re: [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory names

Matt Fleming wrote:

> Mark reported that having asterisks on the end of directory names
> confuses get_maintainer.pl when it encounters subdirectories, and that

If this's a get_maintainer.pl bug, it should also happen in:

F:      arch/arm64/boot/dts/qcom/*
F:      arch/mips/bcm47xx/*
F:      arch/mips/bmips/*
F:      arch/mips/include/asm/mach-bcm47xx/*
F:      arch/mips/include/asm/mach-bmips/*
F:      arch/x86/kernel/cpu/mcheck/*
F:      arch/x86/kernel/cpu/microcode/*
F:      arch/x86/net/*
F:      Documentation/devicetree/bindings/arc/*
F:      Documentation/misc-devices/mei/*
F:      Documentation/ptp/*
F:      drivers/block/xen-blkback/*
F:      drivers/char/*
F:      drivers/cpuidle/*
F:      drivers/firmware/broadcom/*
F:      drivers/hwtracing/coresight/*
F:      drivers/media/i2c/s5c73m3/*
F:      drivers/media/pci/netup_unidvb/*
F:      drivers/media/platform/vivid/*
F:      drivers/media/usb/pwc/*
F:      drivers/misc/*
F:      drivers/misc/mei/*
F:      drivers/mtd/nand/gpmi-nand/*
F:      drivers/net/ethernet/pasemi/*
F:      drivers/net/ethernet/tehuti/*
F:      drivers/net/wireless/ath/*
F:      drivers/net/xen-netback/*
F:      drivers/nvdimm/*
F:      drivers/ptp/*
F:      drivers/soc/samsung/*
F:      drivers/soc/ti/*
F:      fs/*
F:      kernel/events/*
F:      net/wireless/*
F:      sound/soc/blackfin/*
F:      sound/soc/samsung/*
F:      tools/testing/selftests/seccomp/*

> my name does not appear when run on drivers/firmware/efi/libstub.
> Reported-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
> ---
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42e65d128d01..4dca3b3895ba 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4223,8 +4223,8 @@ F:	Documentation/efi-stub.txt
>  F:	arch/ia64/kernel/efi.c
>  F:	arch/x86/boot/compressed/eboot.[ch]
>  F:	arch/x86/include/asm/efi.h
> -F:	arch/x86/platform/efi/*
> -F:	drivers/firmware/efi/*
> +F:	arch/x86/platform/efi/
> +F:	drivers/firmware/efi/
>  F:	include/linux/efi*.h
>  
>  EFI VARIABLE FILESYSTEM
> -- 
> 2.7.3

[toc] | [next] | [standalone]

#1400863 — Re: [PATCH 1/3] MAINTAINERS: Remove asterisk from EFI directory names

On Fri, 2016-05-13 at 17:11 +0200, Xose Vazquez Perez wrote:
> Matt Fleming wrote:
> 
> > 
> > Mark reported that having asterisks on the end of directory names
> > confuses get_maintainer.pl when it encounters subdirectories, and
> > that
> If this's a get_maintainer.pl bug, it should also happen in:

Mark is confused.

The meaning of * is all the files in a particular
directory but not any subdirectories.

[toc] | [prev] | [next] | [standalone]

#1400867

On Fri, 13 May, at 08:23:47AM, Joe Perches wrote:
> On Fri, 2016-05-13 at 17:11 +0200, Xose Vazquez Perez wrote:
> > Matt Fleming wrote:
> > 
> > > 
> > > Mark reported that having asterisks on the end of directory names
> > > confuses get_maintainer.pl when it encounters subdirectories, and
> > > that
> > If this's a get_maintainer.pl bug, it should also happen in:
> 
> Mark is confused.
 
Sorry, "confuses" was my word, not Mark's.

> The meaning of * is all the files in a particular
> directory but not any subdirectories.
 
Exactly. This is not what EFI maintainer entries should be using. I am
responsible for everything under drivers/firmware/efi, including
subdirectories.

[toc] | [prev] | [next] | [standalone]

#1400888

On 05/13/2016 05:23 PM, Joe Perches wrote:

> The meaning of * is all the files in a particular
> directory but not any subdirectories.

Then "*" is only relevant for these entries:
drivers/char/*
drivers/misc/*
drivers/net/wireless/ath/*
fs/*

drivers/cpuidle/* <---- This is a bug, it should be drivers/cpuidle

All the others only have files inside, and "*"
is redundant.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web