Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400377 > unrolled thread

[PATCH] irqchip: nps: add 64BIT dependency

Started byArnd Bergmann <arnd@arndb.de>
First post2016-05-12 23:10 +0200
Last post2016-05-20 10:30 +0200
Articles 11 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] irqchip: nps: add 64BIT dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-12 23:10 +0200
    Re: [PATCH] irqchip: nps: add 64BIT dependency Marc Zyngier <marc.zyngier@arm.com> - 2016-05-13 10:30 +0200
      Re: [PATCH] irqchip: nps: add 64BIT dependency Marc Zyngier <marc.zyngier@arm.com> - 2016-05-13 10:40 +0200
      Re: [PATCH] irqchip: nps: add 64BIT dependency Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-05-13 10:40 +0200
        Re: [PATCH] irqchip: nps: add 64BIT dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-13 12:00 +0200
          Re: [PATCH] irqchip: nps: add 64BIT dependency Marc Zyngier <marc.zyngier@arm.com> - 2016-05-13 12:30 +0200
            Re: [PATCH] irqchip: nps: add 64BIT dependency Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-05-13 12:40 +0200
              Re: [PATCH] irqchip: nps: add 64BIT dependency Thomas Gleixner <tglx@linutronix.de> - 2016-05-17 21:50 +0200
    Re: [PATCH] irqchip: nps: add 64BIT dependency Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-20 09:40 +0200
      Re: [PATCH] irqchip: nps: add 64BIT dependency Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-20 10:30 +0200
      Re: [PATCH] irqchip: nps: add 64BIT dependency Vineet Gupta <vgupta@synopsys.com> - 2016-05-20 10:30 +0200

#1400377 — [PATCH] irqchip: nps: add 64BIT dependency

FromArnd Bergmann <arnd@arndb.de>
Date2016-05-12 23:10 +0200
Subject[PATCH] irqchip: nps: add 64BIT dependency
Message-ID<ry61Q-5yq-17@gated-at.bofh.it>
The newly added nps irqchip driver causes build warnings on ARM64.

include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

As the driver is only used on ARC, we don't need to see it without
COMPILE_TEST elsewhere, and we can avoid the warnings by only
building on 32-bit architectures even with CONFIG_COMPILE_TEST.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/irqchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 83775f148158..37289cf6b449 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -253,6 +253,7 @@ config MVEBU_ODMI
 
 config EZNPS_GIC
 	bool "NPS400 Global Interrupt Manager (GIM)"
+	depends on ARC || (COMPILE_TEST && !64BIT)
 	select IRQ_DOMAIN
 	help
 	  Support the EZchip NPS400 global interrupt controller
-- 
2.7.0

[toc] | [next] | [standalone]

#1400607

FromMarc Zyngier <marc.zyngier@arm.com>
Date2016-05-13 10:30 +0200
Message-ID<rygDU-89l-3@gated-at.bofh.it>
In reply to#1400377
On 12/05/16 22:03, Arnd Bergmann wrote:
> The newly added nps irqchip driver causes build warnings on ARM64.
> 
> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 
> As the driver is only used on ARC, we don't need to see it without
> COMPILE_TEST elsewhere, and we can avoid the warnings by only
> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/irqchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 83775f148158..37289cf6b449 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>  
>  config EZNPS_GIC
>  	bool "NPS400 Global Interrupt Manager (GIM)"
> +	depends on ARC || (COMPILE_TEST && !64BIT)
>  	select IRQ_DOMAIN
>  	help
>  	  Support the EZchip NPS400 global interrupt controller
> 

Acked-by: Marc Zyngier <narc.zyngier@arm.com>

As I've already started collecting fixes that are aimed at -rc1 (mostly
to avoid dependencies), I can queue that as well.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

[toc] | [prev] | [next] | [standalone]

#1400616

FromMarc Zyngier <marc.zyngier@arm.com>
Date2016-05-13 10:40 +0200
Message-ID<rygNA-8e3-17@gated-at.bofh.it>
In reply to#1400607
On 13/05/16 09:35, Vineet Gupta wrote:
> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>> On 12/05/16 22:03, Arnd Bergmann wrote:
> ...
>>>  
>>>  config EZNPS_GIC
>>>  	bool "NPS400 Global Interrupt Manager (GIM)"
>>> +	depends on ARC || (COMPILE_TEST && !64BIT)
>>>  	select IRQ_DOMAIN
>>>  	help
>>>  	  Support the EZchip NPS400 global interrupt controller
>>>
>>
>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
>>
>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>> to avoid dependencies), I can queue that as well.
> 
> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> towards the end of rc1 ?

That'd be post -rc1.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

[toc] | [prev] | [next] | [standalone]

#1400617

FromVineet Gupta <Vineet.Gupta1@synopsys.com>
Date2016-05-13 10:40 +0200
Message-ID<rygNA-8e3-7@gated-at.bofh.it>
In reply to#1400607
On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> On 12/05/16 22:03, Arnd Bergmann wrote:
...
>>  
>>  config EZNPS_GIC
>>  	bool "NPS400 Global Interrupt Manager (GIM)"
>> +	depends on ARC || (COMPILE_TEST && !64BIT)
>>  	select IRQ_DOMAIN
>>  	help
>>  	  Support the EZchip NPS400 global interrupt controller
>>
> 
> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
> 
> As I've already started collecting fixes that are aimed at -rc1 (mostly
> to avoid dependencies), I can queue that as well.

There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
towards the end of rc1 ?

Thx,
-Vineet

[toc] | [prev] | [next] | [standalone]

#1400661

FromArnd Bergmann <arnd@arndb.de>
Date2016-05-13 12:00 +0200
Message-ID<ryi31-PV-17@gated-at.bofh.it>
In reply to#1400617
On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> > On 12/05/16 22:03, Arnd Bergmann wrote:
> ...
> >>  
> >>  config EZNPS_GIC
> >>      bool "NPS400 Global Interrupt Manager (GIM)"
> >> +    depends on ARC || (COMPILE_TEST && !64BIT)
> >>      select IRQ_DOMAIN
> >>      help
> >>        Support the EZchip NPS400 global interrupt controller
> >>
> > 
> > Acked-by: Marc Zyngier <narc.zyngier@arm.com>
> > 
> > As I've already started collecting fixes that are aimed at -rc1 (mostly
> > to avoid dependencies), I can queue that as well.
> 
> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> towards the end of rc1 ?
> 

I'd say the best option is to have you pick up the fix for the ARC tree,
but either way works.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1400684

FromMarc Zyngier <marc.zyngier@arm.com>
Date2016-05-13 12:30 +0200
Message-ID<ryiw2-1pE-11@gated-at.bofh.it>
In reply to#1400661
On 13/05/16 10:51, Arnd Bergmann wrote:
> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>>> On 12/05/16 22:03, Arnd Bergmann wrote:
>> ...
>>>>  
>>>>  config EZNPS_GIC
>>>>      bool "NPS400 Global Interrupt Manager (GIM)"
>>>> +    depends on ARC || (COMPILE_TEST && !64BIT)
>>>>      select IRQ_DOMAIN
>>>>      help
>>>>        Support the EZchip NPS400 global interrupt controller
>>>>
>>>
>>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
>>>
>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>>> to avoid dependencies), I can queue that as well.
>>
>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
>> towards the end of rc1 ?
>>
> 
> I'd say the best option is to have you pick up the fix for the ARC tree,
> but either way works.

That'd work for me too (I've acked it anyway). Just let me know what you
decide to do.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

[toc] | [prev] | [next] | [standalone]

#1400690

FromVineet Gupta <Vineet.Gupta1@synopsys.com>
Date2016-05-13 12:40 +0200
Message-ID<ryiFI-1tX-5@gated-at.bofh.it>
In reply to#1400684
On Friday 13 May 2016 03:55 PM, Marc Zyngier wrote:
> On 13/05/16 10:51, Arnd Bergmann wrote:
>> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
>>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
>>>> On 12/05/16 22:03, Arnd Bergmann wrote:
>>> ...
>>>>>  
>>>>>  config EZNPS_GIC
>>>>>      bool "NPS400 Global Interrupt Manager (GIM)"
>>>>> +    depends on ARC || (COMPILE_TEST && !64BIT)
>>>>>      select IRQ_DOMAIN
>>>>>      help
>>>>>        Support the EZchip NPS400 global interrupt controller
>>>>>
>>>>
>>>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
>>>>
>>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
>>>> to avoid dependencies), I can queue that as well.
>>>
>>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
>>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
>>> towards the end of rc1 ?
>>>
>>
>> I'd say the best option is to have you pick up the fix for the ARC tree,
>> but either way works.
> 
> That'd work for me too (I've acked it anyway). Just let me know what you
> decide to do.

I'd prefer Marc takes it post rc1. The reason being chances of merge conflicts
between ARC and tip trees increase with ARC tree changing drivers/irqchip/*. We've
seen two of those already which Stephen fixed up in linux-next. Although
admittedly the conflicts are trivial and given the location of this diff hunk it
might not happen at all....

-Vineet

[toc] | [prev] | [next] | [standalone]

#1402557

FromThomas Gleixner <tglx@linutronix.de>
Date2016-05-17 21:50 +0200
Message-ID<rzTaa-mb-25@gated-at.bofh.it>
In reply to#1400690
On Fri, 13 May 2016, Vineet Gupta wrote:
> On Friday 13 May 2016 03:55 PM, Marc Zyngier wrote:
> > On 13/05/16 10:51, Arnd Bergmann wrote:
> >> On Friday 13 May 2016 14:05:41 Vineet Gupta wrote:
> >>> On Friday 13 May 2016 01:54 PM, Marc Zyngier wrote:
> >>>> On 12/05/16 22:03, Arnd Bergmann wrote:
> >>> ...
> >>>>>  
> >>>>>  config EZNPS_GIC
> >>>>>      bool "NPS400 Global Interrupt Manager (GIM)"
> >>>>> +    depends on ARC || (COMPILE_TEST && !64BIT)
> >>>>>      select IRQ_DOMAIN
> >>>>>      help
> >>>>>        Support the EZchip NPS400 global interrupt controller
> >>>>>
> >>>>
> >>>> Acked-by: Marc Zyngier <narc.zyngier@arm.com>
> >>>>
> >>>> As I've already started collecting fixes that are aimed at -rc1 (mostly
> >>>> to avoid dependencies), I can queue that as well.
> >>>
> >>> There is a slight logistics issue here - as agreed the driver will go in 4.7-rc1
> >>> via ARC tree. So either I pick the fix for rc1 or you apply it post rc1 - or
> >>> towards the end of rc1 ?
> >>>
> >>
> >> I'd say the best option is to have you pick up the fix for the ARC tree,
> >> but either way works.
> > 
> > That'd work for me too (I've acked it anyway). Just let me know what you
> > decide to do.
> 
> I'd prefer Marc takes it post rc1. The reason being chances of merge conflicts
> between ARC and tip trees increase with ARC tree changing drivers/irqchip/*. We've
> seen two of those already which Stephen fixed up in linux-next. Although
> admittedly the conflicts are trivial and given the location of this diff hunk it
> might not happen at all....

If the driver is new and in ARC then the fix should go into ARC and shipped
with the pull request.

Thanks,

	tglx

[toc] | [prev] | [next] | [standalone]

#1404196

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-05-20 09:40 +0200
Message-ID<rANcm-2D2-15@gated-at.bofh.it>
In reply to#1400377
Hi Arnd,

On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added nps irqchip driver causes build warnings on ARM64.
>
> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> As the driver is only used on ARC, we don't need to see it without
> COMPILE_TEST elsewhere, and we can avoid the warnings by only
> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/irqchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 83775f148158..37289cf6b449 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>
>  config EZNPS_GIC
>         bool "NPS400 Global Interrupt Manager (GIM)"
> +       depends on ARC || (COMPILE_TEST && !64BIT)
>         select IRQ_DOMAIN
>         help
>           Support the EZchip NPS400 global interrupt controller

As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
the slight simpler (whitespace-damaged):

--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -255,7 +255,8 @@ config PARTITION_PERCPU
        bool

 config EZNPS_GIC
-       bool "NPS400 Global Interrupt Manager (GIM)"
+       bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST
+       depends on !64BIT
        select IRQ_DOMAIN
        help
          Support the EZchip NPS400 global interrupt controller

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1404234

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-05-20 10:30 +0200
Message-ID<rANYK-38Z-19@gated-at.bofh.it>
In reply to#1404196
Hi Vineet,

On Fri, May 20, 2016 at 10:22 AM, Vineet Gupta <vgupta@synopsys.com> wrote:
> On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
>> On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> The newly added nps irqchip driver causes build warnings on ARM64.
>>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>>
>>> As the driver is only used on ARC, we don't need to see it without
>>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>>  drivers/irqchip/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>>> index 83775f148158..37289cf6b449 100644
>>> --- a/drivers/irqchip/Kconfig
>>> +++ b/drivers/irqchip/Kconfig
>>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>>
>>>  config EZNPS_GIC
>>>         bool "NPS400 Global Interrupt Manager (GIM)"
>>> +       depends on ARC || (COMPILE_TEST && !64BIT)
>>>         select IRQ_DOMAIN
>>>         help
>>>           Support the EZchip NPS400 global interrupt controller
>>
>> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
>> the slight simpler (whitespace-damaged):
>
> I'm afraid you are late to party - this has been sent Linus' way earlier today !

I am (my compilers are) celebrating Linus' current tree...

> But it does look prettier so we can do this after rc1

OK.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1404236

FromVineet Gupta <vgupta@synopsys.com>
Date2016-05-20 10:30 +0200
Message-ID<rANYJ-38Z-15@gated-at.bofh.it>
In reply to#1404196
On Friday 20 May 2016 01:04 PM, Geert Uytterhoeven wrote:
> Hi Arnd,
> 
> On Thu, May 12, 2016 at 11:03 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The newly added nps irqchip driver causes build warnings on ARM64.
>>
>> include/soc/nps/common.h: In function 'nps_host_reg_non_cl':
>> include/soc/nps/common.h:148:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>
>> As the driver is only used on ARC, we don't need to see it without
>> COMPILE_TEST elsewhere, and we can avoid the warnings by only
>> building on 32-bit architectures even with CONFIG_COMPILE_TEST.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/irqchip/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 83775f148158..37289cf6b449 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -253,6 +253,7 @@ config MVEBU_ODMI
>>
>>  config EZNPS_GIC
>>         bool "NPS400 Global Interrupt Manager (GIM)"
>> +       depends on ARC || (COMPILE_TEST && !64BIT)
>>         select IRQ_DOMAIN
>>         help
>>           Support the EZchip NPS400 global interrupt controller
> 
> As ARC_PLAT_EZNPS already selects EZNPS_GIC, I'd like to suggest
> the slight simpler (whitespace-damaged):

I'm afraid you are late to party - this has been sent Linus' way earlier today !
But it does look prettier so we can do this after rc1

> 
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -255,7 +255,8 @@ config PARTITION_PERCPU
>         bool
> 
>  config EZNPS_GIC
> -       bool "NPS400 Global Interrupt Manager (GIM)"
> +       bool "NPS400 Global Interrupt Manager (GIM)" if COMPILE_TEST
> +       depends on !64BIT
>         select IRQ_DOMAIN
>         help
>           Support the EZchip NPS400 global interrupt controller
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web