Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1400641 > unrolled thread

[PATCH] i2c: at91: change log when dma configuration fails

Started byLudovic Desroches <ludovic.desroches@atmel.com>
First post2016-05-13 11:30 +0200
Last post2016-05-13 11:30 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] i2c: at91: change log when dma configuration fails Ludovic Desroches <ludovic.desroches@atmel.com> - 2016-05-13 11:30 +0200

#1400641 — [PATCH] i2c: at91: change log when dma configuration fails

FromLudovic Desroches <ludovic.desroches@atmel.com>
Date2016-05-13 11:30 +0200
Subject[PATCH] i2c: at91: change log when dma configuration fails
Message-ID<ryhzY-Bj-27@gated-at.bofh.it>
When the DMA configuration fails, there is a log reporting that we can't
use DMA and indicating the error number. When booting the kernel, it is
annoying to see this error number. Moreover, people can think something
is going wrong. It is not the case, it means that DMA can't be used but
it doesn't prevent to use i2c.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/i2c/busses/i2c-at91.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 921d32b..f2a7457 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -1013,7 +1013,9 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
 
 error:
 	if (ret != -EPROBE_DEFER)
-		dev_info(dev->dev, "can't use DMA, error %d\n", ret);
+		dev_info(dev->dev,
+			 "can't request DMA channels, continue without DMA support\n",
+			 ret);
 	if (dma->chan_rx)
 		dma_release_channel(dma->chan_rx);
 	if (dma->chan_tx)
-- 
2.5.0

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web