Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1400556 > unrolled thread

Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile

Started byMaxime Ripard <maxime.ripard@free-electrons.com>
First post2016-05-13 09:50 +0200
Last post2016-05-13 10:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the  Makefile Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-13 09:50 +0200
    Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the  Makefile Olliver Schinagl <oliver@schinagl.nl> - 2016-05-13 10:10 +0200

#1400556 — Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2016-05-13 09:50 +0200
SubjectRe: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile
Message-ID<ryg1c-7nz-13@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hi Olliver,

On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote:
> commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new
> emmc equipped) lime2 but forgot its Makefile.

This is still not the right commit format, the commit title should be
around double quotes. checkpatch both reports an error for this and
tells you what the proper format is, so please remember to use it
before you're sending a patch.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [next] | [standalone]


#1400586

FromOlliver Schinagl <oliver@schinagl.nl>
Date2016-05-13 10:10 +0200
Message-ID<rygky-7Xv-13@gated-at.bofh.it>
In reply to#1400556
and now i'm embarrassed and ashamed. Teaches me not to rush things, 
right? i'll correct it and take some time to do it right. sorry maxime!

On 13-05-16 09:48, Maxime Ripard wrote:
> Hi Olliver,
>
> On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote:
>> commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new
>> emmc equipped) lime2 but forgot its Makefile.
> This is still not the right commit format, the commit title should be
> around double quotes. checkpatch both reports an error for this and
> tells you what the proper format is, so please remember to use it
> before you're sending a patch.
>
> Thanks!
> Maxime
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web