Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1400528 > unrolled thread

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

Started byIvaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
First post2016-05-13 08:20 +0200
Last post2016-05-13 16:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> - 2016-05-13 08:20 +0200
    Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver Sebastian Reichel <sre@kernel.org> - 2016-05-13 16:10 +0200

#1400528 — Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

FromIvaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Date2016-05-13 08:20 +0200
SubjectRe: [PATCH 4/7] [media] ir-rx51: add DT support to driver
Message-ID<ryeC5-5YC-7@gated-at.bofh.it>
Hi,

On 11.05.2016 17:14, Rob Herring wrote:
> On Tue, May 10, 2016 at 04:18:27AM +0200, Sebastian Reichel wrote:
>> Hi,
>>
>> On Mon, May 09, 2016 at 04:07:35PM -0500, Rob Herring wrote:
>>> There's already a pwm-led binding that can be used. Though there
>>> may be missing consumer IR to LED subsystem support in the kernel.
>>> You could list both compatibles, use the rx51 IR driver now, and
>>> then move to pwm-led driver in the future.
>>
>> Well from a purely HW point of view it's a PWM connected led. The
>> usage is completely different though. Usually PWM is used to control
>> the LED's brightness via the duty cycle (basic concept: enabling led
>> only 50% of time reduces brightness to 50%).
>>
>> In the IR led's case the aim is generating a specific serial pattern
>> instead. For this task it uses a dmtimer in PWM mode and a second
>> one to reconfigure the pwm timer.
>
> In that case, it will probably never be a generic driver.
>
>> I don't know about a good name, but rx51 should be replaced with
>> n900 in the compatible string. So maybe "nokia,n900-infrared-diode".
>
> That's fine, but the shorter '-ir' was too.
>

I prefer the shorter "nokia,n900-ir", will resend the series with it 
used, unless someone has concerns about it.

Ivo

[toc] | [next] | [standalone]


#1400813

FromSebastian Reichel <sre@kernel.org>
Date2016-05-13 16:10 +0200
Message-ID<rylWW-4R7-11@gated-at.bofh.it>
In reply to#1400528

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Fri, May 13, 2016 at 09:15:38AM +0300, Ivaylo Dimitrov wrote:
> I prefer the shorter "nokia,n900-ir", will resend the series with
> it used, unless someone has concerns about it.

Sounds fine to me.

-- Sebastian

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web