Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401121 > unrolled thread
| Started by | Jonathan McDowell <noodles@earth.li> |
|---|---|
| First post | 2016-05-14 19:30 +0200 |
| Last post | 2016-05-23 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Fix RC5 decoding with Fintek CIR chipset Jonathan McDowell <noodles@earth.li> - 2016-05-14 19:30 +0200
Re: [PATCH] Fix RC5 decoding with Fintek CIR chipset David Härdeman <david@hardeman.nu> - 2016-05-23 21:10 +0200
| From | Jonathan McDowell <noodles@earth.li> |
|---|---|
| Date | 2016-05-14 19:30 +0200 |
| Subject | [PATCH] Fix RC5 decoding with Fintek CIR chipset |
| Message-ID | <ryLy2-50o-11@gated-at.bofh.it> |
Fix RC5 decoding with Fintek CIR chipset
Commit e87b540be2dd02552fb9244d50ae8b4e4619a34b tightened up the RC5
decoding by adding a check for trailing silence to ensure a valid RC5
command had been received. Unfortunately the trailer length checked was
10 units and the Fintek CIR device does not want to provide details of a
space longer than 6350us. This meant that RC5 remotes working on a
Fintek setup on 3.16 failed on 3.17 and later. Fix this by shortening
the trailer check to 6 units (allowing for a previous space in the
received remote command).
Signed-off-by: Jonathan McDowell <noodles@earth.li>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117221
Cc: stable@vger.kernel.org
-----
diff --git a/drivers/media/rc/ir-rc5-decoder.c b/drivers/media/rc/ir-rc5-decoder.c
index 6ffe776..a0fd4e6 100644
--- a/drivers/media/rc/ir-rc5-decoder.c
+++ b/drivers/media/rc/ir-rc5-decoder.c
@@ -29,7 +29,7 @@
#define RC5_BIT_START (1 * RC5_UNIT)
#define RC5_BIT_END (1 * RC5_UNIT)
#define RC5X_SPACE (4 * RC5_UNIT)
-#define RC5_TRAILER (10 * RC5_UNIT) /* In reality, approx 100 */
+#define RC5_TRAILER (6 * RC5_UNIT) /* In reality, approx 100 */
enum rc5_state {
STATE_INACTIVE,
-----
J.
--
What did the first punk rock girl wear to your school?
[toc] | [next] | [standalone]
| From | David Härdeman <david@hardeman.nu> |
|---|---|
| Date | 2016-05-23 21:10 +0200 |
| Message-ID | <rC3oJ-1p0-1@gated-at.bofh.it> |
| In reply to | #1401121 |
On Sat, May 14, 2016 at 06:01:26PM +0100, Jonathan McDowell wrote:
>Fix RC5 decoding with Fintek CIR chipset
>
>Commit e87b540be2dd02552fb9244d50ae8b4e4619a34b tightened up the RC5
>decoding by adding a check for trailing silence to ensure a valid RC5
>command had been received. Unfortunately the trailer length checked was
>10 units and the Fintek CIR device does not want to provide details of a
>space longer than 6350us. This meant that RC5 remotes working on a
>Fintek setup on 3.16 failed on 3.17 and later. Fix this by shortening
>the trailer check to 6 units (allowing for a previous space in the
>received remote command).
>
>Signed-off-by: Jonathan McDowell <noodles@earth.li>
Signed-off-by: David Härdeman <david@hardeman.nu>
>Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117221
>Cc: stable@vger.kernel.org
>
>-----
>diff --git a/drivers/media/rc/ir-rc5-decoder.c b/drivers/media/rc/ir-rc5-decoder.c
>index 6ffe776..a0fd4e6 100644
>--- a/drivers/media/rc/ir-rc5-decoder.c
>+++ b/drivers/media/rc/ir-rc5-decoder.c
>@@ -29,7 +29,7 @@
> #define RC5_BIT_START (1 * RC5_UNIT)
> #define RC5_BIT_END (1 * RC5_UNIT)
> #define RC5X_SPACE (4 * RC5_UNIT)
>-#define RC5_TRAILER (10 * RC5_UNIT) /* In reality, approx 100 */
>+#define RC5_TRAILER (6 * RC5_UNIT) /* In reality, approx 100 */
>
> enum rc5_state {
> STATE_INACTIVE,
>-----
>
>J.
>
>--
>What did the first punk rock girl wear to your school?
>
--
David Härdeman
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web