Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1398279 > unrolled thread

[PATCH 0/3] drm/rockchip: fix some sparse warnings

Started byJohn Keeping <john@metanate.com>
First post2016-05-10 18:10 +0200
Last post2016-05-10 18:10 +0200
Articles 3 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/3] drm/rockchip: fix some sparse warnings John Keeping <john@metanate.com> - 2016-05-10 18:10 +0200
    [PATCH 2/3] drm/rockchip: fb: add missing header John Keeping <john@metanate.com> - 2016-05-10 18:10 +0200
    [PATCH 1/3] drm/rockchip: dw_hdmi: remove unused #include John Keeping <john@metanate.com> - 2016-05-10 18:10 +0200

#1398279 — [PATCH 0/3] drm/rockchip: fix some sparse warnings

FromJohn Keeping <john@metanate.com>
Date2016-05-10 18:10 +0200
Subject[PATCH 0/3] drm/rockchip: fix some sparse warnings
Message-ID<rxioq-5TU-23@gated-at.bofh.it>
The first patch wasn't found by sparse, but is something I noticed while
in the area.  The following two fix all of the sparse warnings inside
drm/rockchip.

John Keeping (3):
  drm/rockchip: dw_hdmi: remove unused #include
  drm/rockchip: fb: add missing header
  drm/rockchip: fix "should it be static?" warnings

 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 -
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ++--
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c  | 7 ++++---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
 drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.8.2.565.gdb84f68.dirty

[toc] | [next] | [standalone]


#1398288 — [PATCH 2/3] drm/rockchip: fb: add missing header

FromJohn Keeping <john@metanate.com>
Date2016-05-10 18:10 +0200
Subject[PATCH 2/3] drm/rockchip: fb: add missing header
Message-ID<rxios-5TU-67@gated-at.bofh.it>
In reply to#1398279
This fixes the following sparse warnings:

drivers/gpu/drm/rockchip/rockchip_drm_fb.c:32:23: warning: symbol 'rockchip_fb_get_gem_obj' was not declared. Should it be static?
drivers/gpu/drm/rockchip/rockchip_drm_fb.c:315:24: warning: symbol 'rockchip_drm_framebuffer_init' was not declared. Should it be static?
drivers/gpu/drm/rockchip/rockchip_drm_fb.c:329:6: warning: symbol 'rockchip_drm_mode_config_init' was not declared. Should it be static?

Signed-off-by: John Keeping <john@metanate.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index 8c10163a95bc..85aa87ee12f5 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
@@ -20,6 +20,7 @@
 #include <drm/drm_crtc_helper.h>
 
 #include "rockchip_drm_drv.h"
+#include "rockchip_drm_fb.h"
 #include "rockchip_drm_gem.h"
 
 #define to_rockchip_fb(x) container_of(x, struct rockchip_drm_fb, fb)
-- 
2.8.2.565.gdb84f68.dirty

[toc] | [prev] | [next] | [standalone]


#1398289 — [PATCH 1/3] drm/rockchip: dw_hdmi: remove unused #include

FromJohn Keeping <john@metanate.com>
Date2016-05-10 18:10 +0200
Subject[PATCH 1/3] drm/rockchip: dw_hdmi: remove unused #include
Message-ID<rxios-5TU-69@gated-at.bofh.it>
In reply to#1398279
drm_encoder_slave is not used in this file.

Signed-off-by: John Keeping <john@metanate.com>
---
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index 801110f65a63..0665fb915579 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -15,7 +15,6 @@
 #include <drm/drmP.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_edid.h>
-#include <drm/drm_encoder_slave.h>
 #include <drm/bridge/dw_hdmi.h>
 
 #include "rockchip_drm_drv.h"
-- 
2.8.2.565.gdb84f68.dirty

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web