Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1397601 > unrolled thread

[PATCH 2/3] blktrace: add missed mask name

Started byShaohua Li <shli@fb.com>
First post2016-05-10 02:30 +0200
Last post2016-05-10 17:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/3] blktrace: add missed mask name Shaohua Li <shli@fb.com> - 2016-05-10 02:30 +0200
    Re: [PATCH 2/3] blktrace: add missed mask name Jeff Moyer <jmoyer@redhat.com> - 2016-05-10 17:50 +0200

#1397601 — [PATCH 2/3] blktrace: add missed mask name

FromShaohua Li <shli@fb.com>
Date2016-05-10 02:30 +0200
Subject[PATCH 2/3] blktrace: add missed mask name
Message-ID<rx3IK-8cV-15@gated-at.bofh.it>
BLK_TC_NOTIFY is missed in mask_maps, so we can't print out notify or
set mask with 'notify' name.

Signed-off-by: Shaohua Li <shli@fb.com>
---
 kernel/trace/blktrace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 8ae9ea2..9aef865 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1552,6 +1552,7 @@ static const struct {
 	{ BLK_TC_COMPLETE,	"complete"	},
 	{ BLK_TC_FS,		"fs"		},
 	{ BLK_TC_PC,		"pc"		},
+	{ BLK_TC_NOTIFY,	"notify"	},
 	{ BLK_TC_AHEAD,		"ahead"		},
 	{ BLK_TC_META,		"meta"		},
 	{ BLK_TC_DISCARD,	"discard"	},
-- 
2.8.0.rc2

[toc] | [next] | [standalone]


#1398258

FromJeff Moyer <jmoyer@redhat.com>
Date2016-05-10 17:50 +0200
Message-ID<rxi54-5hY-7@gated-at.bofh.it>
In reply to#1397601
Shaohua Li <shli@fb.com> writes:

> BLK_TC_NOTIFY is missed in mask_maps, so we can't print out notify or
> set mask with 'notify' name.

For the text-based interface, yeah.

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

>
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
>  kernel/trace/blktrace.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 8ae9ea2..9aef865 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -1552,6 +1552,7 @@ static const struct {
>  	{ BLK_TC_COMPLETE,	"complete"	},
>  	{ BLK_TC_FS,		"fs"		},
>  	{ BLK_TC_PC,		"pc"		},
> +	{ BLK_TC_NOTIFY,	"notify"	},
>  	{ BLK_TC_AHEAD,		"ahead"		},
>  	{ BLK_TC_META,		"meta"		},
>  	{ BLK_TC_DISCARD,	"discard"	},

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web