Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1398044 > unrolled thread
| Started by | Tomi Valkeinen <tomi.valkeinen@ti.com> |
|---|---|
| First post | 2016-05-10 14:30 +0200 |
| Last post | 2016-05-10 14:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 18/23] drm: omapdrm: panel-dsi-cm: use threaded irq handler Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-05-10 14:30 +0200
| From | Tomi Valkeinen <tomi.valkeinen@ti.com> |
|---|---|
| Date | 2016-05-10 14:30 +0200 |
| Subject | Re: [PATCH 18/23] drm: omapdrm: panel-dsi-cm: use threaded irq handler |
| Message-ID | <rxeXw-2hn-5@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On 08/03/16 18:39, Sebastian Reichel wrote:
> Use threaded irq handler for the tearing effect gpio,
> since it updates the display content, which requires
> too much time for a fastpath irq.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> index 768e92d1ec8b..8316b6c2d8aa 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> @@ -1317,9 +1317,9 @@ static int dsicm_probe(struct platform_device *pdev)
> return r;
> }
>
> - r = devm_request_irq(dev, gpio_to_irq(ddata->ext_te_gpio),
> - dsicm_te_isr,
> - IRQF_TRIGGER_RISING,
> + r = devm_request_threaded_irq(dev, gpio_to_irq(ddata->ext_te_gpio),
> + NULL, dsicm_te_isr,
> + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> "taal vsync", ddata);
>
> if (r) {
>
I don't have a problem with moving to threaded irq, but it does make me
wonder, what's happening there that's taking so much time? I think it
should be just writing the configs to the registers and starting the
transfer.
Tomi
Back to top | Article view | linux.kernel
csiph-web