Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1397928 > unrolled thread
| Started by | Felipe Balbi <balbi@kernel.org> |
|---|---|
| First post | 2016-05-10 12:00 +0200 |
| Last post | 2016-05-10 12:10 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:00 +0200
Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:10 +0200
Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Roger Quadros <rogerq@ti.com> - 2016-05-10 12:20 +0200
Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:20 +0200
Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Roger Quadros <rogerq@ti.com> - 2016-05-10 12:10 +0200
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Date | 2016-05-10 12:00 +0200 |
| Subject | Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently |
| Message-ID | <rxcCo-8kL-59@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi, Roger Quadros <rogerq@ti.com> writes: > Don't make any decisions regarding VBUS session based on ID > status. That is best left to the OTG core. > > Pass ID and VBUS events independent of each other so that OTG > core knows exactly what to do. > > This makes dual-role with extcon work with OTG irq on OMAP platforms. > > Signed-off-by: Roger Quadros <rogerq@ti.com> I have a feeling this will regress OMAP5432 uEVM. Did you test with that board ? cheers -- balbi
[toc] | [next] | [standalone]
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Date | 2016-05-10 12:10 +0200 |
| Message-ID | <rxcM2-qT-13@gated-at.bofh.it> |
| In reply to | #1397928 |
[Multipart message — attachments visible in raw view] — view raw
Hi, Roger Quadros <rogerq@ti.com> writes: > On 10/05/16 12:55, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros <rogerq@ti.com> writes: >>> Don't make any decisions regarding VBUS session based on ID >>> status. That is best left to the OTG core. >>> >>> Pass ID and VBUS events independent of each other so that OTG >>> core knows exactly what to do. >>> >>> This makes dual-role with extcon work with OTG irq on OMAP platforms. >>> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> >> >> I have a feeling this will regress OMAP5432 uEVM. Did you test with that >> board ? >> > > Yes. Any specific test case you would like me to test? > For now I'm just doing enumeration with g_zero. IIRC OMAP5 uEVM didn't have separate VBUS and ID GPIOs. How are you handling that case ? -- balbi
[toc] | [prev] | [next] | [standalone]
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2016-05-10 12:20 +0200 |
| Subject | Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently |
| Message-ID | <rxcVH-yd-1@gated-at.bofh.it> |
| In reply to | #1397947 |
On 10/05/16 13:05, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rogerq@ti.com> writes: >> On 10/05/16 12:55, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros <rogerq@ti.com> writes: >>>> Don't make any decisions regarding VBUS session based on ID >>>> status. That is best left to the OTG core. >>>> >>>> Pass ID and VBUS events independent of each other so that OTG >>>> core knows exactly what to do. >>>> >>>> This makes dual-role with extcon work with OTG irq on OMAP platforms. >>>> >>>> Signed-off-by: Roger Quadros <rogerq@ti.com> >>> >>> I have a feeling this will regress OMAP5432 uEVM. Did you test with that >>> board ? >>> >> >> Yes. Any specific test case you would like me to test? >> For now I'm just doing enumeration with g_zero. > > IIRC OMAP5 uEVM didn't have separate VBUS and ID GPIOs. How are you > handling that case ? > It comes from the PMIC, extcon-palmas.c. cheers, -roger
[toc] | [prev] | [next] | [standalone]
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Date | 2016-05-10 12:20 +0200 |
| Message-ID | <rxcVI-yd-11@gated-at.bofh.it> |
| In reply to | #1397956 |
[Multipart message — attachments visible in raw view] — view raw
Hi, Roger Quadros <rogerq@ti.com> writes: >>>> Roger Quadros <rogerq@ti.com> writes: >>>>> Don't make any decisions regarding VBUS session based on ID >>>>> status. That is best left to the OTG core. >>>>> >>>>> Pass ID and VBUS events independent of each other so that OTG >>>>> core knows exactly what to do. >>>>> >>>>> This makes dual-role with extcon work with OTG irq on OMAP platforms. >>>>> >>>>> Signed-off-by: Roger Quadros <rogerq@ti.com> >>>> >>>> I have a feeling this will regress OMAP5432 uEVM. Did you test with that >>>> board ? >>>> >>> >>> Yes. Any specific test case you would like me to test? >>> For now I'm just doing enumeration with g_zero. >> >> IIRC OMAP5 uEVM didn't have separate VBUS and ID GPIOs. How are you >> handling that case ? >> > It comes from the PMIC, extcon-palmas.c. alright, then :-) -- balbi
[toc] | [prev] | [next] | [standalone]
| From | Roger Quadros <rogerq@ti.com> |
|---|---|
| Date | 2016-05-10 12:10 +0200 |
| Subject | Re: [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently |
| Message-ID | <rxcM2-qT-15@gated-at.bofh.it> |
| In reply to | #1397928 |
On 10/05/16 12:55, Felipe Balbi wrote: > > Hi, > > Roger Quadros <rogerq@ti.com> writes: >> Don't make any decisions regarding VBUS session based on ID >> status. That is best left to the OTG core. >> >> Pass ID and VBUS events independent of each other so that OTG >> core knows exactly what to do. >> >> This makes dual-role with extcon work with OTG irq on OMAP platforms. >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> > > I have a feeling this will regress OMAP5432 uEVM. Did you test with that > board ? > Yes. Any specific test case you would like me to test? For now I'm just doing enumeration with g_zero. cheers, -roger
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web