Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1396962 > unrolled thread

[PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

Started byWilliam Wu <william.wu@rock-chips.com>
First post2016-05-09 13:50 +0200
Last post2016-05-10 10:20 +0200
Articles 9 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip William Wu <william.wu@rock-chips.com> - 2016-05-09 13:50 +0200
    Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip Doug Anderson <dianders@google.com> - 2016-05-09 17:20 +0200
      Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip Felipe Balbi <balbi@kernel.org> - 2016-05-10 09:20 +0200
        Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip William Wu <william.wu@rock-chips.com> - 2016-05-10 09:50 +0200
          Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip Felipe Balbi <balbi@kernel.org> - 2016-05-10 10:20 +0200
            Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip William Wu <william.wu@rock-chips.com> - 2016-05-10 10:30 +0200
    Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip Brian Norris <briannorris@chromium.org> - 2016-05-09 21:30 +0200
      Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip Felipe Balbi <balbi@kernel.org> - 2016-05-10 09:20 +0200
        Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip William Wu <william.wu@rock-chips.com> - 2016-05-10 10:20 +0200

#1396962 — [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

FromWilliam Wu <william.wu@rock-chips.com>
Date2016-05-09 13:50 +0200
Subject[PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip
Message-ID<rwRRg-4H5-7@gated-at.bofh.it>
Signed-off-by: William Wu <william.wu@rock-chips.com>
---
 drivers/usb/dwc3/dwc3-of-simple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index 9743353..1f3665b 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
 static const struct of_device_id of_dwc3_simple_match[] = {
 	{ .compatible = "qcom,dwc3" },
 	{ .compatible = "xlnx,zynqmp-dwc3" },
+	{ .compatible = "rockchip,dwc3" },
 	{ /* Sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);
-- 
1.9.1

[toc] | [next] | [standalone]

#1397139

FromDoug Anderson <dianders@google.com>
Date2016-05-09 17:20 +0200
Message-ID<rwV8u-8cW-27@gated-at.bofh.it>
In reply to#1396962
William,

On Mon, May 9, 2016 at 4:46 AM, William Wu <william.wu@rock-chips.com> wrote:
> Signed-off-by: William Wu <william.wu@rock-chips.com>
> ---
>  drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 9743353..1f3665b 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>  static const struct of_device_id of_dwc3_simple_match[] = {
>         { .compatible = "qcom,dwc3" },
>         { .compatible = "xlnx,zynqmp-dwc3" },
> +       { .compatible = "rockchip,dwc3" },

It is, of course, up to Felipe.  ...but personally I'd prefer that
things here be sorted alphabetically.  Sorting things in a consistent
manner tends to reduce merge conflicts as the list gets longer and
also makes it easier to find things.

-Doug

[toc] | [prev] | [next] | [standalone]

#1397750

FromFelipe Balbi <balbi@kernel.org>
Date2016-05-10 09:20 +0200
Message-ID<rxa7v-64x-1@gated-at.bofh.it>
In reply to#1397139

[Multipart message — attachments visible in raw view] — view raw

Hi,

Doug Anderson <dianders@google.com> writes:
> William,
>
> On Mon, May 9, 2016 at 4:46 AM, William Wu <william.wu@rock-chips.com> wrote:
>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>> ---
>>  drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>> index 9743353..1f3665b 100644
>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>>  static const struct of_device_id of_dwc3_simple_match[] = {
>>         { .compatible = "qcom,dwc3" },
>>         { .compatible = "xlnx,zynqmp-dwc3" },
>> +       { .compatible = "rockchip,dwc3" },
>
> It is, of course, up to Felipe.  ...but personally I'd prefer that
> things here be sorted alphabetically.  Sorting things in a consistent
> manner tends to reduce merge conflicts as the list gets longer and
> also makes it easier to find things.

I agree, let's keep it sorted :-)

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1397785

FromWilliam Wu <william.wu@rock-chips.com>
Date2016-05-10 09:50 +0200
Message-ID<rxaAy-6l0-29@gated-at.bofh.it>
In reply to#1397750
Dear Felipe & Doug,
         Thanks for your proposal. It's a good idea to sort the list.
          I'll fix it next patch version.

On 05/10/2016 03:14 PM, Felipe Balbi wrote:
> Hi,
>
> Doug Anderson <dianders@google.com> writes:
>> William,
>>
>> On Mon, May 9, 2016 at 4:46 AM, William Wu <william.wu@rock-chips.com> wrote:
>>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>>> ---
>>>   drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>>> index 9743353..1f3665b 100644
>>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>>>   static const struct of_device_id of_dwc3_simple_match[] = {
>>>          { .compatible = "qcom,dwc3" },
>>>          { .compatible = "xlnx,zynqmp-dwc3" },
>>> +       { .compatible = "rockchip,dwc3" },
>> It is, of course, up to Felipe.  ...but personally I'd prefer that
>> things here be sorted alphabetically.  Sorting things in a consistent
>> manner tends to reduce merge conflicts as the list gets longer and
>> also makes it easier to find things.
> I agree, let's keep it sorted :-)
>

[toc] | [prev] | [next] | [standalone]

#1397828

FromFelipe Balbi <balbi@kernel.org>
Date2016-05-10 10:20 +0200
Message-ID<rxb3A-70Q-11@gated-at.bofh.it>
In reply to#1397785

[Multipart message — attachments visible in raw view] — view raw

Hi William,

William Wu <william.wu@rock-chips.com> writes:
> Dear Felipe & Doug,
>          Thanks for your proposal. It's a good idea to sort the list.
>           I'll fix it next patch version.

cool, thanks.

ps: top-posting is frowned upon here. Please avoid it ;-)

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1397839

FromWilliam Wu <william.wu@rock-chips.com>
Date2016-05-10 10:30 +0200
Message-ID<rxbdg-76W-17@gated-at.bofh.it>
In reply to#1397828
Dear Felipe,

On 05/10/2016 04:11 PM, Felipe Balbi wrote:
> Hi William,
>
> William Wu <william.wu@rock-chips.com> writes:
>> Dear Felipe & Doug,
>>           Thanks for your proposal. It's a good idea to sort the list.
>>            I'll fix it next patch version.
> cool, thanks.
>
> ps: top-posting is frowned upon here. Please avoid it ;-)
>
Thank you for reminding me. I'll pay attention to this problem next 
time.:-)

[toc] | [prev] | [next] | [standalone]

#1397266

FromBrian Norris <briannorris@chromium.org>
Date2016-05-09 21:30 +0200
Message-ID<rwZ2q-3lk-3@gated-at.bofh.it>
In reply to#1396962
Hi William,

Did you leave off linux-rockchip@lists.infradead.org intentionally? IMO,
it's nice to have that list in CC, so interested parties can follow your
work, even if they aren't as fortunate as me to have been CC'd on your
patch directly.

On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote:
> Signed-off-by: William Wu <william.wu@rock-chips.com>
> ---
>  drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 9743353..1f3665b 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>  static const struct of_device_id of_dwc3_simple_match[] = {
>  	{ .compatible = "qcom,dwc3" },
>  	{ .compatible = "xlnx,zynqmp-dwc3" },
> +	{ .compatible = "rockchip,dwc3" },

Add to Documentation/devicetree/bindings/. Do we need a new
Documentation/devicetree/bindings/usb/rockchip,dwc3.txt, to match the
pattern of qcom and xlnx? Or can we just add to dwc3.txt, since so far,
all bindings are documented in the common file?

Brian

>  	{ /* Sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);
> -- 
> 1.9.1
> 
>

[toc] | [prev] | [next] | [standalone]

#1397755

FromFelipe Balbi <balbi@kernel.org>
Date2016-05-10 09:20 +0200
Message-ID<rxa7w-64x-13@gated-at.bofh.it>
In reply to#1397266

[Multipart message — attachments visible in raw view] — view raw

Hi,

Brian Norris <briannorris@chromium.org> writes:
> Hi William,
>
> Did you leave off linux-rockchip@lists.infradead.org intentionally? IMO,
> it's nice to have that list in CC, so interested parties can follow your
> work, even if they aren't as fortunate as me to have been CC'd on your
> patch directly.
>
> On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote:
>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>> ---
>>  drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>> index 9743353..1f3665b 100644
>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>>  static const struct of_device_id of_dwc3_simple_match[] = {
>>  	{ .compatible = "qcom,dwc3" },
>>  	{ .compatible = "xlnx,zynqmp-dwc3" },
>> +	{ .compatible = "rockchip,dwc3" },
>
> Add to Documentation/devicetree/bindings/. Do we need a new
> Documentation/devicetree/bindings/usb/rockchip,dwc3.txt, to match the
> pattern of qcom and xlnx? Or can we just add to dwc3.txt, since so far,
> all bindings are documented in the common file?

dwc3.txt is for dwc3.ko. We need separate files for rockchip, xilinx and
qualcomn :-)

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1397833

FromWilliam Wu <william.wu@rock-chips.com>
Date2016-05-10 10:20 +0200
Message-ID<rxb3B-70Q-29@gated-at.bofh.it>
In reply to#1397755
Dear Felipe and Brian,

On 05/10/2016 03:15 PM, Felipe Balbi wrote:
> Hi,
>
> Brian Norris <briannorris@chromium.org> writes:
>> Hi William,
>>
>> Did you leave off linux-rockchip@lists.infradead.org intentionally? IMO,
>> it's nice to have that list in CC, so interested parties can follow your
>> work, even if they aren't as fortunate as me to have been CC'd on your
>> patch directly.
Actually, I don't know the linux-rockchip@lists.infradead.org before.
I'll add the list in CC next patch version.
Thanks~
>>
>> On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote:
>>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>>> ---
>>>   drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
>>> index 9743353..1f3665b 100644
>>> --- a/drivers/usb/dwc3/dwc3-of-simple.c
>>> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
>>> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>>>   static const struct of_device_id of_dwc3_simple_match[] = {
>>>   	{ .compatible = "qcom,dwc3" },
>>>   	{ .compatible = "xlnx,zynqmp-dwc3" },
>>> +	{ .compatible = "rockchip,dwc3" },
>> Add to Documentation/devicetree/bindings/. Do we need a new
>> Documentation/devicetree/bindings/usb/rockchip,dwc3.txt, to match the
>> pattern of qcom and xlnx? Or can we just add to dwc3.txt, since so far,
>> all bindings are documented in the common file?
> dwc3.txt is for dwc3.ko. We need separate files for rockchip, xilinx and
> qualcomn :-)
I have already prepared a new 
Documentation/devicetree/bindings/usb/rockchip,dwc3.txt,
But considering that rockchip,dwc3.txt should contains phys node 
description which are
not ready yet, so I don't add the dt-bindings patch here.
Is it better to add the dt-bindings patch(rockchip,dwc3.txt) without 
phys node description here?
If it is, I'll add  rockchip,dwc3.txt next patch verison.

And I have some doubts about the name format of the usb dwc3 documents.
I notice that there are at least two types of name format:
1. dwc3-xx.txt  (e.g. dwc3-st.txt )
2. xx, dwc3.txt (e.g. qcom,dwc3.txt)

Which one do you prefer?
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web