Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1397818 > unrolled thread

Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation

Started byRalf Baechle <ralf@linux-mips.org>
First post2016-05-10 10:10 +0200
Last post2016-05-10 11:00 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation Ralf Baechle <ralf@linux-mips.org> - 2016-05-10 10:10 +0200
    Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation Paul Burton <paul.burton@imgtec.com> - 2016-05-10 10:50 +0200
      Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation Ralf Baechle <ralf@linux-mips.org> - 2016-05-10 11:00 +0200

#1397818 — Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation

FromRalf Baechle <ralf@linux-mips.org>
Date2016-05-10 10:10 +0200
SubjectRe: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation
Message-ID<rxaTT-6Vy-1@gated-at.bofh.it>
On Thu, Apr 21, 2016 at 02:04:45PM +0100, Paul Burton wrote:

> The conditions for branching when emulating the BC1EQZ & BC1NEZ
> instructions were backwards, leading to each of those instructions being
> treated as the other. Fix this by reversing the conditions, and clear up
> the code a little for readability & checkpatch.
> 
> Fixes: c909ca718e8f ("MIPS: math-emu: Emulate missing BC1{EQ,NE}Z instructions")
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Reviewed-by: James Hogan <james.hogan@imgtec.com>

Patch ok - but you may want to take Markos off the cc list.  Or iff he's
still interested, is there any new address for him to use instead?

  Ralf

[toc] | [next] | [standalone]


#1397859

FromPaul Burton <paul.burton@imgtec.com>
Date2016-05-10 10:50 +0200
Message-ID<rxbwC-7k3-15@gated-at.bofh.it>
In reply to#1397818
On Tue, May 10, 2016 at 10:09:40AM +0200, Ralf Baechle wrote:
> On Thu, Apr 21, 2016 at 02:04:45PM +0100, Paul Burton wrote:
> 
> > The conditions for branching when emulating the BC1EQZ & BC1NEZ
> > instructions were backwards, leading to each of those instructions being
> > treated as the other. Fix this by reversing the conditions, and clear up
> > the code a little for readability & checkpatch.
> > 
> > Fixes: c909ca718e8f ("MIPS: math-emu: Emulate missing BC1{EQ,NE}Z instructions")
> > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > Reviewed-by: James Hogan <james.hogan@imgtec.com>
> 
> Patch ok - but you may want to take Markos off the cc list.  Or iff he's
> still interested, is there any new address for him to use instead?
> 
>   Ralf

Hi Ralf,

It's a case of automated tooling cc'ing people from relevant git
history, without the knowledge that the email address is no longer
valid. I'll see if I can get it to filter him out next time.

Thanks,
    Paul

[toc] | [prev] | [next] | [standalone]


#1397867

FromRalf Baechle <ralf@linux-mips.org>
Date2016-05-10 11:00 +0200
Message-ID<rxbGi-7ps-3@gated-at.bofh.it>
In reply to#1397859
On Tue, May 10, 2016 at 09:43:15AM +0100, Paul Burton wrote:

> > > The conditions for branching when emulating the BC1EQZ & BC1NEZ
> > > instructions were backwards, leading to each of those instructions being
> > > treated as the other. Fix this by reversing the conditions, and clear up
> > > the code a little for readability & checkpatch.
> > > 
> > > Fixes: c909ca718e8f ("MIPS: math-emu: Emulate missing BC1{EQ,NE}Z instructions")
> > > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > > Reviewed-by: James Hogan <james.hogan@imgtec.com>
> > 
> > Patch ok - but you may want to take Markos off the cc list.  Or iff he's
> > still interested, is there any new address for him to use instead?
> > 
> >   Ralf
> 
> Hi Ralf,
> 
> It's a case of automated tooling cc'ing people from relevant git
> history, without the knowledge that the email address is no longer
> valid. I'll see if I can get it to filter him out next time.

I was guessing so - but hoping there was an updated address for him.
Changing the email address in the commit messages of all pending patches
is one of the easier tricks to do :)

  Ralf

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web