Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391214 > unrolled thread

Re: [GIT PULL] move ARM LCD display driver to auxdisplay

Started byTomi Valkeinen <tomi.valkeinen@ti.com>
First post2016-04-29 17:00 +0200
Last post2016-05-18 16:40 +0200
Articles 10 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [GIT PULL] move ARM LCD display driver to auxdisplay Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-04-29 17:00 +0200
    Re: [GIT PULL] move ARM LCD display driver to auxdisplay Robin van der Gracht <robin@protonic.nl> - 2016-05-09 09:10 +0200
      Re: [GIT PULL] move ARM LCD display driver to auxdisplay Linus Walleij <linus.walleij@linaro.org> - 2016-05-09 15:20 +0200
        Re: [GIT PULL] move ARM LCD display driver to auxdisplay Robin van der Gracht <robin@protonic.nl> - 2016-05-09 16:20 +0200
          Re: [GIT PULL] move ARM LCD display driver to auxdisplay Linus Walleij <linus.walleij@linaro.org> - 2016-05-09 16:30 +0200
            Re: [GIT PULL] move ARM LCD display driver to auxdisplay Greg KH <gregkh@linuxfoundation.org> - 2016-05-10 09:20 +0200
              Re: [GIT PULL] move ARM LCD display driver to auxdisplay Robin van der Gracht <robin@protonic.nl> - 2016-05-11 09:50 +0200
                Re: [GIT PULL] move ARM LCD display driver to auxdisplay Greg KH <gregkh@linuxfoundation.org> - 2016-05-11 10:40 +0200
            Re: [GIT PULL] move ARM LCD display driver to auxdisplay Robin van der Gracht <robin@protonic.nl> - 2016-05-12 12:30 +0200
              Re: [GIT PULL] move ARM LCD display driver to auxdisplay Linus Walleij <linus.walleij@linaro.org> - 2016-05-18 16:40 +0200

#1391214 — Re: [GIT PULL] move ARM LCD display driver to auxdisplay

FromTomi Valkeinen <tomi.valkeinen@ti.com>
Date2016-04-29 17:00 +0200
SubjectRe: [GIT PULL] move ARM LCD display driver to auxdisplay
Message-ID<rti3E-7N6-63@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On 28/04/16 12:26, Maxime Ripard wrote:
> On Tue, Apr 26, 2016 at 12:41:29PM +0200, Linus Walleij wrote:
>> On Mon, Apr 25, 2016 at 1:57 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>>> On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote:
>>>> Hi ARM SoC guys,
>>>>
>>>> these two patches move the ARM character LCD driver from
>>>> misc drivers to the auxdisplay subsystem where it belongs and
>>>> updates the defconfig for the RealView accordingly.
>>>>
>>>> Please pull it into some cleanup branch in the ARM SoC
>>>> tree.
>>>>
>>>> I tried to get some ACK from the auxdisplay maintainer but no
>>>> reaction.
>>>
>>> Auxdisplay is not a new framework, but rather a very old one.
>>>
>>> It got introduced in 2.6.21, and only received a couple of drivers
>>> since.
>>
>> Small problem for me, but Robin is submitting a brand new
>> auxdisplay driver:
>> http://marc.info/?l=linux-kernel&m=146001950512999&w=2
>> http://marc.info/?l=linux-kernel&m=146001988013230&w=2
> 
> My understanding is that Tomi doesn't want any new fbdev drivers, so
> I'm not sure this is the right place for those patches.

Hmm, that one looks like an fbdev driver, not an auxdisplay driver. But,
not relevant for this patch, of course.

>>> It seems to be quite redundant with fbdev deferred_io, which itself is
>>> almost deprecated these days.
>>
>> That is a valid argument for moving cfag12864b* out to
>> drivers/video/* I guess, but it has nothing to do with this
>> driver whatsoever.
>>
>> This driver has nothing to do with fbdev. Nothing at all.
>> It so not connected to any framebuffer.
>>
>> This driver gets moved to auxdisplay to match the existing
>> LCD driver in drivers/auxdisplay/ks0108.c which is a similar
>> hardware, driving an LCD that likewise has nothing to do
>> with fbdev.
> 
> My bad, I thought all auxdisplay drivers were fbdev ones, but I was
> wrong, obviously. And now, I don't really know what auxdisplay is
> about anymore :)
> 
> Still, moving it to a "framework" that has been inactive for so long
> (and you even mention it in your PR) doesn't seem like the right move.

I think this move makes sense. It's only moving a file to a directory
that at least mentions "display", not really moving it into a framework
(because there doesn't seem to be any).

 Tomi

[toc] | [next] | [standalone]

#1396636

FromRobin van der Gracht <robin@protonic.nl>
Date2016-05-09 09:10 +0200
Message-ID<rwNui-87C-9@gated-at.bofh.it>
In reply to#1391214
On Fri, 29 Apr 2016 17:53:17 +0300
Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:

[...] 
> >>
> >> Small problem for me, but Robin is submitting a brand new
> >> auxdisplay driver:
> >> http://marc.info/?l=linux-kernel&m=146001950512999&w=2
> >> http://marc.info/?l=linux-kernel&m=146001988013230&w=2  
> > 
> > My understanding is that Tomi doesn't want any new fbdev drivers, so
> > I'm not sure this is the right place for those patches.  
> 
> Hmm, that one looks like an fbdev driver, not an auxdisplay driver.
> But, not relevant for this patch, of course.

If you guys feel like auxdisplay is not the right subsystem for the
driver, and would like me to move it, please share.

Regards,
Robin van der Gracht

[toc] | [prev] | [next] | [standalone]

#1397041

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-05-09 15:20 +0200
Message-ID<rwTgm-6nf-25@gated-at.bofh.it>
In reply to#1396636
On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht <robin@protonic.nl> wrote:

> If you guys feel like auxdisplay is not the right subsystem for the
> driver, and would like me to move it, please share.

The best would be if you volunteer to maintain it and bring
it forward.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1397082

FromRobin van der Gracht <robin@protonic.nl>
Date2016-05-09 16:20 +0200
Message-ID<rwUcp-7gU-1@gated-at.bofh.it>
In reply to#1397041
On Mon, 9 May 2016 15:19:26 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
> <robin@protonic.nl> wrote:
> 
> > If you guys feel like auxdisplay is not the right subsystem for the
> > driver, and would like me to move it, please share.  
> 
> The best would be if you volunteer to maintain it and bring
> it forward.

Thats fine. Would it suffice if I submit another patch adding myself
to the maintainers file?

Regards,
Robin

[toc] | [prev] | [next] | [standalone]

#1397092

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-05-09 16:30 +0200
Message-ID<rwUm6-7na-23@gated-at.bofh.it>
In reply to#1397082
On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht <robin@protonic.nl> wrote:
> On Mon, 9 May 2016 15:19:26 +0200
> Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
>> <robin@protonic.nl> wrote:
>>
>> > If you guys feel like auxdisplay is not the right subsystem for the
>> > driver, and would like me to move it, please share.
>>
>> The best would be if you volunteer to maintain it and bring
>> it forward.
>
> Thats fine. Would it suffice if I submit another patch adding myself
> to the maintainers file?

That's half of it, if Miguel does not come back then his name
should be removed as the second step.

You also need to have an idea on a path to funnel accumulated
patches upstream to Torvalds. The recent patches to this
subsystem were funneled by Greg, so we should ask him how
he prefer to proceed.

Greg, what do you prefer?

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1397753

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-05-10 09:20 +0200
Message-ID<rxa7w-64x-5@gated-at.bofh.it>
In reply to#1397092
On Mon, May 09, 2016 at 04:27:00PM +0200, Linus Walleij wrote:
> On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht <robin@protonic.nl> wrote:
> > On Mon, 9 May 2016 15:19:26 +0200
> > Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> >> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
> >> <robin@protonic.nl> wrote:
> >>
> >> > If you guys feel like auxdisplay is not the right subsystem for the
> >> > driver, and would like me to move it, please share.
> >>
> >> The best would be if you volunteer to maintain it and bring
> >> it forward.
> >
> > Thats fine. Would it suffice if I submit another patch adding myself
> > to the maintainers file?
> 
> That's half of it, if Miguel does not come back then his name
> should be removed as the second step.
> 
> You also need to have an idea on a path to funnel accumulated
> patches upstream to Torvalds. The recent patches to this
> subsystem were funneled by Greg, so we should ask him how
> he prefer to proceed.
> 
> Greg, what do you prefer?

I don't care :)

I can keep doing this, sending stuff to Linus through my char/misc tree,
or it can go through someone else's tree, it doesn't bother me...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1398744

FromRobin van der Gracht <robin@protonic.nl>
Date2016-05-11 09:50 +0200
Message-ID<rxx46-3Bt-5@gated-at.bofh.it>
In reply to#1397753
On Tue, 10 May 2016 09:10:04 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Mon, May 09, 2016 at 04:27:00PM +0200, Linus Walleij wrote:
> > On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht
> > <robin@protonic.nl> wrote:  
> > > On Mon, 9 May 2016 15:19:26 +0200
> > > Linus Walleij <linus.walleij@linaro.org> wrote:
> > >  
> > >> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
> > >> <robin@protonic.nl> wrote:
> > >>  
> > >> > If you guys feel like auxdisplay is not the right subsystem
> > >> > for the driver, and would like me to move it, please share.  
> > >>
> > >> The best would be if you volunteer to maintain it and bring
> > >> it forward.  
> > >
> > > Thats fine. Would it suffice if I submit another patch adding
> > > myself to the maintainers file?  
> > 
> > That's half of it, if Miguel does not come back then his name
> > should be removed as the second step.
> > 
> > You also need to have an idea on a path to funnel accumulated
> > patches upstream to Torvalds. The recent patches to this
> > subsystem were funneled by Greg, so we should ask him how
> > he prefer to proceed.
> > 
> > Greg, what do you prefer?  
> 
> I don't care :)
> 
> I can keep doing this, sending stuff to Linus through my char/misc
> tree, or it can go through someone else's tree, it doesn't bother
> me...

Soo.. You're allowing me to send patches to you so you can funnel
them through your channel (for now)?

Kind regards,
Robin

[toc] | [prev] | [next] | [standalone]

#1398786

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-05-11 10:40 +0200
Message-ID<rxxQt-4q4-1@gated-at.bofh.it>
In reply to#1398744
On Wed, May 11, 2016 at 09:46:35AM +0200, Robin van der Gracht wrote:
> On Tue, 10 May 2016 09:10:04 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Mon, May 09, 2016 at 04:27:00PM +0200, Linus Walleij wrote:
> > > On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht
> > > <robin@protonic.nl> wrote:  
> > > > On Mon, 9 May 2016 15:19:26 +0200
> > > > Linus Walleij <linus.walleij@linaro.org> wrote:
> > > >  
> > > >> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
> > > >> <robin@protonic.nl> wrote:
> > > >>  
> > > >> > If you guys feel like auxdisplay is not the right subsystem
> > > >> > for the driver, and would like me to move it, please share.  
> > > >>
> > > >> The best would be if you volunteer to maintain it and bring
> > > >> it forward.  
> > > >
> > > > Thats fine. Would it suffice if I submit another patch adding
> > > > myself to the maintainers file?  
> > > 
> > > That's half of it, if Miguel does not come back then his name
> > > should be removed as the second step.
> > > 
> > > You also need to have an idea on a path to funnel accumulated
> > > patches upstream to Torvalds. The recent patches to this
> > > subsystem were funneled by Greg, so we should ask him how
> > > he prefer to proceed.
> > > 
> > > Greg, what do you prefer?  
> > 
> > I don't care :)
> > 
> > I can keep doing this, sending stuff to Linus through my char/misc
> > tree, or it can go through someone else's tree, it doesn't bother
> > me...
> 
> Soo.. You're allowing me to send patches to you so you can funnel
> them through your channel (for now)?

Sure, I'd be glad to do so if that makes your life easier.  Either way
it's no real extra or less overall workload for me :)

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1399879

FromRobin van der Gracht <robin@protonic.nl>
Date2016-05-12 12:30 +0200
Message-ID<rxW2v-3Gh-27@gated-at.bofh.it>
In reply to#1397092
On Mon, 9 May 2016 16:27:00 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Mon, May 9, 2016 at 4:17 PM, Robin van der Gracht
> <robin@protonic.nl> wrote:
> > On Mon, 9 May 2016 15:19:26 +0200
> > Linus Walleij <linus.walleij@linaro.org> wrote:
> >  
> >> On Mon, May 9, 2016 at 9:06 AM, Robin van der Gracht
> >> <robin@protonic.nl> wrote:
> >>  
> >> > If you guys feel like auxdisplay is not the right subsystem for
> >> > the driver, and would like me to move it, please share.  
> >>
> >> The best would be if you volunteer to maintain it and bring
> >> it forward.  
> >
> > Thats fine. Would it suffice if I submit another patch adding myself
> > to the maintainers file?  
> 
> That's half of it, if Miguel does not come back then his name
> should be removed as the second step.
> 

First half is completed. I've added myself as maintainer for the
driver I've posted recently (HT16K33 LED CONTROLLER DRIVER).

According to MAINTAINERS, Miguel maintains:
 - CFAG12864B LCD DRIVER
 - CFAG12864BFB LCD FRAMEBUFFER DRIVER
 - KS0108 LCD CONTROLLER DRIVER
 - AUXILIARY DISPLAY DRIVERS

AFAIK, I should not be judge in Miguels case.

@linus: I'll send my patches to Greg if you agree on this.

Kind regards,
Robin van der Gracht

[toc] | [prev] | [next] | [standalone]

#1403037

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-05-18 16:40 +0200
Message-ID<rAaNH-3lc-15@gated-at.bofh.it>
In reply to#1399879
On Thu, May 12, 2016 at 12:25 PM, Robin van der Gracht
<robin@protonic.nl> wrote:

> First half is completed. I've added myself as maintainer for the
> driver I've posted recently (HT16K33 LED CONTROLLER DRIVER).

Good!

> According to MAINTAINERS, Miguel maintains:
>  - CFAG12864B LCD DRIVER
>  - CFAG12864BFB LCD FRAMEBUFFER DRIVER
>  - KS0108 LCD CONTROLLER DRIVER
>  - AUXILIARY DISPLAY DRIVERS
>
> AFAIK, I should not be judge in Miguels case.

If patches come in for these drivers and Miguel still seem to be fallen
off the face of the earth I think you should ACK/merge patches for
these too, but deal with it when it happens.

> @linus: I'll send my patches to Greg if you agree on this.

We are in agreement.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web