Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399828 > unrolled thread

[PATCH] kernel: cgroup: fix compile warning:

Back to article view | Back to linux.kernel

Contents

  [PATCH] kernel: cgroup: fix compile warning: Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-05-12 11:40 +0200
    Re: [PATCH] kernel: cgroup: fix compile warning: Tejun Heo <tj@kernel.org> - 2016-05-12 17:10 +0200

#1399828 — [PATCH] kernel: cgroup: fix compile warning:

commit 4f41fc59620f ("cgroup, kernfs: make mountinfo
 show properly scoped path for cgroup namespaces")
 added the following compile warning:

kernel/cgroup.c: In function ‘cgroup_show_path’:
kernel/cgroup.c:1634:15: warning: unused variable ‘ret’ [-Wunused-variable]
  int len = 0, ret = 0;
               ^
fix it.

Fixes: 4f41fc59620f ("cgroup, kernfs: make mountinfo
	show properly scoped path for cgroup
	namespaces")
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
---
 kernel/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index afea39eb7649..86cb5c6e8932 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1631,7 +1631,7 @@ static int rebind_subsystems(struct cgroup_root *dst_root, u16 ss_mask)
 static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
 			    struct kernfs_root *kf_root)
 {
-	int len = 0, ret = 0;
+	int len = 0;
 	char *buf = NULL;
 	struct cgroup_root *kf_cgroot = cgroup_root_from_kf(kf_root);
 	struct cgroup *ns_cgroup;
-- 
2.8.2

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[toc] | [next] | [standalone]

#1400140

On Thu, May 12, 2016 at 12:34:38PM +0300, Felipe Balbi wrote:
> commit 4f41fc59620f ("cgroup, kernfs: make mountinfo
>  show properly scoped path for cgroup namespaces")
>  added the following compile warning:
> 
> kernel/cgroup.c: In function ‘cgroup_show_path’:
> kernel/cgroup.c:1634:15: warning: unused variable ‘ret’ [-Wunused-variable]
>   int len = 0, ret = 0;
>                ^
> fix it.
> 
> Fixes: 4f41fc59620f ("cgroup, kernfs: make mountinfo
> 	show properly scoped path for cgroup
> 	namespaces")
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

Applied to cgroup/for-4.6-fixes.

Thanks.

-- 
tejun

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web