Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1399859 > unrolled thread
| Started by | Olliver Schinagl <oliver@schinagl.nl> |
|---|---|
| First post | 2016-05-12 12:20 +0200 |
| Last post | 2016-05-13 10:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile Olliver Schinagl <oliver@schinagl.nl> - 2016-05-12 12:20 +0200
Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-05-13 09:50 +0200
Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile Olliver Schinagl <oliver@schinagl.nl> - 2016-05-13 10:10 +0200
| From | Olliver Schinagl <oliver@schinagl.nl> |
|---|---|
| Date | 2016-05-12 12:20 +0200 |
| Subject | [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile |
| Message-ID | <rxVSO-3yT-15@gated-at.bofh.it> |
commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new emmc equipped) lime2 but forgot its Makefile. This patch adds an entry to the Makefile. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> --- Changes since v0: Added proper commit reference. arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 95c1923..07f4cf8 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -695,6 +695,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \ sun7i-a20-olimex-som-evb.dtb \ sun7i-a20-olinuxino-lime.dtb \ sun7i-a20-olinuxino-lime2.dtb \ + sun7i-a20-olinuxino-lime2-emmc.dtb \ sun7i-a20-olinuxino-micro.dtb \ sun7i-a20-orangepi.dtb \ sun7i-a20-orangepi-mini.dtb \ -- 2.8.1
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-05-13 09:50 +0200 |
| Subject | Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile |
| Message-ID | <ryg1c-7nz-13@gated-at.bofh.it> |
| In reply to | #1399859 |
[Multipart message — attachments visible in raw view] — view raw
Hi Olliver, On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote: > commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new > emmc equipped) lime2 but forgot its Makefile. This is still not the right commit format, the commit title should be around double quotes. checkpatch both reports an error for this and tells you what the proper format is, so please remember to use it before you're sending a patch. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Olliver Schinagl <oliver@schinagl.nl> |
|---|---|
| Date | 2016-05-13 10:10 +0200 |
| Subject | Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile |
| Message-ID | <rygky-7Xv-13@gated-at.bofh.it> |
| In reply to | #1400556 |
and now i'm embarrassed and ashamed. Teaches me not to rush things, right? i'll correct it and take some time to do it right. sorry maxime! On 13-05-16 09:48, Maxime Ripard wrote: > Hi Olliver, > > On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote: >> commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new >> emmc equipped) lime2 but forgot its Makefile. > This is still not the right commit format, the commit title should be > around double quotes. checkpatch both reports an error for this and > tells you what the proper format is, so please remember to use it > before you're sending a patch. > > Thanks! > Maxime >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web