Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399453 > unrolled thread

[PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata().

Started bySandhya Bankar <bankarsandhya512@gmail.com>
First post2016-05-11 21:40 +0200
Last post2016-05-11 21:50 +0200
Articles 3 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/3] Remove unnecessary pci_set_drvdata() and  platform_set_drvdata(). Sandhya Bankar <bankarsandhya512@gmail.com> - 2016-05-11 21:40 +0200
    [PATCH 2/3] usb: dwc3-keystone: Remove unnecessary  platform_set_drvdata(). Sandhya Bankar <bankarsandhya512@gmail.com> - 2016-05-11 21:50 +0200
    [PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set_drvdata(). Sandhya Bankar <bankarsandhya512@gmail.com> - 2016-05-11 21:50 +0200

#1399453 — [PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata().

FromSandhya Bankar <bankarsandhya512@gmail.com>
Date2016-05-11 21:40 +0200
Subject[PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata().
Message-ID<rxI9c-6rJ-21@gated-at.bofh.it>
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver datato NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL.

Sandhya Bankar (3):
  usb: pci: Remove unnecessary pci_set_drvdata().
  usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().
  usb: gr_udec: Remove unnecessary platform_set_drvdata().

 drivers/usb/dwc2/pci.c           | 1 -
 drivers/usb/dwc3/dwc3-keystone.c | 1 -
 drivers/usb/gadget/udc/gr_udc.c  | 1 -
 3 files changed, 3 deletions(-)

-- 
1.8.3.4

[toc] | [next] | [standalone]


#1399455 — [PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().

FromSandhya Bankar <bankarsandhya512@gmail.com>
Date2016-05-11 21:50 +0200
Subject[PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().
Message-ID<rxIiR-6wb-3@gated-at.bofh.it>
In reply to#1399453
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/usb/dwc3/dwc3-keystone.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
index 7266470..089bb70 100644
--- a/drivers/usb/dwc3/dwc3-keystone.c
+++ b/drivers/usb/dwc3/dwc3-keystone.c
@@ -164,7 +164,6 @@ static int kdwc3_remove(struct platform_device *pdev)
 	kdwc3_disable_irqs(kdwc);
 	device_for_each_child(&pdev->dev, NULL, kdwc3_remove_core);
 	clk_disable_unprepare(kdwc->clk);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }
-- 
1.8.3.4

[toc] | [prev] | [next] | [standalone]


#1399458 — [PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set_drvdata().

FromSandhya Bankar <bankarsandhya512@gmail.com>
Date2016-05-11 21:50 +0200
Subject[PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set_drvdata().
Message-ID<rxIiR-6wb-15@gated-at.bofh.it>
In reply to#1399453
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/usb/gadget/udc/gr_udc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
index 39b7136..05f956c 100644
--- a/drivers/usb/gadget/udc/gr_udc.c
+++ b/drivers/usb/gadget/udc/gr_udc.c
@@ -2117,7 +2117,6 @@ static int gr_remove(struct platform_device *pdev)
 
 	gr_dfs_delete(dev);
 	dma_pool_destroy(dev->desc_pool);
-	platform_set_drvdata(pdev, NULL);
 
 	gr_free_request(&dev->epi[0].ep, &dev->ep0reqi->req);
 	gr_free_request(&dev->epo[0].ep, &dev->ep0reqo->req);
-- 
1.8.3.4

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web