Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399007 > unrolled thread

Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")]

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-05-11 14:20 +0200
    Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-05-11 14:30 +0200
      Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-05-11 14:50 +0200
    Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-05-11 14:40 +0200
      Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Steven Rostedt <rostedt@goodmis.org> - 2016-05-11 14:50 +0200
        Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-05-11 16:00 +0200
      Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> - 2016-05-11 15:40 +0200
        Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Jim Bos <jim876@xs4all.nl> - 2016-05-11 17:30 +0200
          Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-11 18:20 +0200
            Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-05-11 18:30 +0200
              Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online  calls to hotplugged cpu")] "Rafael J. Wysocki" <rafael@kernel.org> - 2016-05-11 18:30 +0200

#1399007 — Re: S3 resume regression [1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")]

On 05/11/2016 12:19 PM, Ville Syrjälä wrote:
> Hi,
Hi,

> I have a Lenovo Ideapad S10-3t machine here (Atom N450, 1 core, 2 HT)
> which fails to resume from S3 on 4.6-rc releases. I bisected it down to
> 
> commit 1cf4f629d9d246519a1e76c021806f2a51ddba4d
> Author: Thomas Gleixner <tglx@linutronix.de>
> Date:   Fri Feb 26 18:43:39 2016 +0000
> 
>     cpu/hotplug: Move online calls to hotplugged cpu
> 
> Unfortunately that won't revert cleanly, and neither does the merge
> commit, so I was unable to see if that is the only problematic commit
> in 4.6.
> 
> Any ideas?

do you have a backtrace or anything or is it just not working and you
end up with a blank screen?

Sebastian

[toc] | [next] | [standalone]

#1399018

On 05/11/2016 02:21 PM, Ville Syrjälä wrote:
> Yeah can't get anything from the machine at that point. netconsole
> didn't help either, and no serial on this machine. And IIRC I've
> tried ramoops on this thing in the past but unfortunately the memory
> got cleared on reboot.

efi + pstore maybe?

Sebastian

[toc] | [prev] | [next] | [standalone]

#1399032

On Wed, May 11, 2016 at 02:24:51PM +0200, Sebastian Andrzej Siewior wrote:
> On 05/11/2016 02:21 PM, Ville Syrjälä wrote:
> > Yeah can't get anything from the machine at that point. netconsole
> > didn't help either, and no serial on this machine. And IIRC I've
> > tried ramoops on this thing in the past but unfortunately the memory
> > got cleared on reboot.
> 
> efi + pstore maybe?

I think you might have the wrong decade in mind.

-- 
Ville Syrjälä
Intel OTC

[toc] | [prev] | [next] | [standalone]

#1399020

On Wed, May 11, 2016 at 02:11:29PM +0200, Sebastian Andrzej Siewior wrote:
> On 05/11/2016 12:19 PM, Ville Syrjälä wrote:
> > Hi,
> Hi,
> 
> > I have a Lenovo Ideapad S10-3t machine here (Atom N450, 1 core, 2 HT)
> > which fails to resume from S3 on 4.6-rc releases. I bisected it down to
> > 
> > commit 1cf4f629d9d246519a1e76c021806f2a51ddba4d
> > Author: Thomas Gleixner <tglx@linutronix.de>
> > Date:   Fri Feb 26 18:43:39 2016 +0000
> > 
> >     cpu/hotplug: Move online calls to hotplugged cpu
> > 
> > Unfortunately that won't revert cleanly, and neither does the merge
> > commit, so I was unable to see if that is the only problematic commit
> > in 4.6.
> > 
> > Any ideas?
> 
> do you have a backtrace or anything or is it just not working and you
> end up with a blank screen?

Yeah can't get anything from the machine at that point. netconsole
didn't help either, and no serial on this machine. And IIRC I've
tried ramoops on this thing in the past but unfortunately the memory
got cleared on reboot.

-- 
Ville Syrjälä
Intel OTC

[toc] | [prev] | [next] | [standalone]

#1399031

On Wed, 11 May 2016 15:21:16 +0300
Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:

> Yeah can't get anything from the machine at that point. netconsole
> didn't help either, and no serial on this machine. And IIRC I've
> tried ramoops on this thing in the past but unfortunately the memory
> got cleared on reboot.
> 

Can you look at the documentation in the kernel code at

Documentation/power/basic-pm-debugging.txt And follow the procedures
for testing suspend to RAM (although it requires mostly running the
same tests as for hibernation suspending).

You can also use the tool s2ram for this as well.

See Documentation/power/s2ram.txt

Perhaps this can give us a bit more light onto the problem.

Basically the above does partial suspend and resume, and can pinpoint
problem areas down to a more select location.


Thanks!

-- Steve

[toc] | [prev] | [next] | [standalone]

#1399140

On Wed, May 11, 2016 at 08:44:45AM -0400, Steven Rostedt wrote:
> On Wed, 11 May 2016 15:21:16 +0300
> Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> 
> > Yeah can't get anything from the machine at that point. netconsole
> > didn't help either, and no serial on this machine. And IIRC I've
> > tried ramoops on this thing in the past but unfortunately the memory
> > got cleared on reboot.
> > 
> 
> Can you look at the documentation in the kernel code at
> 
> Documentation/power/basic-pm-debugging.txt And follow the procedures
> for testing suspend to RAM (although it requires mostly running the
> same tests as for hibernation suspending).
> 
> You can also use the tool s2ram for this as well.
> 
> See Documentation/power/s2ram.txt
> 
> Perhaps this can give us a bit more light onto the problem.
> 
> Basically the above does partial suspend and resume, and can pinpoint
> problem areas down to a more select location.

All the pm_test modes work fine. The only difference between them was
that 'platform' required me to manually wake up the machine (hitting a
key was sufficient), whereas the others woke up without help.

pm_trace gave me
[    1.306633]   Magic number: 0:185:178
[    1.322880]   hash matches ../drivers/base/power/main.c:1070
[    1.339270] acpi device:0e: hash matches
[    1.355414]  platform: hash matches

which is the TRACE_SUSPEND in __device_suspend_noirq(), so no help
there.

I guess I could try to sprinkle more TRACE_RESUMEs around into some
early resume code. If anyone has good ideas where to put them it
might speed things up a bit.

-- 
Ville Syrjälä
Intel OTC

[toc] | [prev] | [next] | [standalone]

#1399079

On 5/11/2016 2:21 PM, Ville Syrjälä wrote:
> On Wed, May 11, 2016 at 02:11:29PM +0200, Sebastian Andrzej Siewior wrote:
>> On 05/11/2016 12:19 PM, Ville Syrjälä wrote:
>>> Hi,
>> Hi,
>>
>>> I have a Lenovo Ideapad S10-3t machine here (Atom N450, 1 core, 2 HT)
>>> which fails to resume from S3 on 4.6-rc releases. I bisected it down to
>>>
>>> commit 1cf4f629d9d246519a1e76c021806f2a51ddba4d
>>> Author: Thomas Gleixner <tglx@linutronix.de>
>>> Date:   Fri Feb 26 18:43:39 2016 +0000
>>>
>>>      cpu/hotplug: Move online calls to hotplugged cpu
>>>
>>> Unfortunately that won't revert cleanly, and neither does the merge
>>> commit, so I was unable to see if that is the only problematic commit
>>> in 4.6.
>>>
>>> Any ideas?
>> do you have a backtrace or anything or is it just not working and you
>> end up with a blank screen?
> Yeah can't get anything from the machine at that point. netconsole
> didn't help either, and no serial on this machine. And IIRC I've
> tried ramoops on this thing in the past but unfortunately the memory
> got cleared on reboot.
>

Please try

# echo processors > /sys/power/pm_test

and then suspend (it should simulate a suspend, wait for approx. 5 sec 
and then resume, see
Documentation/power/basic_pm_debugging.txt for details).  See if that 
works or if you can get any
traces etc.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1399252

[Multipart message — attachments visible in raw view] — view raw

On 05/11/2016 03:36 PM, Rafael J. Wysocki wrote:
> On 5/11/2016 2:21 PM, Ville Syrjälä wrote:
>> On Wed, May 11, 2016 at 02:11:29PM +0200, Sebastian Andrzej Siewior
>> wrote:
>>> On 05/11/2016 12:19 PM, Ville Syrjälä wrote:
>>>> Hi,
>>> Hi,
>>>
>>>> I have a Lenovo Ideapad S10-3t machine here (Atom N450, 1 core, 2 HT)
>>>> which fails to resume from S3 on 4.6-rc releases. I bisected it down to
>>>>
>>>> commit 1cf4f629d9d246519a1e76c021806f2a51ddba4d
>>>> Author: Thomas Gleixner <tglx@linutronix.de>
>>>> Date:   Fri Feb 26 18:43:39 2016 +0000
>>>>
>>>>      cpu/hotplug: Move online calls to hotplugged cpu
>>>>
>>>> Unfortunately that won't revert cleanly, and neither does the merge
>>>> commit, so I was unable to see if that is the only problematic commit
>>>> in 4.6.
>>>>
>>>> Any ideas?
>>> do you have a backtrace or anything or is it just not working and you
>>> end up with a blank screen?
>> Yeah can't get anything from the machine at that point. netconsole
>> didn't help either, and no serial on this machine. And IIRC I've
>> tried ramoops on this thing in the past but unfortunately the memory
>> got cleared on reboot.
>>
> 
> Please try
> 
> # echo processors > /sys/power/pm_test
> 
> and then suspend (it should simulate a suspend, wait for approx. 5 sec
> and then resume, see
> Documentation/power/basic_pm_debugging.txt for details).  See if that
> works or if you can get any
> traces etc.
> 
> Thanks,
> Rafael
> 


Hmm, I thought I had some resume issue but ignored that, so I just tried
again.
On 4.6.0-rc1 all is fine but on 4.6.0-rc7 on resume the machine locks up
totally. No response on ping or sysrq-B, only hard reset works.

Tried this 'echo processors > /sys/power/pm_test' follow by pm-suspend

and did find a lot of ACPI errors (attached) in the log which are
definitely not present after normal boot.

This is on a Intel(R) Pentium(R) CPU G3220 @ 3.00GHz

So not sure if this is same issue but just wanted to mention it.

_
Jim

[toc] | [prev] | [next] | [standalone]

#1399313

On Wed, May 11, 2016 at 5:25 PM, Jim Bos <jim876@xs4all.nl> wrote:
> On 05/11/2016 03:36 PM, Rafael J. Wysocki wrote:
>> On 5/11/2016 2:21 PM, Ville Syrjälä wrote:
>>> On Wed, May 11, 2016 at 02:11:29PM +0200, Sebastian Andrzej Siewior
>>> wrote:
>>>> On 05/11/2016 12:19 PM, Ville Syrjälä wrote:
>>>>> Hi,
>>>> Hi,
>>>>
>>>>> I have a Lenovo Ideapad S10-3t machine here (Atom N450, 1 core, 2 HT)
>>>>> which fails to resume from S3 on 4.6-rc releases. I bisected it down to
>>>>>
>>>>> commit 1cf4f629d9d246519a1e76c021806f2a51ddba4d
>>>>> Author: Thomas Gleixner <tglx@linutronix.de>
>>>>> Date:   Fri Feb 26 18:43:39 2016 +0000
>>>>>
>>>>>      cpu/hotplug: Move online calls to hotplugged cpu
>>>>>
>>>>> Unfortunately that won't revert cleanly, and neither does the merge
>>>>> commit, so I was unable to see if that is the only problematic commit
>>>>> in 4.6.
>>>>>
>>>>> Any ideas?
>>>> do you have a backtrace or anything or is it just not working and you
>>>> end up with a blank screen?
>>> Yeah can't get anything from the machine at that point. netconsole
>>> didn't help either, and no serial on this machine. And IIRC I've
>>> tried ramoops on this thing in the past but unfortunately the memory
>>> got cleared on reboot.
>>>
>>
>> Please try
>>
>> # echo processors > /sys/power/pm_test
>>
>> and then suspend (it should simulate a suspend, wait for approx. 5 sec
>> and then resume, see
>> Documentation/power/basic_pm_debugging.txt for details).  See if that
>> works or if you can get any
>> traces etc.
>>
>> Thanks,
>> Rafael
>>
>
>
> Hmm, I thought I had some resume issue but ignored that, so I just tried
> again.
> On 4.6.0-rc1 all is fine but on 4.6.0-rc7 on resume the machine locks up
> totally. No response on ping or sysrq-B, only hard reset works.
>
> Tried this 'echo processors > /sys/power/pm_test' follow by pm-suspend
>
> and did find a lot of ACPI errors (attached) in the log which are
> definitely not present after normal boot.
>
> This is on a Intel(R) Pentium(R) CPU G3220 @ 3.00GHz
>
> So not sure if this is same issue but just wanted to mention it.

If the problem is reproducible, you should be able to identify the
commit that broke things for you.

Have you tried to check if this is the same commit reported in this thread?

[toc] | [prev] | [next] | [standalone]

#1399321

On 05/11/2016 06:19 PM, Rafael J. Wysocki wrote:
> Have you tried to check if this is the same commit reported in this thread?

The commit in this thread is part of v4.6-rc1 and he is saying that rc1
is working fine.

Sebastian

[toc] | [prev] | [next] | [standalone]

#1399324

On Wed, May 11, 2016 at 6:21 PM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> On 05/11/2016 06:19 PM, Rafael J. Wysocki wrote:
>> Have you tried to check if this is the same commit reported in this thread?
>
> The commit in this thread is part of v4.6-rc1 and he is saying that rc1
> is working fine.

I see.  That is a different problem then.

Jim, can you please start a new thread (with a CC to linux-pm) or just
file a bug at bugzilla.kernel.org to avoid confusing things?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web