Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1399088 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-05-11 15:50 +0200 |
| Last post | 2016-05-11 16:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] ata: dwc: add DMADEVICES dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-11 15:50 +0200
Re: [PATCH v2] ata: dwc: add DMADEVICES dependency Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-05-11 16:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-11 15:50 +0200 |
| Subject | [PATCH v2] ata: dwc: add DMADEVICES dependency |
| Message-ID | <rxCGu-Pf-1@gated-at.bofh.it> |
The dwc_460ex SATA driver has become available on non-powerpc architectures
and may cause randconfig build errors when CONFIG_DMADEVICES is not set
and SATA_DWC_OLD_DMA is enabled:
warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!
This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we
cannot run into broken configurations. While it would also be
possible to build the driver with both CONFIG_DMADEVICES
and SATA_DWC_OLD_DMA disabled, that case is not useful because
there is no fallback to PIO mode when the DMA engine is not
usable.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")
---
drivers/ata/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 41b0725e58ad..e2dc4c045146 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -313,6 +313,7 @@ config ATA_PIIX
config SATA_DWC
tristate "DesignWare Cores SATA support"
+ depends on DMADEVICES
select GENERIC_PHY
help
This option enables support for the on-chip SATA controller of the
--
2.7.0
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2016-05-11 16:00 +0200 |
| Message-ID | <rxCQb-UH-43@gated-at.bofh.it> |
| In reply to | #1399088 |
On Wed, May 11, 2016 at 4:42 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The dwc_460ex SATA driver has become available on non-powerpc architectures
> and may cause randconfig build errors when CONFIG_DMADEVICES is not set
> and SATA_DWC_OLD_DMA is enabled:
>
> warning: (SATA_DWC_OLD_DMA) selects DW_DMAC_CORE which has unmet direct dependencies (DMADEVICES)
> ERROR: "dw_dma_probe" [drivers/ata/sata_dwc_460ex.ko] undefined!
> ERROR: "dw_dma_remove" [drivers/ata/sata_dwc_460ex.ko] undefined!
>
> This adds an explcit Kconfig dependency to CONFIG_SATA_DWC so we
> cannot run into broken configurations. While it would also be
> possible to build the driver with both CONFIG_DMADEVICES
> and SATA_DWC_OLD_DMA disabled, that case is not useful because
> there is no fallback to PIO mode when the DMA engine is not
> usable.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 50b433753df6 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")
Looks reasonable to me:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/ata/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 41b0725e58ad..e2dc4c045146 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -313,6 +313,7 @@ config ATA_PIIX
>
> config SATA_DWC
> tristate "DesignWare Cores SATA support"
> + depends on DMADEVICES
> select GENERIC_PHY
> help
> This option enables support for the on-chip SATA controller of the
> --
> 2.7.0
>
--
With Best Regards,
Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web