Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1397616 > unrolled thread

[PATCH 1/4] fs: befs: remove unneeded initialization to NULL

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/4] fs: befs: remove unneeded initialization to NULL Salah Triki <salah.triki@acm.org> - 2016-05-10 03:20 +0200
    [PATCH 2/4] fs: befs: remove unneeded initialization to NULL Salah Triki <salah.triki@acm.org> - 2016-05-10 03:20 +0200
    [PATCH 4/4] fs: befs: remove unneeded initialization to NULL Salah Triki <salah.triki@acm.org> - 2016-05-10 03:20 +0200
    [PATCH 3/4] fs: befs: remove unneeded initialization to NULL Salah Triki <salah.triki@acm.org> - 2016-05-10 03:20 +0200

#1397616 — [PATCH 1/4] fs: befs: remove unneeded initialization to NULL

inode is reinitialized by befs_iget() so no need to init it
with NULL in the beginning of befs_lookup()

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 fs/befs/linuxvfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index cc0e082..dded1c7 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -155,7 +155,7 @@ befs_get_block(struct inode *inode, sector_t block,
 static struct dentry *
 befs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
 {
-	struct inode *inode = NULL;
+	struct inode *inode;
 	struct super_block *sb = dir->i_sb;
 	befs_data_stream *ds = &BEFS_I(dir)->i_data.ds;
 	befs_off_t offset;
-- 
1.9.1

[toc] | [next] | [standalone]

#1397617 — [PATCH 2/4] fs: befs: remove unneeded initialization to NULL

bh is reinitialized by befs_bread() so no need to init it
with NULL in the beginning of befs_iget()

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 fs/befs/linuxvfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index dded1c7..3610c61 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -294,7 +294,7 @@ static void init_once(void *foo)
 
 static struct inode *befs_iget(struct super_block *sb, unsigned long ino)
 {
-	struct buffer_head *bh = NULL;
+	struct buffer_head *bh;
 	befs_inode *raw_inode = NULL;
 	struct befs_sb_info *befs_sb = BEFS_SB(sb);
 	struct befs_inode_info *befs_ino = NULL;
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1397622 — [PATCH 4/4] fs: befs: remove unneeded initialization to NULL

befs_ino is reinitialized by BEFS_I() so no need to init it
with NULL in the beginning of befs_iget()

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 fs/befs/linuxvfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index 85c77e1..20b3f8d 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -297,7 +297,7 @@ static struct inode *befs_iget(struct super_block *sb, unsigned long ino)
 	struct buffer_head *bh;
 	befs_inode *raw_inode;
 	struct befs_sb_info *befs_sb = BEFS_SB(sb);
-	struct befs_inode_info *befs_ino = NULL;
+	struct befs_inode_info *befs_ino;
 	struct inode *inode;
 	long ret = -EIO;
 
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1397623 — [PATCH 3/4] fs: befs: remove unneeded initialization to NULL

raw_inode is reinitialized to bh->b_data so no need to init it
with NULL in the beginning of befs_iget()

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 fs/befs/linuxvfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index 3610c61..85c77e1 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -295,7 +295,7 @@ static void init_once(void *foo)
 static struct inode *befs_iget(struct super_block *sb, unsigned long ino)
 {
 	struct buffer_head *bh;
-	befs_inode *raw_inode = NULL;
+	befs_inode *raw_inode;
 	struct befs_sb_info *befs_sb = BEFS_SB(sb);
 	struct befs_inode_info *befs_ino = NULL;
 	struct inode *inode;
-- 
1.9.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web