Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395722 > unrolled thread

[PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain He Kuang <hekuang@huawei.com> - 2016-05-06 11:10 +0200
    Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording  dwarf callchain Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-06 13:50 +0200
    Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording  dwarf callchain Jiri Olsa <jolsa@redhat.com> - 2016-05-07 20:10 +0200
      Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording  dwarf callchain Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-09 18:20 +0200
        Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf  callchain Hekuang <hekuang@huawei.com> - 2016-05-10 03:50 +0200
    [tip:perf/core] perf callchain: Recording 'dwarf' callchains do not  need DWARF unwinding support tip-bot for He Kuang <tipbot@zytor.com> - 2016-05-10 22:40 +0200

#1395722 — [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain

There's no need for dwarf support when perf recording with callchain.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
 tools/perf/util/util.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index b7766c5..e5ebfd4 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
 				       "needed for --call-graph fp\n");
 			break;
 
-#ifdef HAVE_DWARF_UNWIND_SUPPORT
 		/* Dwarf style */
 		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
 			const unsigned long default_stack_dump_size = 8192;
@@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
 				ret = get_stack_size(tok, &size);
 				param->dump_size = size;
 			}
-#endif /* HAVE_DWARF_UNWIND_SUPPORT */
 		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
 			if (!strtok_r(NULL, ",", &saveptr)) {
 				param->record_mode = CALLCHAIN_LBR;
-- 
1.8.5.2

[toc] | [next] | [standalone]

#1395799 — Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain

Em Fri, May 06, 2016 at 08:59:07AM +0000, He Kuang escreveu:
> There's no need for dwarf support when perf recording with callchain.

Can you rewrite this? We do need to have support for dwarf when
processing "dwarf style" callchains.

- Arnaldo
 
> Signed-off-by: He Kuang <hekuang@huawei.com>
> ---
>  tools/perf/util/util.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index b7766c5..e5ebfd4 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>  				       "needed for --call-graph fp\n");
>  			break;
>  
> -#ifdef HAVE_DWARF_UNWIND_SUPPORT
>  		/* Dwarf style */
>  		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
>  			const unsigned long default_stack_dump_size = 8192;
> @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>  				ret = get_stack_size(tok, &size);
>  				param->dump_size = size;
>  			}
> -#endif /* HAVE_DWARF_UNWIND_SUPPORT */
>  		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
>  			if (!strtok_r(NULL, ",", &saveptr)) {
>  				param->record_mode = CALLCHAIN_LBR;
> -- 
> 1.8.5.2

[toc] | [prev] | [next] | [standalone]

#1396339 — Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain

On Fri, May 06, 2016 at 08:59:07AM +0000, He Kuang wrote:
> There's no need for dwarf support when perf recording with callchain.
> 
> Signed-off-by: He Kuang <hekuang@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
>  tools/perf/util/util.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index b7766c5..e5ebfd4 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>  				       "needed for --call-graph fp\n");
>  			break;
>  
> -#ifdef HAVE_DWARF_UNWIND_SUPPORT
>  		/* Dwarf style */
>  		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
>  			const unsigned long default_stack_dump_size = 8192;
> @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>  				ret = get_stack_size(tok, &size);
>  				param->dump_size = size;
>  			}
> -#endif /* HAVE_DWARF_UNWIND_SUPPORT */
>  		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
>  			if (!strtok_r(NULL, ",", &saveptr)) {
>  				param->record_mode = CALLCHAIN_LBR;
> -- 
> 1.8.5.2
> 

[toc] | [prev] | [next] | [standalone]

#1397162 — Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain

Em Sat, May 07, 2016 at 08:03:46PM +0200, Jiri Olsa escreveu:
> On Fri, May 06, 2016 at 08:59:07AM +0000, He Kuang wrote:
> > There's no need for dwarf support when perf recording with callchain.
> > 
> > Signed-off-by: He Kuang <hekuang@huawei.com>
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Ok, due to your Ack I went on to read the code and indeed, with this
changeset description:

"There is no need to check for DWARF unwinding support when using the
'dwarf' callchain record method, as this will only ask the kernel to
collect stack dumps for later DWARF CFI processing, which can be done
in another machine, where the support for DWARF unwinding need to be
present."

Thanks,

- Arnaldo
 
> thanks,
> jirka
> 
> > ---
> >  tools/perf/util/util.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> > index b7766c5..e5ebfd4 100644
> > --- a/tools/perf/util/util.c
> > +++ b/tools/perf/util/util.c
> > @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
> >  				       "needed for --call-graph fp\n");
> >  			break;
> >  
> > -#ifdef HAVE_DWARF_UNWIND_SUPPORT
> >  		/* Dwarf style */
> >  		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
> >  			const unsigned long default_stack_dump_size = 8192;
> > @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
> >  				ret = get_stack_size(tok, &size);
> >  				param->dump_size = size;
> >  			}
> > -#endif /* HAVE_DWARF_UNWIND_SUPPORT */
> >  		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
> >  			if (!strtok_r(NULL, ",", &saveptr)) {
> >  				param->record_mode = CALLCHAIN_LBR;
> > -- 
> > 1.8.5.2
> > 

[toc] | [prev] | [next] | [standalone]

#1397637 — Re: [PATCH 1/8] perf tools: Omit DWARF judgement when recording dwarf callchain

ok

在 2016/5/10 0:16, Arnaldo Carvalho de Melo 写道:
> Em Sat, May 07, 2016 at 08:03:46PM +0200, Jiri Olsa escreveu:
>> On Fri, May 06, 2016 at 08:59:07AM +0000, He Kuang wrote:
>>> There's no need for dwarf support when perf recording with callchain.
>>>
>>> Signed-off-by: He Kuang <hekuang@huawei.com>
>> Acked-by: Jiri Olsa <jolsa@kernel.org>
> Ok, due to your Ack I went on to read the code and indeed, with this
> changeset description:
>
> "There is no need to check for DWARF unwinding support when using the
> 'dwarf' callchain record method, as this will only ask the kernel to
> collect stack dumps for later DWARF CFI processing, which can be done
> in another machine, where the support for DWARF unwinding need to be
> present."
>
> Thanks,
>
> - Arnaldo
>   
>> thanks,
>> jirka
>>
>>> ---
>>>   tools/perf/util/util.c | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
>>> index b7766c5..e5ebfd4 100644
>>> --- a/tools/perf/util/util.c
>>> +++ b/tools/perf/util/util.c
>>> @@ -471,7 +471,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>>>   				       "needed for --call-graph fp\n");
>>>   			break;
>>>   
>>> -#ifdef HAVE_DWARF_UNWIND_SUPPORT
>>>   		/* Dwarf style */
>>>   		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
>>>   			const unsigned long default_stack_dump_size = 8192;
>>> @@ -487,7 +486,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
>>>   				ret = get_stack_size(tok, &size);
>>>   				param->dump_size = size;
>>>   			}
>>> -#endif /* HAVE_DWARF_UNWIND_SUPPORT */
>>>   		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
>>>   			if (!strtok_r(NULL, ",", &saveptr)) {
>>>   				param->record_mode = CALLCHAIN_LBR;
>>> -- 
>>> 1.8.5.2
>>>

[toc] | [prev] | [next] | [standalone]

#1398509 — [tip:perf/core] perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support

Commit-ID:  841e3558b2de6d8c53dae4f01c7a81cd53e42e5c
Gitweb:     http://git.kernel.org/tip/841e3558b2de6d8c53dae4f01c7a81cd53e42e5c
Author:     He Kuang <hekuang@huawei.com>
AuthorDate: Fri, 6 May 2016 08:59:07 +0000
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 9 May 2016 13:29:36 -0300

perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support

There is no need to check for DWARF unwinding support when using the
'dwarf' callchain record method, as this will only ask the kernel to
collect stack dumps for later DWARF CFI processing, which can be done in
another machine, where the support for DWARF unwinding need to be
present.

Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1462525154-125656-2-git-send-email-hekuang@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/util.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 619ba20..01c9433 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -507,7 +507,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
 				       "needed for --call-graph fp\n");
 			break;
 
-#ifdef HAVE_DWARF_UNWIND_SUPPORT
 		/* Dwarf style */
 		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
 			const unsigned long default_stack_dump_size = 8192;
@@ -523,7 +522,6 @@ int parse_callchain_record(const char *arg, struct callchain_param *param)
 				ret = get_stack_size(tok, &size);
 				param->dump_size = size;
 			}
-#endif /* HAVE_DWARF_UNWIND_SUPPORT */
 		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
 			if (!strtok_r(NULL, ",", &saveptr)) {
 				param->record_mode = CALLCHAIN_LBR;

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web