Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1397254 > unrolled thread

[PATCH] drivers/acpi: make evged.c explicitly non-modular

Back to article view | Back to linux.kernel

Contents

  [PATCH] drivers/acpi: make evged.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-05-09 20:50 +0200
    Re: [PATCH] drivers/acpi: make evged.c explicitly non-modular Sinan Kaya <okaya@codeaurora.org> - 2016-05-09 21:40 +0200
      Re: [PATCH] drivers/acpi: make evged.c explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-05-09 22:00 +0200
        Re: [PATCH] drivers/acpi: make evged.c explicitly non-modular "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-11 02:10 +0200

#1397254 — [PATCH] drivers/acpi: make evged.c explicitly non-modular

The Makefile/Kconfig currently controlling compilation of this code is:

Makefile:acpi-$(CONFIG_ACPI_REDUCED_HARDWARE_ONLY) += evged.o

drivers/acpi/Kconfig:config ACPI_REDUCED_HARDWARE_ONLY
drivers/acpi/Kconfig:   bool "Hardware-reduced ACPI support only" if EXPERT

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading the
code there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

The file wasn't explicitly including the module.h file but it did
already have init.h so, unlike similar changes, this one has no
header changes at all.

We also delete the MODULE_LICENSE tag since all that information
is already contained at the top of the file in the comments.

Cc: Sinan Kaya <okaya@codeaurora.org>
c: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/acpi/evged.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c
index 9c0a868d7b57..46f060356a22 100644
--- a/drivers/acpi/evged.c
+++ b/drivers/acpi/evged.c
@@ -151,6 +151,4 @@ static struct platform_driver ged_driver = {
 		.acpi_match_table = ACPI_PTR(ged_acpi_ids),
 	},
 };
-
-module_platform_driver(ged_driver);
-MODULE_LICENSE("GPL v2");
+builtin_platform_driver(ged_driver);
-- 
2.8.0

[toc] | [next] | [standalone]

#1397272

+Rafael,

On 5/9/2016 2:40 PM, Paul Gortmaker wrote:
> The Makefile/Kconfig currently controlling compilation of this code is:
> 
> Makefile:acpi-$(CONFIG_ACPI_REDUCED_HARDWARE_ONLY) += evged.o
> 
> -
> -module_platform_driver(ged_driver);
> -MODULE_LICENSE("GPL v2");
> +builtin_platform_driver(ged_driver);
> 

Thanks, it looks good to me. I realized Rafael was missing in your post.
I added him here.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1397292

[Re: [PATCH] drivers/acpi: make evged.c explicitly non-modular] On 09/05/2016 (Mon 15:35) Sinan Kaya wrote:

> +Rafael,
> 
> On 5/9/2016 2:40 PM, Paul Gortmaker wrote:
> > The Makefile/Kconfig currently controlling compilation of this code is:
> > 
> > Makefile:acpi-$(CONFIG_ACPI_REDUCED_HARDWARE_ONLY) += evged.o
> > 
> > -
> > -module_platform_driver(ged_driver);
> > -MODULE_LICENSE("GPL v2");
> > +builtin_platform_driver(ged_driver);
> > 
> 
> Thanks, it looks good to me. I realized Rafael was missing in your post.
> I added him here.

Thanks for spotting that.  It looks like I fat fingered his "Cc:" line
into a "c:" at some point and I didn't notice his name was absent when
git gave me the summary of recipients before hitting send.  :-(

Would have been nice if git send-email had given me a warning, but I
guess there are so many different non-stanadard headers out there now,
it would be impossible to assume "c:" wasn't valid for someone....

P.
--

> 
> -- 
> Sinan Kaya
> Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1398595

On Monday, May 09, 2016 03:59:29 PM Paul Gortmaker wrote:
> [Re: [PATCH] drivers/acpi: make evged.c explicitly non-modular] On 09/05/2016 (Mon 15:35) Sinan Kaya wrote:
> 
> > +Rafael,
> > 
> > On 5/9/2016 2:40 PM, Paul Gortmaker wrote:
> > > The Makefile/Kconfig currently controlling compilation of this code is:
> > > 
> > > Makefile:acpi-$(CONFIG_ACPI_REDUCED_HARDWARE_ONLY) += evged.o
> > > 
> > > -
> > > -module_platform_driver(ged_driver);
> > > -MODULE_LICENSE("GPL v2");
> > > +builtin_platform_driver(ged_driver);
> > > 
> > 
> > Thanks, it looks good to me. I realized Rafael was missing in your post.
> > I added him here.
> 
> Thanks for spotting that.  It looks like I fat fingered his "Cc:" line
> into a "c:" at some point and I didn't notice his name was absent when
> git gave me the summary of recipients before hitting send.  :-(
> 
> Would have been nice if git send-email had given me a warning, but I
> guess there are so many different non-stanadard headers out there now,
> it would be impossible to assume "c:" wasn't valid for someone....

No worries.

If it goes to linux-acpi@vger.kernel.org, I can find it.

Patch applied, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web