Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1396994 > unrolled thread
| Started by | William Wu <william.wu@rock-chips.com> |
|---|---|
| First post | 2016-05-09 14:10 +0200 |
| Last post | 2016-05-09 15:40 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu <william.wu@rock-chips.com> - 2016-05-09 14:10 +0200
Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug Greg KH <gregkh@linuxfoundation.org> - 2016-05-09 14:10 +0200
Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug Felipe Balbi <balbi@kernel.org> - 2016-05-09 14:20 +0200
Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu <william.wu@rock-chips.com> - 2016-05-09 15:30 +0200
Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug Felipe Balbi <balbi@kernel.org> - 2016-05-09 15:40 +0200
| From | William Wu <william.wu@rock-chips.com> |
|---|---|
| Date | 2016-05-09 14:10 +0200 |
| Subject | [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug |
| Message-ID | <rwSaD-5og-49@gated-at.bofh.it> |
Signed-off-by: William Wu <william.wu@rock-chips.com>
---
drivers/usb/dwc3/core.h | 1 +
drivers/usb/dwc3/debugfs.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index e15e307..f268869 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -86,6 +86,7 @@
#define DWC3_GCTL 0xc110
#define DWC3_GEVTEN 0xc114
#define DWC3_GSTS 0xc118
+#define DWC3_GUCTL1 0xc11c
#define DWC3_GSNPSID 0xc120
#define DWC3_GGPIO 0xc124
#define DWC3_GUID 0xc128
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index b1dd3c6..f3c9f44 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
dump_register(GCTL),
dump_register(GEVTEN),
dump_register(GSTS),
+ dump_register(GUCTL1),
dump_register(GSNPSID),
dump_register(GGPIO),
dump_register(GUID),
--
1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-09 14:10 +0200 |
| Message-ID | <rwSaD-5og-51@gated-at.bofh.it> |
| In reply to | #1396994 |
On Mon, May 09, 2016 at 08:00:05PM +0800, William Wu wrote: > Signed-off-by: William Wu <william.wu@rock-chips.com> We can't take patches with no changelog text at all, sorry. Please explain why you are doing what you are doing in the changelog text. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Date | 2016-05-09 14:20 +0200 |
| Message-ID | <rwSki-5t9-15@gated-at.bofh.it> |
| In reply to | #1396994 |
[Multipart message — attachments visible in raw view] — view raw
William Wu <william.wu@rock-chips.com> writes:
> Signed-off-by: William Wu <william.wu@rock-chips.com>
no changelog = no commit, sorry. Why do you want to dump GUCTL1?
> ---
> drivers/usb/dwc3/core.h | 1 +
> drivers/usb/dwc3/debugfs.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index e15e307..f268869 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -86,6 +86,7 @@
> #define DWC3_GCTL 0xc110
> #define DWC3_GEVTEN 0xc114
> #define DWC3_GSTS 0xc118
> +#define DWC3_GUCTL1 0xc11c
> #define DWC3_GSNPSID 0xc120
> #define DWC3_GGPIO 0xc124
> #define DWC3_GUID 0xc128
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index b1dd3c6..f3c9f44 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
> dump_register(GCTL),
> dump_register(GEVTEN),
> dump_register(GSTS),
> + dump_register(GUCTL1),
> dump_register(GSNPSID),
> dump_register(GGPIO),
> dump_register(GUID),
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
[toc] | [prev] | [next] | [standalone]
| From | William Wu <william.wu@rock-chips.com> |
|---|---|
| Date | 2016-05-09 15:30 +0200 |
| Message-ID | <rwTq3-6rS-35@gated-at.bofh.it> |
| In reply to | #1397001 |
On 05/09/2016 08:10 PM, Felipe Balbi wrote:
> William Wu <william.wu@rock-chips.com> writes:
Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to
add changelog.
>> Signed-off-by: William Wu <william.wu@rock-chips.com>
> no changelog = no commit, sorry. Why do you want to dump GUCTL1?
Because GUCTL1 can be written by user. For rockchip platform,
we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in
bootrom(used for usb2.0 device only),
and after kernel boot, I want to check whether this bit can be
reset to default 0 after core reset.
Dump GUCTL1 reg from debugfs is more convenient for me.
>
>> ---
>> drivers/usb/dwc3/core.h | 1 +
>> drivers/usb/dwc3/debugfs.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index e15e307..f268869 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -86,6 +86,7 @@
>> #define DWC3_GCTL 0xc110
>> #define DWC3_GEVTEN 0xc114
>> #define DWC3_GSTS 0xc118
>> +#define DWC3_GUCTL1 0xc11c
>> #define DWC3_GSNPSID 0xc120
>> #define DWC3_GGPIO 0xc124
>> #define DWC3_GUID 0xc128
>> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
>> index b1dd3c6..f3c9f44 100644
>> --- a/drivers/usb/dwc3/debugfs.c
>> +++ b/drivers/usb/dwc3/debugfs.c
>> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>> dump_register(GCTL),
>> dump_register(GEVTEN),
>> dump_register(GSTS),
>> + dump_register(GUCTL1),
>> dump_register(GSNPSID),
>> dump_register(GGPIO),
>> dump_register(GUID),
>> --
>> 1.9.1
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Date | 2016-05-09 15:40 +0200 |
| Message-ID | <rwTzJ-6w5-33@gated-at.bofh.it> |
| In reply to | #1397055 |
[Multipart message — attachments visible in raw view] — view raw
William Wu <william.wu@rock-chips.com> writes: > On 05/09/2016 08:10 PM, Felipe Balbi wrote: >> William Wu <william.wu@rock-chips.com> writes: > Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to > add changelog. >>> Signed-off-by: William Wu <william.wu@rock-chips.com> >> no changelog = no commit, sorry. Why do you want to dump GUCTL1? > Because GUCTL1 can be written by user. For rockchip platform, > we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in > bootrom(used for usb2.0 device only), > and after kernel boot, I want to check whether this bit can be > reset to default 0 after core reset. > Dump GUCTL1 reg from debugfs is more convenient for me. cool, something like this could go to commit log :-) -- balbi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web