Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395258 > unrolled thread
| Started by | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| First post | 2016-05-05 20:00 +0200 |
| Last post | 2016-05-05 20:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] block: partition: use RCU_INIT_POINTER() for NULLing. Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-05-05 20:00 +0200
Re: [PATCH] block: partition: use RCU_INIT_POINTER() for NULLing. Muhammad Falak R Wani <falakreyaz@gmail.com> - 2016-05-05 20:40 +0200
Re: [PATCH] block: partition: use RCU_INIT_POINTER() for NULLing. Christoph Hellwig <hch@infradead.org> - 2016-05-05 20:40 +0200
| From | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| Date | 2016-05-05 20:00 +0200 |
| Subject | [PATCH] block: partition: use RCU_INIT_POINTER() for NULLing. |
| Message-ID | <rvvJ8-4je-13@gated-at.bofh.it> |
It is safe to use RCU_INIT_POINTER() to NULL, instead of rcu_assign_pointer(). This results in slightly smaller/faster code. Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> --- block/partition-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/partition-generic.c b/block/partition-generic.c index 2c6ae2a..e5219d5 100644 --- a/block/partition-generic.c +++ b/block/partition-generic.c @@ -262,8 +262,8 @@ void delete_partition(struct gendisk *disk, int partno) if (!part) return; - rcu_assign_pointer(ptbl->part[partno], NULL); - rcu_assign_pointer(ptbl->last_lookup, NULL); + RCU_INIT_POINTER(ptbl->part[partno], NULL); + RCU_INIT_POINTER(ptbl->last_lookup, NULL); kobject_put(part->holder_dir); device_del(part_to_dev(part)); -- 1.9.1
[toc] | [next] | [standalone]
| From | Muhammad Falak R Wani <falakreyaz@gmail.com> |
|---|---|
| Date | 2016-05-05 20:40 +0200 |
| Message-ID | <rvwlP-5gq-9@gated-at.bofh.it> |
| In reply to | #1395258 |
On Thu, May 05, 2016 at 11:31:19AM -0700, Christoph Hellwig wrote: > On Thu, May 05, 2016 at 11:24:06PM +0530, Muhammad Falak R Wani wrote: > > It is safe to use RCU_INIT_POINTER() to NULL, instead of > > rcu_assign_pointer(). > > This results in slightly smaller/faster code. > > > > Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> > > Muhammad, > > please stop sending these patches. They make the code less reusbale, > and we (or rather Paul) are working on making rcu_assign_pointer do > the right thing. Sorry, my bad! Wont send any of these now. I just thought it might be the right thing to do, till the time Paul et al make it do the right thing. -mfrw
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Date | 2016-05-05 20:40 +0200 |
| Message-ID | <rvwlP-5gq-11@gated-at.bofh.it> |
| In reply to | #1395258 |
On Thu, May 05, 2016 at 11:24:06PM +0530, Muhammad Falak R Wani wrote: > It is safe to use RCU_INIT_POINTER() to NULL, instead of > rcu_assign_pointer(). > This results in slightly smaller/faster code. > > Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> Muhammad, please stop sending these patches. They make the code less reusbale, and we (or rather Paul) are working on making rcu_assign_pointer do the right thing.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web