Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1395092 > unrolled thread

Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

Started byJan Kara <jack@suse.cz>
First post2016-05-05 15:00 +0200
Last post2016-05-05 17:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] ext4: Fix check of dqget() return value in  ext4_ioctl_setproject() Jan Kara <jack@suse.cz> - 2016-05-05 15:00 +0200
    Re: [PATCH] ext4: Fix check of dqget() return value in  ext4_ioctl_setproject() tytso@mit.edu - 2016-05-05 17:00 +0200

#1395092 — Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

FromJan Kara <jack@suse.cz>
Date2016-05-05 15:00 +0200
SubjectRe: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()
Message-ID<rvr2O-bc-9@gated-at.bofh.it>
On Fri 22-04-16 13:36:32, Seth Forshee wrote:
> On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote:
> > A failed call to dqget() returns an ERR_PTR() and not null. Fix
> > the check in ext4_ioctl_setproject() to handle this correctly.
> > 
> > Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
> > Cc: stable@vger.kernel.org # v4.5
> > Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> 
> Thought I'd check and see if this patch was forgotten, I sent it nearly
> a month ago but the bug is still present.

Yeah, it seems Ted forgot to pull the fix. Ted? BTW, feel free to add

Reviewed-by: Jan Kara <jack@suse.cz>

									Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

[toc] | [next] | [standalone]


#1395167

Fromtytso@mit.edu
Date2016-05-05 17:00 +0200
Message-ID<rvsUW-1Mr-19@gated-at.bofh.it>
In reply to#1395092
On Thu, May 05, 2016 at 02:52:34PM +0200, Jan Kara wrote:
> On Fri 22-04-16 13:36:32, Seth Forshee wrote:
> > On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote:
> > > A failed call to dqget() returns an ERR_PTR() and not null. Fix
> > > the check in ext4_ioctl_setproject() to handle this correctly.
> > > 
> > > Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
> > > Cc: stable@vger.kernel.org # v4.5
> > > Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> > 
> > Thought I'd check and see if this patch was forgotten, I sent it nearly
> > a month ago but the bug is still present.
> 
> Yeah, it seems Ted forgot to pull the fix. Ted? BTW, feel free to add
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Applied, thanks.

						- Ted

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web