Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1394660 > unrolled thread

[PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-04 21:30 +0200
    Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE,  DMA_CYCLIC Vinod Koul <vinod.koul@intel.com> - 2016-05-10 18:00 +0200
      Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE,  DMA_CYCLIC Vinod Koul <vinod.koul@intel.com> - 2016-05-10 18:10 +0200
      Re: [PATCH v1 1/2] dmaengine: slave means at least one of  DMA_SLAVE, DMA_CYCLIC Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-10 18:10 +0200

#1394660 — [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC

When check for capabilities recognize slave support by eother DMA_SLAVE or
DMA_CYCLIC bit set. If we don't do that the user can't get a normally worked
DMA support for engines that doesn't have one of the mentioned bits set.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/dmaengine.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 5ff79a0..59eb4fa 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -482,8 +482,8 @@ int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
 	device = chan->device;
 
 	/* check if the channel supports slave transactions */
-	if ((!test_bit(DMA_SLAVE, device->cap_mask.bits)) ||
-			(!test_bit(DMA_CYCLIC, device->cap_mask.bits)))
+	if (!(test_bit(DMA_SLAVE, device->cap_mask.bits) ||
+	      test_bit(DMA_CYCLIC, device->cap_mask.bits)))
 		return -ENXIO;
 
 	/*
-- 
2.8.1

[toc] | [next] | [standalone]

#1398270 — Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC

On Wed, May 04, 2016 at 10:29:39PM +0300, Andy Shevchenko wrote:
> When check for capabilities recognize slave support by eother DMA_SLAVE or
							^^^^^^^
typo

> DMA_CYCLIC bit set. If we don't do that the user can't get a normally worked
> DMA support for engines that doesn't have one of the mentioned bits set.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/dma/dmaengine.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index 5ff79a0..59eb4fa 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -482,8 +482,8 @@ int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
>  	device = chan->device;
>  
>  	/* check if the channel supports slave transactions */
> -	if ((!test_bit(DMA_SLAVE, device->cap_mask.bits)) ||
> -			(!test_bit(DMA_CYCLIC, device->cap_mask.bits)))
> +	if (!(test_bit(DMA_SLAVE, device->cap_mask.bits) ||
> +	      test_bit(DMA_CYCLIC, device->cap_mask.bits)))
>  		return -ENXIO;
>  
>  	/*
> -- 
> 2.8.1
> 

-- 
~Vinod

[toc] | [prev] | [next] | [standalone]

#1398277 — Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC

On Tue, May 10, 2016 at 07:01:03PM +0300, Andy Shevchenko wrote:
> On Tue, 2016-05-10 at 21:26 +0530, Vinod Koul wrote:
> > On Wed, May 04, 2016 at 10:29:39PM +0300, Andy Shevchenko wrote:
> > > 
> > > When check for capabilities recognize slave support by eother
> > > DMA_SLAVE or
> > 							^^^^^^^
> > typo
> 
> Indeed, thanks.
> Do I need to resend this one?

Yes please.

Also instead of OR, AND will do the same, but your approach works too, so
either way am fine..

And I do not get correlation with fix on patch 1. This should be independent
change..


-- 
~Vinod

[toc] | [prev] | [next] | [standalone]

#1398283 — Re: [PATCH v1 1/2] dmaengine: slave means at least one of DMA_SLAVE, DMA_CYCLIC

On Tue, 2016-05-10 at 21:26 +0530, Vinod Koul wrote:
> On Wed, May 04, 2016 at 10:29:39PM +0300, Andy Shevchenko wrote:
> > 
> > When check for capabilities recognize slave support by eother
> > DMA_SLAVE or
> 							^^^^^^^
> typo

Indeed, thanks.
Do I need to resend this one?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web