Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395545 > unrolled thread

[PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes

Started byNishanth Menon <nm@ti.com>
First post2016-05-06 02:40 +0200
Last post2016-05-06 21:10 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes Nishanth Menon <nm@ti.com> - 2016-05-06 02:40 +0200
    [PATCH 4/4] regulator: tps65917/palmas: Simplify multiple dereference of match->of_node Nishanth Menon <nm@ti.com> - 2016-05-06 02:40 +0200
      Applied "regulator: tps65917/palmas: Simplify multiple dereference of match->of_node" to the regulator tree Mark Brown <broonie@kernel.org> - 2016-05-06 19:20 +0200
    Re: [PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-06 09:30 +0200
      Re: [PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes Mark Brown <broonie@kernel.org> - 2016-05-06 19:20 +0200
        Re: [PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes Nishanth Menon <nm@ti.com> - 2016-05-06 21:10 +0200

#1395545 — [PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes

FromNishanth Menon <nm@ti.com>
Date2016-05-06 02:40 +0200
Subject[PATCH 0/4] regulator: tps65917/palmas: Cleanups and bugfixes
Message-ID<rvBYe-2li-33@gated-at.bofh.it>
While attempting to try and get each of the regulator nodes of palmas
to be capable of using vin-supply, I noticed a few cleanups and
associated bug fixes.

The series is based on next-20160504 and is split up to aid
readability of the patch.

Tested on OMAP5-uevm and DRA7 platform.

Nishanth Menon (4):
  regulator: tps65917/palmas: Simplify multiple dereference of
    ddata->palmas_matches[idx]
  regulator: tps65917/palmas: Simplify multiple dereference of
    pdata->reg_init[idx]
  regulator: tps65917/palmas: Handle possible memory allocation failure
  regulator: tps65917/palmas: Simplify multiple dereference of
    match->of_node

 drivers/regulator/palmas-regulator.c | 62 +++++++++++++++++++-----------------
 1 file changed, 33 insertions(+), 29 deletions(-)

-- 
2.8.0

[toc] | [next] | [standalone]

#1395552 — [PATCH 4/4] regulator: tps65917/palmas: Simplify multiple dereference of match->of_node

FromNishanth Menon <nm@ti.com>
Date2016-05-06 02:40 +0200
Subject[PATCH 4/4] regulator: tps65917/palmas: Simplify multiple dereference of match->of_node
Message-ID<rvBYg-2li-79@gated-at.bofh.it>
In reply to#1395545
Just dereference match->of_node once instead of using match->of_node.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 drivers/regulator/palmas-regulator.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index faa389be7ca3..f11d41dad9c1 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -1493,10 +1493,12 @@ static int palmas_dt_to_pdata(struct device *dev,
 	for (idx = 0; idx < ddata->max_reg; idx++) {
 		static struct of_regulator_match *match;
 		struct palmas_reg_init *rinit;
+		struct device_node *np;
 
 		match = &ddata->palmas_matches[idx];
+		np = match->of_node;
 
-		if (!match->init_data || !match->of_node)
+		if (!match->init_data || !np)
 			continue;
 
 		rinit = devm_kzalloc(dev, sizeof(*rinit), GFP_KERNEL);
@@ -1506,11 +1508,8 @@ static int palmas_dt_to_pdata(struct device *dev,
 		pdata->reg_data[idx] = match->init_data;
 		pdata->reg_init[idx] = rinit;
 
-		rinit->warm_reset = of_property_read_bool(match->of_node,
-							  "ti,warm-reset");
-
-		ret = of_property_read_u32(match->of_node, "ti,roof-floor",
-					   &prop);
+		rinit->warm_reset = of_property_read_bool(np, "ti,warm-reset");
+		ret = of_property_read_u32(np, "ti,roof-floor", &prop);
 		/* EINVAL: Property not found */
 		if (ret != -EINVAL) {
 			int econtrol;
@@ -1539,19 +1538,17 @@ static int palmas_dt_to_pdata(struct device *dev,
 			rinit->roof_floor = econtrol;
 		}
 
-		ret = of_property_read_u32(match->of_node, "ti,mode-sleep",
-					   &prop);
+		ret = of_property_read_u32(np, "ti,mode-sleep", &prop);
 		if (!ret)
 			rinit->mode_sleep = prop;
 
-		ret = of_property_read_bool(match->of_node, "ti,smps-range");
+		ret = of_property_read_bool(np, "ti,smps-range");
 		if (ret)
 			rinit->vsel = PALMAS_SMPS12_VOLTAGE_RANGE;
 
 		if (idx == PALMAS_REG_LDO8)
 			pdata->enable_ldo8_tracking = of_property_read_bool(
-						match->of_node,
-						"ti,enable-ldo8-tracking");
+						np, "ti,enable-ldo8-tracking");
 	}
 
 	pdata->ldo6_vibrator = of_property_read_bool(node, "ti,ldo6-vibrator");
-- 
2.8.0

[toc] | [prev] | [next] | [standalone]

#1395985 — Applied "regulator: tps65917/palmas: Simplify multiple dereference of match->of_node" to the regulator tree

FromMark Brown <broonie@kernel.org>
Date2016-05-06 19:20 +0200
SubjectApplied "regulator: tps65917/palmas: Simplify multiple dereference of match->of_node" to the regulator tree
Message-ID<rvRzY-UE-3@gated-at.bofh.it>
In reply to#1395552
The patch

   regulator: tps65917/palmas: Simplify multiple dereference of match->of_node

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 6c7d614fa22d32d038b5a6e88d71acb2711e7035 Mon Sep 17 00:00:00 2001
From: Nishanth Menon <nm@ti.com>
Date: Thu, 5 May 2016 19:29:52 -0500
Subject: [PATCH] regulator: tps65917/palmas: Simplify multiple dereference of
 match->of_node

Just dereference match->of_node once instead of using match->of_node.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/palmas-regulator.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index faa389be7ca3..f11d41dad9c1 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -1493,10 +1493,12 @@ static int palmas_dt_to_pdata(struct device *dev,
 	for (idx = 0; idx < ddata->max_reg; idx++) {
 		static struct of_regulator_match *match;
 		struct palmas_reg_init *rinit;
+		struct device_node *np;
 
 		match = &ddata->palmas_matches[idx];
+		np = match->of_node;
 
-		if (!match->init_data || !match->of_node)
+		if (!match->init_data || !np)
 			continue;
 
 		rinit = devm_kzalloc(dev, sizeof(*rinit), GFP_KERNEL);
@@ -1506,11 +1508,8 @@ static int palmas_dt_to_pdata(struct device *dev,
 		pdata->reg_data[idx] = match->init_data;
 		pdata->reg_init[idx] = rinit;
 
-		rinit->warm_reset = of_property_read_bool(match->of_node,
-							  "ti,warm-reset");
-
-		ret = of_property_read_u32(match->of_node, "ti,roof-floor",
-					   &prop);
+		rinit->warm_reset = of_property_read_bool(np, "ti,warm-reset");
+		ret = of_property_read_u32(np, "ti,roof-floor", &prop);
 		/* EINVAL: Property not found */
 		if (ret != -EINVAL) {
 			int econtrol;
@@ -1539,19 +1538,17 @@ static int palmas_dt_to_pdata(struct device *dev,
 			rinit->roof_floor = econtrol;
 		}
 
-		ret = of_property_read_u32(match->of_node, "ti,mode-sleep",
-					   &prop);
+		ret = of_property_read_u32(np, "ti,mode-sleep", &prop);
 		if (!ret)
 			rinit->mode_sleep = prop;
 
-		ret = of_property_read_bool(match->of_node, "ti,smps-range");
+		ret = of_property_read_bool(np, "ti,smps-range");
 		if (ret)
 			rinit->vsel = PALMAS_SMPS12_VOLTAGE_RANGE;
 
 		if (idx == PALMAS_REG_LDO8)
 			pdata->enable_ldo8_tracking = of_property_read_bool(
-						match->of_node,
-						"ti,enable-ldo8-tracking");
+						np, "ti,enable-ldo8-tracking");
 	}
 
 	pdata->ldo6_vibrator = of_property_read_bool(node, "ti,ldo6-vibrator");
-- 
2.8.1

[toc] | [prev] | [next] | [standalone]

#1395660

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-05-06 09:30 +0200
Message-ID<rvIn0-P0-17@gated-at.bofh.it>
In reply to#1395545
Hi Nishanth,

On Friday 06 May 2016 05:59 AM, Nishanth Menon wrote:
> While attempting to try and get each of the regulator nodes of palmas
> to be capable of using vin-supply, I noticed a few cleanups and
> associated bug fixes.
>
> The series is based on next-20160504 and is split up to aid
> readability of the patch.
>
> Tested on OMAP5-uevm and DRA7 platform.
>

When you are here, can you implement the dt parsing with the new method 
from regulator framework.
Regulator FW calls callback to parse customized DT property, just need 
to pass the node and pointer when registering.

This will helps lots in cleanups and readability.

[toc] | [prev] | [next] | [standalone]

#1395986

FromMark Brown <broonie@kernel.org>
Date2016-05-06 19:20 +0200
Message-ID<rvRzY-UE-5@gated-at.bofh.it>
In reply to#1395660

[Multipart message — attachments visible in raw view] — view raw

On Fri, May 06, 2016 at 12:44:23PM +0530, Laxman Dewangan wrote:

> When you are here, can you implement the dt parsing with the new method from
> regulator framework.
> Regulator FW calls callback to parse customized DT property, just need to
> pass the node and pointer when registering.

> This will helps lots in cleanups and readability.

Yes, please.

[toc] | [prev] | [next] | [standalone]

#1396074

FromNishanth Menon <nm@ti.com>
Date2016-05-06 21:10 +0200
Message-ID<rvTir-2p0-23@gated-at.bofh.it>
In reply to#1395986
On 05/06/2016 12:14 PM, Mark Brown wrote:
> On Fri, May 06, 2016 at 12:44:23PM +0530, Laxman Dewangan wrote:
> 
>> When you are here, can you implement the dt parsing with the new method from
>> regulator framework.
>> Regulator FW calls callback to parse customized DT property, just need to
>> pass the node and pointer when registering.
> 
>> This will helps lots in cleanups and readability.
> 
> Yes, please.
> 
yeah, the driver has started showing it's age, it will be good to do a
refactor.

-- 
Regards,
Nishanth Menon

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web