Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395560 > unrolled thread

linux-next: build failure after merge of the sound-asoc tree

Back to article view | Back to linux.kernel

Contents

  linux-next: build failure after merge of the sound-asoc tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-05-06 03:00 +0200
    RE: linux-next: build failure after merge of the sound-asoc tree "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-05-06 11:50 +0200
      Re: linux-next: build failure after merge of the sound-asoc tree Mark Brown <broonie@kernel.org> - 2016-05-06 14:10 +0200
        RE: linux-next: build failure after merge of the sound-asoc tree "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2016-05-06 15:40 +0200

#1395560 — linux-next: build failure after merge of the sound-asoc tree

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:

sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function 'ACPI_PTR' [-Werror=implicit-function-declaration]
   .acpi_match_table = ACPI_PTR(da7219_acpi_match),
                       ^
sound/soc/codecs/da7219.c:1964:23: error: initializer element is not constant
sound/soc/codecs/da7219.c:1964:23: note: (near initialization for 'da7219_i2c_driver.driver.acpi_match_table')

Caused by commit

  5181365f5312 ("ASoC: da7219: Add initial ACPI id for device")

I added this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 6 May 2016 10:52:45 +1000
Subject: [PATCH] ASoC: da7219: include acpi.h for ACPI_PTR

Fixed: 5181365f5312 ("ASoC: da7219: Add initial ACPI id for device")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/soc/codecs/da7219.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index 17e2119f211b..1d9f4ff4355a 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -20,6 +20,7 @@
 #include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/regulator/consumer.h>
+#include <linux/acpi.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1395743

On May 06, 2016, 01:58, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function
> 'ACPI_PTR' [-Werror=implicit-function-declaration]
>    .acpi_match_table = ACPI_PTR(da7219_acpi_match),
>                        ^
> sound/soc/codecs/da7219.c:1964:23: error: initializer element is not constant
> sound/soc/codecs/da7219.c:1964:23: note: (near initialization for
> 'da7219_i2c_driver.driver.acpi_match_table')
> 
> Caused by commit
> 
>   5181365f5312 ("ASoC: da7219: Add initial ACPI id for device")
> 
> I added this patch for today:

This patch was the 3rd in of a set of 3, and the header you added below was
added as part of the 2nd patch of that set, hence why it is missing here. I
assume the first 2 patches are still being reviewed by Mark.

[toc] | [prev] | [next] | [standalone]

#1395816

[Multipart message — attachments visible in raw view] — view raw

On Fri, May 06, 2016 at 09:48:51AM +0000, Opensource [Adam Thomson] wrote:

> This patch was the 3rd in of a set of 3, and the header you added below was
> added as part of the 2nd patch of that set, hence why it is missing here. I
> assume the first 2 patches are still being reviewed by Mark.

Yes.  The ID patch should have been the first one here, put the simple
stuff first.

[toc] | [prev] | [next] | [standalone]

#1395870

On May 06, 2016, 13:03, Mark Brown wrote:

> > This patch was the 3rd in of a set of 3, and the header you added below was
> > added as part of the 2nd patch of that set, hence why it is missing here. I
> > assume the first 2 patches are still being reviewed by Mark.
> 
> Yes.  The ID patch should have been the first one here, put the simple
> stuff first.

In my mind it makes sense to only add this after support to use it is in place
in the driver, hence the ordering.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web