Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1394326 > unrolled thread
| Started by | David Wu <david.wu@rock-chips.com> |
|---|---|
| First post | 2016-05-04 16:20 +0200 |
| Last post | 2016-05-06 01:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v7 3/9] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd() David Wu <david.wu@rock-chips.com> - 2016-05-04 16:20 +0200
Re: [PATCH v7 3/9] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd() Doug Anderson <dianders@chromium.org> - 2016-05-06 01:00 +0200
| From | David Wu <david.wu@rock-chips.com> |
|---|---|
| Date | 2016-05-04 16:20 +0200 |
| Subject | [PATCH v7 3/9] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd() |
| Message-ID | <rv5OG-5wR-7@gated-at.bofh.it> |
Call rk3x_i2c_setup() before rk3x_i2c_start()
and the last thing in setup was to clean the IPD,
so no reason to do it at the beginning of start.
Signed-off-by: David Wu <david.wu@rock-chips.com>
---
Change in v7:
- none
drivers/i2c/busses/i2c-rk3x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index 1e2677a..9eeb4e5 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -174,7 +174,6 @@ static void rk3x_i2c_start(struct rk3x_i2c *i2c)
{
u32 val;
- rk3x_i2c_clean_ipd(i2c);
i2c_writel(i2c, REG_INT_START, REG_IEN);
/* enable adapter with correct mode, send START condition */
--
1.9.1
[toc] | [next] | [standalone]
| From | Doug Anderson <dianders@chromium.org> |
|---|---|
| Date | 2016-05-06 01:00 +0200 |
| Message-ID | <rvAps-Kj-15@gated-at.bofh.it> |
| In reply to | #1394326 |
David, On Wed, May 4, 2016 at 7:13 AM, David Wu <david.wu@rock-chips.com> wrote: > Call rk3x_i2c_setup() before rk3x_i2c_start() > and the last thing in setup was to clean the IPD, > so no reason to do it at the beginning of start. > > Signed-off-by: David Wu <david.wu@rock-chips.com> > --- > Change in v7: > - none > > drivers/i2c/busses/i2c-rk3x.c | 1 - > 1 file changed, 1 deletion(-) Looks great. Thanks for splitting this out from other patches--makes it much more obvious what's happening! :) IMHO this can be applied any time independent of any earlier patches. Reviewed-by: Douglas Anderson <dianders@chromium.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web