Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1392547 > unrolled thread

Re: [tip:perf/urgent] perf hists: Fix determination of a callchain node's childlessness

Started byGreg KH <greg@kroah.com>
First post2016-05-03 00:20 +0200
Last post2016-05-03 01:40 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [tip:perf/urgent] perf hists: Fix determination of a callchain  node's childlessness Greg KH <greg@kroah.com> - 2016-05-03 00:20 +0200
    Re: [tip:perf/urgent] perf hists: Fix determination of a callchain  node's childlessness Andres Freund <andres@anarazel.de> - 2016-05-03 00:30 +0200
      Re: [tip:perf/urgent] perf hists: Fix determination of a callchain  node's childlessness Greg KH <greg@kroah.com> - 2016-05-03 01:30 +0200
        Re: [tip:perf/urgent] perf hists: Fix determination of a callchain  node's childlessness Andres Freund <andres@anarazel.de> - 2016-05-03 01:40 +0200

#1392547 — Re: [tip:perf/urgent] perf hists: Fix determination of a callchain node's childlessness

FromGreg KH <greg@kroah.com>
Date2016-05-03 00:20 +0200
SubjectRe: [tip:perf/urgent] perf hists: Fix determination of a callchain node's childlessness
Message-ID<ruum5-3JE-3@gated-at.bofh.it>
On Mon, Apr 18, 2016 at 07:25:22AM -0700, Andres Freund wrote:
> Hi,
> 
> Perhaps the patch quoted below should also go into stable? It'd be nice
> to fix that regression for 4.4 and 4.5.  It's been integrated into 4.6
> (909890355).

How is it a regression in 4.4, as the commit involved didn't show up
until 4.5?

confused,

greg k-h

[toc] | [next] | [standalone]


#1392550

FromAndres Freund <andres@anarazel.de>
Date2016-05-03 00:30 +0200
Message-ID<ruuvL-3RN-5@gated-at.bofh.it>
In reply to#1392547
Hi,

On 2016-05-02 15:17:54 -0700, Greg KH wrote:
> On Mon, Apr 18, 2016 at 07:25:22AM -0700, Andres Freund wrote:
> > Hi,
> > 
> > Perhaps the patch quoted below should also go into stable? It'd be nice
> > to fix that regression for 4.4 and 4.5.  It's been integrated into 4.6
> > (909890355).
> 
> How is it a regression in 4.4, as the commit involved didn't show up
> until 4.5?
> 
> confused,

Sorry for that, I'd used git describe on the commit to determine which
branch it was contained in (outputting v4.3-1188-g4b3a321). That
obviously doesn't make sense though, as that just returns the state of
the tree at which 4b3a3212233a was introduced, not the commit it was
merged into mainline.


Andres

[toc] | [prev] | [next] | [standalone]


#1392565

FromGreg KH <greg@kroah.com>
Date2016-05-03 01:30 +0200
Message-ID<ruvrP-4Nt-1@gated-at.bofh.it>
In reply to#1392550
On Mon, May 02, 2016 at 03:25:25PM -0700, Andres Freund wrote:
> Hi,
> 
> On 2016-05-02 15:17:54 -0700, Greg KH wrote:
> > On Mon, Apr 18, 2016 at 07:25:22AM -0700, Andres Freund wrote:
> > > Hi,
> > > 
> > > Perhaps the patch quoted below should also go into stable? It'd be nice
> > > to fix that regression for 4.4 and 4.5.  It's been integrated into 4.6
> > > (909890355).
> > 
> > How is it a regression in 4.4, as the commit involved didn't show up
> > until 4.5?
> > 
> > confused,
> 
> Sorry for that, I'd used git describe on the commit to determine which
> branch it was contained in (outputting v4.3-1188-g4b3a321). That
> obviously doesn't make sense though, as that just returns the state of
> the tree at which 4b3a3212233a was introduced, not the commit it was
> merged into mainline.

I have an alias in my .gitconfig:
[alias]
	dc = describe --contains

which is what you need here:
	$ git dc 4b3a3212233a
	v4.5-rc1~171^2~43^2~3

hope this helps,

greg k-h

[toc] | [prev] | [next] | [standalone]


#1392567

FromAndres Freund <andres@anarazel.de>
Date2016-05-03 01:40 +0200
Message-ID<ruvBw-4Uv-11@gated-at.bofh.it>
In reply to#1392565
Hi,

On 2016-05-02 16:24:08 -0700, Greg KH wrote:
> On Mon, May 02, 2016 at 03:25:25PM -0700, Andres Freund wrote:
> > On 2016-05-02 15:17:54 -0700, Greg KH wrote:
> > Sorry for that, I'd used git describe on the commit to determine which
> > branch it was contained in (outputting v4.3-1188-g4b3a321). That
> > obviously doesn't make sense though, as that just returns the state of
> > the tree at which 4b3a3212233a was introduced, not the commit it was
> > merged into mainline.
> 
> I have an alias in my .gitconfig:
> [alias]
> 	dc = describe --contains
> 
> which is what you need here:
> 	$ git dc 4b3a3212233a
> 	v4.5-rc1~171^2~43^2~3
> 
> hope this helps,

Ah, perfect. Thanks. I made do with git tag --contains, but that's
awfully slow; describe --contains is a lot faster.


Andres

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web