Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1392262 > unrolled thread
| Started by | Christoph Hellwig <hch@infradead.org> |
|---|---|
| First post | 2016-05-02 17:00 +0200 |
| Last post | 2016-05-03 03:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 2/3] fs: direct-io: call .bi_end_io via bio_endio() Christoph Hellwig <hch@infradead.org> - 2016-05-02 17:00 +0200
Re: [PATCH v3 2/3] fs: direct-io: call .bi_end_io via bio_endio() Ming Lei <ming.lei@canonical.com> - 2016-05-03 03:30 +0200
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Date | 2016-05-02 17:00 +0200 |
| Subject | Re: [PATCH v3 2/3] fs: direct-io: call .bi_end_io via bio_endio() |
| Message-ID | <runuj-5gi-21@gated-at.bofh.it> |
On Thu, Apr 28, 2016 at 09:09:48AM +0800, Ming Lei wrote:
> bio_endio() is the graceful way to complete one bio.
>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
> fs/direct-io.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index a8dd60a..0a35e51 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -350,15 +350,10 @@ static void dio_bio_end_io(struct bio *bio)
> */
> void dio_end_io(struct bio *bio, int error)
> {
> - struct dio *dio = bio->bi_private;
> -
> if (!bio->bi_error)
> bio->bi_error = error;
>
> - if (dio->is_async)
> - dio_bio_end_aio(bio);
> - else
> - dio_bio_end_io(bio);
> + bio_endio(bio);
> }
> EXPORT_SYMBOL_GPL(dio_end_io);
dio_end_io is only used by btrfs. So instead of this and the previous
patch you should just open code the error assignment and call to
bio_endio in btrfs.
[toc] | [next] | [standalone]
| From | Ming Lei <ming.lei@canonical.com> |
|---|---|
| Date | 2016-05-03 03:30 +0200 |
| Message-ID | <ruxjX-6Ia-7@gated-at.bofh.it> |
| In reply to | #1392262 |
On Mon, May 2, 2016 at 10:50 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Apr 28, 2016 at 09:09:48AM +0800, Ming Lei wrote:
>> bio_endio() is the graceful way to complete one bio.
>
>
>
>>
>> Signed-off-by: Ming Lei <ming.lei@canonical.com>
>> ---
>> fs/direct-io.c | 7 +------
>> 1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/fs/direct-io.c b/fs/direct-io.c
>> index a8dd60a..0a35e51 100644
>> --- a/fs/direct-io.c
>> +++ b/fs/direct-io.c
>> @@ -350,15 +350,10 @@ static void dio_bio_end_io(struct bio *bio)
>> */
>> void dio_end_io(struct bio *bio, int error)
>> {
>> - struct dio *dio = bio->bi_private;
>> -
>> if (!bio->bi_error)
>> bio->bi_error = error;
>>
>> - if (dio->is_async)
>> - dio_bio_end_aio(bio);
>> - else
>> - dio_bio_end_io(bio);
>> + bio_endio(bio);
>> }
>> EXPORT_SYMBOL_GPL(dio_end_io);
>
> dio_end_io is only used by btrfs. So instead of this and the previous
> patch you should just open code the error assignment and call to
> bio_endio in btrfs.
OK.
Thanks,
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web