Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1394008 > unrolled thread

[patch] [SCSI] eata_pio: missing break statement

Started byDan Carpenter <dan.carpenter@oracle.com>
First post2016-05-04 08:20 +0200
Last post2016-05-11 04:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [patch] [SCSI] eata_pio: missing break statement Dan Carpenter <dan.carpenter@oracle.com> - 2016-05-04 08:20 +0200
    Re: [patch] [SCSI] eata_pio: missing break statement "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-05-11 04:10 +0200

#1394008 — [patch] [SCSI] eata_pio: missing break statement

FromDan Carpenter <dan.carpenter@oracle.com>
Date2016-05-04 08:20 +0200
Subject[patch] [SCSI] eata_pio: missing break statement
Message-ID<ruYk9-6UF-3@gated-at.bofh.it>
This missing break statement bug predates git.  It's a very minor thing,
it means that we print a '?' instead of a 'z' in dmesg.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c
index ca8003f..4299fa4 100644
--- a/drivers/scsi/eata_pio.c
+++ b/drivers/scsi/eata_pio.c
@@ -729,6 +729,7 @@ static int register_pio_HBA(long base, struct get_conf *gc, struct pci_dev *pdev
 		break;
 	case 0x24:
 		SD(sh)->EATA_revision = 'z';
+		break;
 	default:
 		SD(sh)->EATA_revision = '?';
 	}

[toc] | [next] | [standalone]


#1398633

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2016-05-11 04:10 +0200
Message-ID<rxrL3-714-7@gated-at.bofh.it>
In reply to#1394008
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:

Dan> This missing break statement bug predates git.  It's a very minor
Dan> thing, it means that we print a '?' instead of a 'z' in dmesg.

Applied to 4.7/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web