Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1393805 > unrolled thread

[PATCH] infoleak fix1 in timer

Back to article view | Back to linux.kernel

Contents

  [PATCH] infoleak fix1 in timer Kangjie Lu <kangjielu@gmail.com> - 2016-05-03 22:50 +0200
    Re: [PATCH] infoleak fix1 in timer Takashi Iwai <tiwai@suse.de> - 2016-05-08 11:40 +0200

#1393805 — [PATCH] infoleak fix1 in timer

The stack object “tread” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
 sound/core/timer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/core/timer.c b/sound/core/timer.c
index 6469bed..964f5eb 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1739,6 +1739,7 @@ static int snd_timer_user_params(struct file *file,
 	if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
 		if (tu->tread) {
 			struct snd_timer_tread tread;
+			memset(&tread, 0, sizeof(tread));
 			tread.event = SNDRV_TIMER_EVENT_EARLY;
 			tread.tstamp.tv_sec = 0;
 			tread.tstamp.tv_nsec = 0;
-- 
1.9.1

[toc] | [next] | [standalone]

#1396405

On Tue, 03 May 2016 22:44:07 +0200,
Kangjie Lu wrote:
> 
> The stack object “tread” has a total size of 32 bytes. Its field
> “event” and “val” both contain 4 bytes padding. These 8 bytes
> padding bytes are sent to user without being initialized.
> 
> Signed-off-by: Kangjie Lu <kjlu@gatech.edu>

Thanks, I applied now all three patches.  But I rephrased the subjects
to more meaningful ones.  Better to give a bit more informative
subject line at the next time.


Takashi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web