Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393651 > unrolled thread
| Started by | Andy Lutomirski <luto@kernel.org> |
|---|---|
| First post | 2016-05-03 19:40 +0200 |
| Last post | 2016-05-09 03:40 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/4] selftests/sigaltstack: Fix the sas test on old kernels Andy Lutomirski <luto@kernel.org> - 2016-05-03 19:40 +0200
[tip:core/signals] selftests/sigaltstack: Fix the sigaltstack test on old kernels tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-05-04 09:20 +0200
Re: [PATCH 2/4] selftests/sigaltstack: Fix the sas test on old kernels Stas Sergeev <stsp@list.ru> - 2016-05-07 17:10 +0200
Re: [PATCH 2/4] selftests/sigaltstack: Fix the sas test on old kernels Andy Lutomirski <luto@amacapital.net> - 2016-05-09 03:40 +0200
| From | Andy Lutomirski <luto@kernel.org> |
|---|---|
| Date | 2016-05-03 19:40 +0200 |
| Subject | [PATCH 2/4] selftests/sigaltstack: Fix the sas test on old kernels |
| Message-ID | <ruMsH-3Sd-31@gated-at.bofh.it> |
The handling for old kernels was wrong. Fix it.
Reported-by: Ingo Molnar <mingo@kernel.org>
Cc: Stas Sergeev <stsp@list.ru>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-api@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
tools/testing/selftests/sigaltstack/sas.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/sigaltstack/sas.c b/tools/testing/selftests/sigaltstack/sas.c
index 57da8bfde60b..a98c3ef8141f 100644
--- a/tools/testing/selftests/sigaltstack/sas.c
+++ b/tools/testing/selftests/sigaltstack/sas.c
@@ -15,6 +15,7 @@
#include <alloca.h>
#include <string.h>
#include <assert.h>
+#include <errno.h>
#ifndef SS_AUTODISARM
#define SS_AUTODISARM (1 << 4)
@@ -117,13 +118,19 @@ int main(void)
stk.ss_flags = SS_ONSTACK | SS_AUTODISARM;
err = sigaltstack(&stk, NULL);
if (err) {
- perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
- stk.ss_flags = SS_ONSTACK;
- }
- err = sigaltstack(&stk, NULL);
- if (err) {
- perror("[FAIL]\tsigaltstack(SS_ONSTACK)");
- return EXIT_FAILURE;
+ if (errno == EINVAL) {
+ printf("[NOTE]\tThe running kernel doesn't support SS_AUTODISARM\n");
+ /*
+ * If test cases for the !SS_AUTODISARM variant were
+ * added, we could still run them. We don't have any
+ * test cases like that yet, so just exit and report
+ * success.
+ */
+ return 0;
+ } else {
+ perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
+ return EXIT_FAILURE;
+ }
}
ustack = mmap(NULL, SIGSTKSZ, PROT_READ | PROT_WRITE,
--
2.5.5
[toc] | [next] | [standalone]
| From | tip-bot for Andy Lutomirski <tipbot@zytor.com> |
|---|---|
| Date | 2016-05-04 09:20 +0200 |
| Subject | [tip:core/signals] selftests/sigaltstack: Fix the sigaltstack test on old kernels |
| Message-ID | <ruZgf-7OK-37@gated-at.bofh.it> |
| In reply to | #1393651 |
Commit-ID: 158b67b5c5ccda9b909f18028a3cd17185ca1efd
Gitweb: http://git.kernel.org/tip/158b67b5c5ccda9b909f18028a3cd17185ca1efd
Author: Andy Lutomirski <luto@kernel.org>
AuthorDate: Tue, 3 May 2016 10:31:50 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 4 May 2016 08:34:13 +0200
selftests/sigaltstack: Fix the sigaltstack test on old kernels
The handling for old kernels was wrong, resulting in a segfault. Fix it.
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Stas Sergeev <stsp@list.ru>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-api@vger.kernel.org
Link: http://lkml.kernel.org/r/f3e739bf435beeaecbd5f038f1359d2eac6d1e63.1462296606.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
tools/testing/selftests/sigaltstack/sas.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/sigaltstack/sas.c b/tools/testing/selftests/sigaltstack/sas.c
index 57da8bf..a98c3ef 100644
--- a/tools/testing/selftests/sigaltstack/sas.c
+++ b/tools/testing/selftests/sigaltstack/sas.c
@@ -15,6 +15,7 @@
#include <alloca.h>
#include <string.h>
#include <assert.h>
+#include <errno.h>
#ifndef SS_AUTODISARM
#define SS_AUTODISARM (1 << 4)
@@ -117,13 +118,19 @@ int main(void)
stk.ss_flags = SS_ONSTACK | SS_AUTODISARM;
err = sigaltstack(&stk, NULL);
if (err) {
- perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
- stk.ss_flags = SS_ONSTACK;
- }
- err = sigaltstack(&stk, NULL);
- if (err) {
- perror("[FAIL]\tsigaltstack(SS_ONSTACK)");
- return EXIT_FAILURE;
+ if (errno == EINVAL) {
+ printf("[NOTE]\tThe running kernel doesn't support SS_AUTODISARM\n");
+ /*
+ * If test cases for the !SS_AUTODISARM variant were
+ * added, we could still run them. We don't have any
+ * test cases like that yet, so just exit and report
+ * success.
+ */
+ return 0;
+ } else {
+ perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
+ return EXIT_FAILURE;
+ }
}
ustack = mmap(NULL, SIGSTKSZ, PROT_READ | PROT_WRITE,
[toc] | [prev] | [next] | [standalone]
| From | Stas Sergeev <stsp@list.ru> |
|---|---|
| Date | 2016-05-07 17:10 +0200 |
| Subject | Re: [PATCH 2/4] selftests/sigaltstack: Fix the sas test on old kernels |
| Message-ID | <rwc1H-3H8-7@gated-at.bofh.it> |
| In reply to | #1393651 |
03.05.2016 20:31, Andy Lutomirski пишет:
> The handling for old kernels was wrong. Fix it.
>
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Cc: Stas Sergeev <stsp@list.ru>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Brian Gerst <brgerst@gmail.com>
> Cc: Denys Vlasenko <dvlasenk@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Pavel Emelyanov <xemul@parallels.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Shuah Khan <shuahkh@osg.samsung.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-api@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> tools/testing/selftests/sigaltstack/sas.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/sigaltstack/sas.c b/tools/testing/selftests/sigaltstack/sas.c
> index 57da8bfde60b..a98c3ef8141f 100644
> --- a/tools/testing/selftests/sigaltstack/sas.c
> +++ b/tools/testing/selftests/sigaltstack/sas.c
> @@ -15,6 +15,7 @@
> #include <alloca.h>
> #include <string.h>
> #include <assert.h>
> +#include <errno.h>
>
> #ifndef SS_AUTODISARM
> #define SS_AUTODISARM (1 << 4)
> @@ -117,13 +118,19 @@ int main(void)
> stk.ss_flags = SS_ONSTACK | SS_AUTODISARM;
> err = sigaltstack(&stk, NULL);
> if (err) {
> - perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
> - stk.ss_flags = SS_ONSTACK;
> - }
> - err = sigaltstack(&stk, NULL);
> - if (err) {
> - perror("[FAIL]\tsigaltstack(SS_ONSTACK)");
> - return EXIT_FAILURE;
> + if (errno == EINVAL) {
> + printf("[NOTE]\tThe running kernel doesn't support SS_AUTODISARM\n");
> + /*
> + * If test cases for the !SS_AUTODISARM variant were
> + * added, we could still run them. We don't have any
> + * test cases like that yet, so just exit and report
> + * success.
> + */
But that was the point, please see how it handles the
old kernels:
$ ./sas
[FAIL] sigaltstack(SS_ONSTACK | SS_AUTODISARM): Invalid argument
[RUN] signal USR1
[FAIL] ss_flags=1, should be SS_DISABLE
[RUN] switched to user ctx
[RUN] signal USR2
[FAIL] sigaltstack re-used
[FAIL] Stack corrupted
[RUN] Aborting
Unfortunalely, for Ingo it crashed...
I am not sure why, I can't reproduce. :(
So if you disable all the "old" tests, you can as well
remove them, or... find the bug and re-enable. :)
[toc] | [prev] | [next] | [standalone]
| From | Andy Lutomirski <luto@amacapital.net> |
|---|---|
| Date | 2016-05-09 03:40 +0200 |
| Message-ID | <rwIkW-1K9-7@gated-at.bofh.it> |
| In reply to | #1396313 |
On May 7, 2016 8:02 AM, "Stas Sergeev" <stsp@list.ru> wrote:
>
> 03.05.2016 20:31, Andy Lutomirski пишет:
>
>> The handling for old kernels was wrong. Fix it.
>>
>> Reported-by: Ingo Molnar <mingo@kernel.org>
>> Cc: Stas Sergeev <stsp@list.ru>
>> Cc: Al Viro <viro@zeniv.linux.org.uk>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Andy Lutomirski <luto@amacapital.net>
>> Cc: Borislav Petkov <bp@alien8.de>
>> Cc: Brian Gerst <brgerst@gmail.com>
>> Cc: Denys Vlasenko <dvlasenk@redhat.com>
>> Cc: H. Peter Anvin <hpa@zytor.com>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Cc: Oleg Nesterov <oleg@redhat.com>
>> Cc: Pavel Emelyanov <xemul@parallels.com>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Shuah Khan <shuahkh@osg.samsung.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: linux-api@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>> ---
>> tools/testing/selftests/sigaltstack/sas.c | 21 ++++++++++++++-------
>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>
>> diff --git a/tools/testing/selftests/sigaltstack/sas.c b/tools/testing/selftests/sigaltstack/sas.c
>> index 57da8bfde60b..a98c3ef8141f 100644
>> --- a/tools/testing/selftests/sigaltstack/sas.c
>> +++ b/tools/testing/selftests/sigaltstack/sas.c
>> @@ -15,6 +15,7 @@
>> #include <alloca.h>
>> #include <string.h>
>> #include <assert.h>
>> +#include <errno.h>
>> #ifndef SS_AUTODISARM
>> #define SS_AUTODISARM (1 << 4)
>> @@ -117,13 +118,19 @@ int main(void)
>> stk.ss_flags = SS_ONSTACK | SS_AUTODISARM;
>> err = sigaltstack(&stk, NULL);
>> if (err) {
>> - perror("[FAIL]\tsigaltstack(SS_ONSTACK | SS_AUTODISARM)");
>> - stk.ss_flags = SS_ONSTACK;
>> - }
>> - err = sigaltstack(&stk, NULL);
>> - if (err) {
>> - perror("[FAIL]\tsigaltstack(SS_ONSTACK)");
>> - return EXIT_FAILURE;
>> + if (errno == EINVAL) {
>> + printf("[NOTE]\tThe running kernel doesn't support SS_AUTODISARM\n");
>> + /*
>> + * If test cases for the !SS_AUTODISARM variant were
>> + * added, we could still run them. We don't have any
>> + * test cases like that yet, so just exit and report
>> + * success.
>> + */
>
> But that was the point, please see how it handles the
> old kernels:
>
> $ ./sas
> [FAIL] sigaltstack(SS_ONSTACK | SS_AUTODISARM): Invalid argument
> [RUN] signal USR1
> [FAIL] ss_flags=1, should be SS_DISABLE
> [RUN] switched to user ctx
> [RUN] signal USR2
> [FAIL] sigaltstack re-used
> [FAIL] Stack corrupted
> [RUN] Aborting
This is useful as a demonstration of why the feature is useful, but it
doesn't indicate that anything is wrong with old kernels per she.
That's why I changed it to simply report that the feature is missing.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web