Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393506 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-05-03 17:20 +0200 |
| Last post | 2016-05-09 23:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/3] HSI: omap-ssi: regressions against yesterday's linux-next Arnd Bergmann <arnd@arndb.de> - 2016-05-03 17:20 +0200
[PATCH 1/3] HSI: omap-ssi: add COMMON_CLK dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-03 17:20 +0200
Re: [PATCH 0/3] HSI: omap-ssi: regressions against yesterday's linux-next Sebastian Reichel <sre@kernel.org> - 2016-05-09 23:30 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-03 17:20 +0200 |
| Subject | [PATCH 0/3] HSI: omap-ssi: regressions against yesterday's linux-next |
| Message-ID | <ruKhb-1Y8-11@gated-at.bofh.it> |
Hi Sebastian,
One patch you added yesterday unfortunately caused (at least) three
separate build problems with 32-bit ARM randconfig builds.
These three patches should make it all work again.
Arnd
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-05-03 17:20 +0200 |
| Subject | [PATCH 1/3] HSI: omap-ssi: add COMMON_CLK dependency |
| Message-ID | <ruKhc-1Y8-25@gated-at.bofh.it> |
| In reply to | #1393506 |
Enabling the omap ssi driver without COMMON_CLK results in a build failure:
drivers/hsi/controllers/omap_ssi_core.c: In function 'ssi_clk_event':
drivers/hsi/controllers/omap_ssi_core.c:304:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
This adds a Kconfig dependency to avoid the invalid configuration.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4bcf7414528a ("HSI: omap-ssi: add clk change support")
---
drivers/hsi/controllers/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hsi/controllers/Kconfig b/drivers/hsi/controllers/Kconfig
index 084ec97eec64..48e4eda186cc 100644
--- a/drivers/hsi/controllers/Kconfig
+++ b/drivers/hsi/controllers/Kconfig
@@ -5,7 +5,8 @@ comment "HSI controllers"
config OMAP_SSI
tristate "OMAP SSI hardware driver"
- depends on HSI && OF && (ARCH_OMAP3 || (ARM && COMPILE_TEST))
+ depends on HSI && OF && ARM && COMMON_CLK
+ depends on ARCH_OMAP3 || COMPILE_TEST
---help---
SSI is a legacy version of HSI. It is usually used to connect
an application engine with a cellular modem.
--
2.7.0
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-05-09 23:30 +0200 |
| Subject | Re: [PATCH 0/3] HSI: omap-ssi: regressions against yesterday's linux-next |
| Message-ID | <rx0Uy-5md-1@gated-at.bofh.it> |
| In reply to | #1393506 |
[Multipart message — attachments visible in raw view] — view raw
Hi Arnd, On Tue, May 03, 2016 at 05:16:19PM +0200, Arnd Bergmann wrote: > One patch you added yesterday unfortunately caused (at least) three > separate build problems with 32-bit ARM randconfig builds. > > These three patches should make it all work again. Sorry for the delayed respones, I was on vacation last week and asked Stephen to temp. disable the HSI tree. I just applied all patches and asked him to reenable it. -- Sebastian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web