Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1391865 > unrolled thread
| Started by | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| First post | 2016-05-01 22:40 +0200 |
| Last post | 2016-05-04 16:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 05/13] iio: health/afe440x: Fix scan_index assignment "Andrew F. Davis" <afd@ti.com> - 2016-05-01 22:40 +0200
Re: [PATCH 05/13] iio: health/afe440x: Fix scan_index assignment Jonathan Cameron <jic23@kernel.org> - 2016-05-04 16:50 +0200
| From | "Andrew F. Davis" <afd@ti.com> |
|---|---|
| Date | 2016-05-01 22:40 +0200 |
| Subject | [PATCH 05/13] iio: health/afe440x: Fix scan_index assignment |
| Message-ID | <ru6jM-7pJ-1@gated-at.bofh.it> |
The LED channels are not scannable and so scan_index should
be negative, fix this here.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
drivers/iio/health/afe440x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health/afe440x.h
index 544bbab..583d071 100644
--- a/drivers/iio/health/afe440x.h
+++ b/drivers/iio/health/afe440x.h
@@ -125,7 +125,7 @@ struct afe440x_reg_info {
.type = IIO_CURRENT, \
.channel = _index, \
.address = _index, \
- .scan_index = _index, \
+ .scan_index = -1, \
.extend_name = _name, \
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
BIT(IIO_CHAN_INFO_SCALE), \
--
2.8.1
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-05-04 16:50 +0200 |
| Message-ID | <rv6hI-5S0-9@gated-at.bofh.it> |
| In reply to | #1391865 |
On 01/05/16 21:36, Andrew F. Davis wrote:
> The LED channels are not scannable and so scan_index should
> be negative, fix this here.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
Good point. I've applied this to the togreg branch, but if
you want me to push this one out as a fix it definitely qualifies.
Jonathan
> ---
> drivers/iio/health/afe440x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health/afe440x.h
> index 544bbab..583d071 100644
> --- a/drivers/iio/health/afe440x.h
> +++ b/drivers/iio/health/afe440x.h
> @@ -125,7 +125,7 @@ struct afe440x_reg_info {
> .type = IIO_CURRENT, \
> .channel = _index, \
> .address = _index, \
> - .scan_index = _index, \
> + .scan_index = -1, \
> .extend_name = _name, \
> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> BIT(IIO_CHAN_INFO_SCALE), \
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web