Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1391402 > unrolled thread

Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components

Started byDave Hansen <dave.hansen@linux.intel.com>
First post2016-04-29 22:30 +0200
Last post2016-04-30 00:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for  legacy components Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-29 22:30 +0200
    Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes  for legacy components Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-04-30 00:20 +0200
      Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for  legacy components Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-30 00:20 +0200
        Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes  for legacy components Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-04-30 00:30 +0200

#1391402 — Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components

FromDave Hansen <dave.hansen@linux.intel.com>
Date2016-04-29 22:30 +0200
SubjectRe: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components
Message-ID<rtnd0-3HL-29@gated-at.bofh.it>
On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
> The arrays xstate_offsets[] and xstate_sizes[] record XSAVE area 
> offsets and sizes. Values for legacy components i387 and XMMs were
> not initialized. Fix it.

Is this just a completeness thing or does it actually break something?

In any case:

Reviewed-by: Dave Hansen <dave.hansen@intel.com>

[toc] | [next] | [standalone]


#1391491 — Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components

FromYu-cheng Yu <yu-cheng.yu@intel.com>
Date2016-04-30 00:20 +0200
SubjectRe: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components
Message-ID<rtoVs-5lW-11@gated-at.bofh.it>
In reply to#1391402
On Fri, Apr 29, 2016 at 01:28:31PM -0700, Dave Hansen wrote:
> On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
> > The arrays xstate_offsets[] and xstate_sizes[] record XSAVE area 
> > offsets and sizes. Values for legacy components i387 and XMMs were
> > not initialized. Fix it.
> 
> Is this just a completeness thing or does it actually break something?

PTRACE format conversion needs them.

[toc] | [prev] | [next] | [standalone]


#1391492

FromDave Hansen <dave.hansen@linux.intel.com>
Date2016-04-30 00:20 +0200
Message-ID<rtoVs-5lW-9@gated-at.bofh.it>
In reply to#1391491
On 04/29/2016 03:07 PM, Yu-cheng Yu wrote:
> On Fri, Apr 29, 2016 at 01:28:31PM -0700, Dave Hansen wrote:
>> On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
>>> The arrays xstate_offsets[] and xstate_sizes[] record XSAVE area 
>>> offsets and sizes. Values for legacy components i387 and XMMs were
>>> not initialized. Fix it.
>>
>> Is this just a completeness thing or does it actually break something?
> 
> PTRACE format conversion needs them.

If you respin these, can you please note that in the changelog and/or
comments?

[toc] | [prev] | [next] | [standalone]


#1391495 — Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components

FromYu-cheng Yu <yu-cheng.yu@intel.com>
Date2016-04-30 00:30 +0200
SubjectRe: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components
Message-ID<rtp58-5rQ-1@gated-at.bofh.it>
In reply to#1391492
On Fri, Apr 29, 2016 at 03:13:33PM -0700, Dave Hansen wrote:
> On 04/29/2016 03:07 PM, Yu-cheng Yu wrote:
> > On Fri, Apr 29, 2016 at 01:28:31PM -0700, Dave Hansen wrote:
> >> On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
> >>> The arrays xstate_offsets[] and xstate_sizes[] record XSAVE area 
> >>> offsets and sizes. Values for legacy components i387 and XMMs were
> >>> not initialized. Fix it.
> >>
> >> Is this just a completeness thing or does it actually break something?
> > 
> > PTRACE format conversion needs them.
> 
> If you respin these, can you please note that in the changelog and/or
> comments?

Do you mean when it is rebased?  I will do that.
  

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web