Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1391380 > unrolled thread
| Started by | Sebastian Reichel <sre@kernel.org> |
|---|---|
| First post | 2016-04-29 22:10 +0200 |
| Last post | 2016-05-02 22:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: Nokia N900 retention mode in v4.6, camera buttons fun Sebastian Reichel <sre@kernel.org> - 2016-04-29 22:10 +0200
Re: Nokia N900 retention mode in v4.6, camera buttons fun Pavel Machek <pavel@ucw.cz> - 2016-05-01 11:00 +0200
Re: Nokia N900 retention mode in v4.6, camera buttons fun Sebastian Reichel <sre@kernel.org> - 2016-05-01 17:50 +0200
Re: Nokia N900 retention mode in v4.6, camera buttons fun Sebastian Reichel <sre@kernel.org> - 2016-05-02 22:20 +0200
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-04-29 22:10 +0200 |
| Subject | Re: Nokia N900 retention mode in v4.6, camera buttons fun |
| Message-ID | <rtmTE-3yl-27@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Thu, Apr 21, 2016 at 03:04:50PM +0200, Pali Rohár wrote: > > CONFIG_HSI breaks power management completely, so power management > > with modem will be another topic. > > Sebastian, any idea why power management does not work for HSI? I wasn't aware, that pm_runtime_irq_safe() basically breaks runtime PM until Tony's fix for musb (even though it's logical when thinking about it). Currently omap-ssi and omap-ssi-port make use of pm_runtime_irq_safe(). Since pm_runtime_get_sync/pm_runtime_put_sync is called from tasklets in omap-ssi (and omap-ssi-port) it cannot be simply removed. So fixing PM for the ssi controller requires reworking the driver in a non trivial way. -- Sebastian
[toc] | [next] | [standalone]
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2016-05-01 11:00 +0200 |
| Message-ID | <rtVom-6wL-5@gated-at.bofh.it> |
| In reply to | #1391380 |
On Fri 2016-04-29 22:06:00, Sebastian Reichel wrote: > Hi, > > On Thu, Apr 21, 2016 at 03:04:50PM +0200, Pali Rohár wrote: > > > CONFIG_HSI breaks power management completely, so power management > > > with modem will be another topic. > > > > Sebastian, any idea why power management does not work for HSI? > > I wasn't aware, that pm_runtime_irq_safe() basically breaks runtime > PM until Tony's fix for musb (even though it's logical when thinking > about it). Currently omap-ssi and omap-ssi-port make use of > pm_runtime_irq_safe(). > > Since pm_runtime_get_sync/pm_runtime_put_sync is called from > tasklets in omap-ssi (and omap-ssi-port) it cannot be simply > removed. So fixing PM for the ssi controller requires reworking > the driver in a non trivial way. I see latest series, and it also talks about frequency scaling. But I guess it is not going to fix this issue? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-05-01 17:50 +0200 |
| Message-ID | <ru1N7-3nL-5@gated-at.bofh.it> |
| In reply to | #1391775 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Sun, May 01, 2016 at 10:52:36AM +0200, Pavel Machek wrote: > On Fri 2016-04-29 22:06:00, Sebastian Reichel wrote: > > On Thu, Apr 21, 2016 at 03:04:50PM +0200, Pali Rohár wrote: > > > > CONFIG_HSI breaks power management completely, so power management > > > > with modem will be another topic. > > > > > > Sebastian, any idea why power management does not work for HSI? > > > > I wasn't aware, that pm_runtime_irq_safe() basically breaks runtime > > PM until Tony's fix for musb (even though it's logical when thinking > > about it). Currently omap-ssi and omap-ssi-port make use of > > pm_runtime_irq_safe(). > > > > Since pm_runtime_get_sync/pm_runtime_put_sync is called from > > tasklets in omap-ssi (and omap-ssi-port) it cannot be simply > > removed. So fixing PM for the ssi controller requires reworking > > the driver in a non trivial way. > > I see latest series, and it also talks about frequency scaling. But I > guess it is not going to fix this issue? No, this is independent of the runtime PM problems. I also worked on runtime PM/idling yesterday and pm_runtime_irq_safe is the main culprit for breaking it (not the only one, though). It's not yet finished though -- Sebastian
[toc] | [prev] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2016-05-02 22:20 +0200 |
| Message-ID | <rustY-1Jl-3@gated-at.bofh.it> |
| In reply to | #1391833 |
[Multipart message — attachments visible in raw view] — view raw
Hi Pavel, On Sun, May 01, 2016 at 05:48:56PM +0200, Sebastian Reichel wrote: > > I see latest series, and it also talks about frequency scaling. > > But I guess it is not going to fix this issue? > > No, this is independent of the runtime PM problems. I also worked > on runtime PM/idling yesterday and pm_runtime_irq_safe is the main > culprit for breaking it (not the only one, though). It's not yet > finished though I will be on vacation for a week starting tomorrow. If you want to play around with my intermediate SSI PM status, you can try this branch: https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/log/?h=runtime-pm-fixes -- Sebastian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web