Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391279 > unrolled thread

Re: [PATCH v2] devpts: Make ptmx be owned by the userns owner as a fallback

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] devpts: Make ptmx be owned by the userns owner as a fallback Andy Lutomirski <luto@amacapital.net> - 2016-04-29 18:30 +0200

#1391279 — Re: [PATCH v2] devpts: Make ptmx be owned by the userns owner as a fallback

On Tue, Mar 15, 2016 at 1:05 PM, Andy Lutomirski <luto@kernel.org> wrote:
> New devpts instances have ptmx owned by the inner uid and gid 0.
>
> For container-style namespaces (LXC, etc), this should have no
> effect, this is fine.
>
> For sandbox-style namespaces (xdg-app and similar), this is
> problematic -- there may not be an inner 0:0.  If that happens,
> devpts mounts will fail.
>
> Fix it by adding a fallback: if 0:0 is not mapped but the userns
> owner and group are mapped, then ptmx will be owned by the namespace
> owner.
>
> This won't change behavior except in cases where mount would
> currently return -EINVAL.

Eric, this patch is straightforward, fixes a real problem, and is
mostly orthogonal to the devpts stuff you're working on.  Could you
apply it for 4.7?

--Andy

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web