Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390133 > unrolled thread

[PATCH] Revert "drm/omap: no need to select OMAP2_DSS"

Back to article view | Back to linux.kernel

Contents

  [PATCH] Revert "drm/omap: no need to select OMAP2_DSS" Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-04-28 14:50 +0200
    Re: [PATCH] Revert "drm/omap: no need to select OMAP2_DSS" Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-04-29 14:20 +0200

#1390133 — [PATCH] Revert "drm/omap: no need to select OMAP2_DSS"

This reverts commit 1c278e5e3718d15475ec08ee2135f37a6b13361c.

If DRM_OMAP does not select OMAP2_DSS it is possible to build a kernel with
DRM_OMAP only and not selecting OMAP2_DSS. Since omapdrm depends on
OMAP2_DSS this will result on broken kernel build.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/gpu/drm/omapdrm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
index 73241c4eb7aa..336ad4de9981 100644
--- a/drivers/gpu/drm/omapdrm/Kconfig
+++ b/drivers/gpu/drm/omapdrm/Kconfig
@@ -2,6 +2,7 @@ config DRM_OMAP
 	tristate "OMAP DRM"
 	depends on DRM
 	depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
+	select OMAP2_DSS
 	select DRM_KMS_HELPER
 	select DRM_KMS_FB_HELPER
 	select FB_SYS_FILLRECT
-- 
2.8.1

[toc] | [next] | [standalone]

#1391050

[Multipart message — attachments visible in raw view] — view raw

On 28/04/16 15:42, Peter Ujfalusi wrote:
> This reverts commit 1c278e5e3718d15475ec08ee2135f37a6b13361c.
> 
> If DRM_OMAP does not select OMAP2_DSS it is possible to build a kernel with
> DRM_OMAP only and not selecting OMAP2_DSS. Since omapdrm depends on
> OMAP2_DSS this will result on broken kernel build.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/gpu/drm/omapdrm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 73241c4eb7aa..336ad4de9981 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -2,6 +2,7 @@ config DRM_OMAP
>  	tristate "OMAP DRM"
>  	depends on DRM
>  	depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
> +	select OMAP2_DSS
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_FB_HELPER
>  	select FB_SYS_FILLRECT
> 

Thanks, queued for 4.7.

 Tomi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web