Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1391032 > unrolled thread
| Started by | Geert Uytterhoeven <geert+renesas@glider.be> |
|---|---|
| First post | 2016-04-29 13:50 +0200 |
| Last post | 2016-04-29 15:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Geert Uytterhoeven <geert+renesas@glider.be> - 2016-04-29 13:50 +0200
Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Richard Genoud <richard.genoud@gmail.com> - 2016-04-29 15:20 +0200
Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Yegor Yefremov <yegorslists@googlemail.com> - 2016-04-29 15:30 +0200
| From | Geert Uytterhoeven <geert+renesas@glider.be> |
|---|---|
| Date | 2016-04-29 13:50 +0200 |
| Subject | [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios |
| Message-ID | <rtf5N-5f6-11@gated-at.bofh.it> |
The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs.
It doesn't make much sense to emulate GPIOs using other GPIOs, hence
drop support for that.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
---
v2:
- Add Reviewed-by,
- Drop forgotten UART_GPIO_OUT[12] enum values.
---
drivers/tty/serial/serial_mctrl_gpio.c | 2 --
drivers/tty/serial/serial_mctrl_gpio.h | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
index 02147361eaa94747..821ffa637eb630cb 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.c
+++ b/drivers/tty/serial/serial_mctrl_gpio.c
@@ -43,8 +43,6 @@ static const struct {
{ "rng", TIOCM_RNG, false, },
{ "rts", TIOCM_RTS, true, },
{ "dtr", TIOCM_DTR, true, },
- { "out1", TIOCM_OUT1, true, },
- { "out2", TIOCM_OUT2, true, },
};
void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
index bcfad5d1db61decf..332a33ab0647cbe3 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.h
+++ b/drivers/tty/serial/serial_mctrl_gpio.h
@@ -32,8 +32,6 @@ enum mctrl_gpio_idx {
UART_GPIO_RI = UART_GPIO_RNG,
UART_GPIO_RTS,
UART_GPIO_DTR,
- UART_GPIO_OUT1,
- UART_GPIO_OUT2,
UART_GPIO_MAX,
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Richard Genoud <richard.genoud@gmail.com> |
|---|---|
| Date | 2016-04-29 15:20 +0200 |
| Message-ID | <rtguT-6Au-13@gated-at.bofh.it> |
| In reply to | #1391032 |
2016-04-29 13:40 GMT+02:00 Geert Uytterhoeven <geert+renesas@glider.be>:
> The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs.
> It doesn't make much sense to emulate GPIOs using other GPIOs, hence
> drop support for that.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> v2:
> - Add Reviewed-by,
> - Drop forgotten UART_GPIO_OUT[12] enum values.
> ---
> drivers/tty/serial/serial_mctrl_gpio.c | 2 --
> drivers/tty/serial/serial_mctrl_gpio.h | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index 02147361eaa94747..821ffa637eb630cb 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -43,8 +43,6 @@ static const struct {
> { "rng", TIOCM_RNG, false, },
> { "rts", TIOCM_RTS, true, },
> { "dtr", TIOCM_DTR, true, },
> - { "out1", TIOCM_OUT1, true, },
> - { "out2", TIOCM_OUT2, true, },
> };
>
> void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
> index bcfad5d1db61decf..332a33ab0647cbe3 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.h
> +++ b/drivers/tty/serial/serial_mctrl_gpio.h
> @@ -32,8 +32,6 @@ enum mctrl_gpio_idx {
> UART_GPIO_RI = UART_GPIO_RNG,
> UART_GPIO_RTS,
> UART_GPIO_DTR,
> - UART_GPIO_OUT1,
> - UART_GPIO_OUT2,
> UART_GPIO_MAX,
> };
>
> --
> 1.9.1
>
It seems all right now !
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
[toc] | [prev] | [next] | [standalone]
| From | Yegor Yefremov <yegorslists@googlemail.com> |
|---|---|
| Date | 2016-04-29 15:30 +0200 |
| Message-ID | <rtgEA-6Gp-37@gated-at.bofh.it> |
| In reply to | #1391131 |
On Fri, Apr 29, 2016 at 3:11 PM, Richard Genoud
<richard.genoud@gmail.com> wrote:
> 2016-04-29 13:40 GMT+02:00 Geert Uytterhoeven <geert+renesas@glider.be>:
>> The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs.
>> It doesn't make much sense to emulate GPIOs using other GPIOs, hence
>> drop support for that.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
>> ---
>> v2:
>> - Add Reviewed-by,
>> - Drop forgotten UART_GPIO_OUT[12] enum values.
>> ---
>> drivers/tty/serial/serial_mctrl_gpio.c | 2 --
>> drivers/tty/serial/serial_mctrl_gpio.h | 2 --
>> 2 files changed, 4 deletions(-)
>>
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
>> index 02147361eaa94747..821ffa637eb630cb 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.c
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
>> @@ -43,8 +43,6 @@ static const struct {
>> { "rng", TIOCM_RNG, false, },
>> { "rts", TIOCM_RTS, true, },
>> { "dtr", TIOCM_DTR, true, },
>> - { "out1", TIOCM_OUT1, true, },
>> - { "out2", TIOCM_OUT2, true, },
>> };
>>
>> void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl)
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
>> index bcfad5d1db61decf..332a33ab0647cbe3 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.h
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.h
>> @@ -32,8 +32,6 @@ enum mctrl_gpio_idx {
>> UART_GPIO_RI = UART_GPIO_RNG,
>> UART_GPIO_RTS,
>> UART_GPIO_DTR,
>> - UART_GPIO_OUT1,
>> - UART_GPIO_OUT2,
>> UART_GPIO_MAX,
>> };
>>
>> --
>> 1.9.1
>>
> It seems all right now !
>
>
> Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web