Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1391029 > unrolled thread
| Started by | Daniel Baluta <daniel.baluta@intel.com> |
|---|---|
| First post | 2016-04-29 13:50 +0200 |
| Last post | 2016-05-04 16:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] iio: bmi160: Fix ODR setting Daniel Baluta <daniel.baluta@intel.com> - 2016-04-29 13:50 +0200
Re: [PATCH 2/3] iio: bmi160: Fix ODR setting Jonathan Cameron <jic23@kernel.org> - 2016-05-04 16:40 +0200
| From | Daniel Baluta <daniel.baluta@intel.com> |
|---|---|
| Date | 2016-04-29 13:50 +0200 |
| Subject | [PATCH 2/3] iio: bmi160: Fix ODR setting |
| Message-ID | <rtf5M-5f6-1@gated-at.bofh.it> |
mask and val parameters of regmap_update_bits were reveresed.
Fixes: 77c4ad2d6a9 ("iio: imu: Add initial support for Bosch BMI160")
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
drivers/iio/imu/bmi160/bmi160_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
index cd9b75e..b8a290e 100644
--- a/drivers/iio/imu/bmi160/bmi160_core.c
+++ b/drivers/iio/imu/bmi160/bmi160_core.c
@@ -364,8 +364,8 @@ int bmi160_set_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
return regmap_update_bits(data->regmap,
bmi160_regs[t].config,
- bmi160_odr_table[t].tbl[i].bits,
- bmi160_regs[t].config_odr_mask);
+ bmi160_regs[t].config_odr_mask,
+ bmi160_odr_table[t].tbl[i].bits);
}
static int bmi160_get_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
--
2.5.0
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-05-04 16:40 +0200 |
| Message-ID | <rv684-5L8-79@gated-at.bofh.it> |
| In reply to | #1391029 |
On 29/04/16 12:42, Daniel Baluta wrote:
> mask and val parameters of regmap_update_bits were reveresed.
>
> Fixes: 77c4ad2d6a9 ("iio: imu: Add initial support for Bosch BMI160")
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git.
Not pushed out as anything at all yet.
Jonathan
> ---
> drivers/iio/imu/bmi160/bmi160_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
> index cd9b75e..b8a290e 100644
> --- a/drivers/iio/imu/bmi160/bmi160_core.c
> +++ b/drivers/iio/imu/bmi160/bmi160_core.c
> @@ -364,8 +364,8 @@ int bmi160_set_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
>
> return regmap_update_bits(data->regmap,
> bmi160_regs[t].config,
> - bmi160_odr_table[t].tbl[i].bits,
> - bmi160_regs[t].config_odr_mask);
> + bmi160_regs[t].config_odr_mask,
> + bmi160_odr_table[t].tbl[i].bits);
> }
>
> static int bmi160_get_odr(struct bmi160_data *data, enum bmi160_sensor_type t,
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web