Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390877 > unrolled thread

Re: [PATCH RESEND 1/2] pinctrl: ns2: add pinmux driver support for Broadcom NS2 SoC

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH RESEND 1/2] pinctrl: ns2: add pinmux driver support for  Broadcom NS2 SoC Linus Walleij <linus.walleij@linaro.org> - 2016-04-29 10:50 +0200

#1390877 — Re: [PATCH RESEND 1/2] pinctrl: ns2: add pinmux driver support for Broadcom NS2 SoC

On Mon, Apr 18, 2016 at 8:24 PM, Ray Jui <ray.jui@broadcom.com> wrote:
> On 4/17/2016 8:34 PM, Yendapally Reddy Dhananjaya Reddy wrote:

>>>
>>>         /* not all Iproc GPIO pins can be muxed individually */
>>>         if (!chip->pinmux_is_supported)
>>>                 return 0;
>
>
> NS2 does not support GPIO pins to be muxed individually. The call to
> iproc_gpio_request should be rejected for NS2 since
> 'chip->pinmux_is_supported' is false.

Aha, I see.

> since NS2 can only support group based GPIO configuration, the
> above functions will be rejected because "pinmux_is_supported" is false:
>
> chip->pinmux_is_supported = of_property_read_bool(dev->of_node,
> "gpio-ranges");
>
> Here, "gpio-ranges" should never be defined on NS2 DT files.

Makes perfect sense.

So for this hardware, muxing will always be done orthogonally
(using some pinctrl hogs or similar for GPIO).

I'm waiting for a version fixing the bool Kconfig issue, then I guess
the driver is ready for inclusion.

Yours,
Linus Waleij

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web